gctools-outilsgc / gcconnex

mod/missions/actions/missions/wire-post.php

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
 	$entity = get_entity($reshare_guid);
 	$wire_entity = get_entity($guid);
 
-	if ($entity->getType() == 'group'){
+	if ($entity->getType() == 'group') {
 		$entity->title = $entity->name;
 	}
 
@@ -53,7 +53,7 @@ 
 			'cp_content_reshared' => $entity,
 			'cp_wire_url' => $wire_entity->getURL(),
 		);
-		elgg_trigger_plugin_hook('cp_overwrite_notification','all',$message);
+		elgg_trigger_plugin_hook('cp_overwrite_notification', 'all', $message);
 	}
 }
 

mod/missions/actions/missions/decline-invite.php

Indentation +2 added lines, -2 removed lines

@@ -63,8 +63,8 @@
 
 // Notifies the mission manager of the candidates refusal.
 $mission_link = elgg_view('output/url', array(
-    'href' => $mission->getURL(),
-    'text' => elgg_get_excerpt($mission->job_title, elgg_get_plugin_setting('mission_job_title_card_cutoff', 'missions'))
+	'href' => $mission->getURL(),
+	'text' => elgg_get_excerpt($mission->job_title, elgg_get_plugin_setting('mission_job_title_card_cutoff', 'missions'))
 ));
 
 $subject = elgg_echo('missions:applicant_leaves', array($applicant->name));

Spacing +6 added lines, -6 removed lines

@@ -15,7 +15,7 @@ 
 
 // Processes the reason given by the declining user whether it's from the dropdown menu or the free text entry.
 $reason = get_input('reason');
-if($reason == 'missions:other') {
+if ($reason == 'missions:other') {
 	$raw_reason = $reason;
 	$reason = get_input('other_text');
 }
@@ -24,25 +24,25 @@ 
 	$reason = elgg_echo($reason);
 }
 
-if(trim($reason) == '') {
+if (trim($reason) == '') {
 	register_error(elgg_echo('missions:please_give_reason_for_declination'));
 	forward(REFERER);
 }
 
 // Deletes the tentative relationship between mission and applicant.
-if(check_entity_relationship($mission->guid, 'mission_tentative', $applicant->guid)) {
+if (check_entity_relationship($mission->guid, 'mission_tentative', $applicant->guid)) {
 	$message_return = 'missions:declination_has_been_sent';
 	remove_entity_relationship($mission->guid, 'mission_tentative', $applicant->guid);
 }
-if(check_entity_relationship($mission->guid, 'mission_applied', $applicant->guid)) {
+if (check_entity_relationship($mission->guid, 'mission_applied', $applicant->guid)) {
 	$message_return = 'missions:withdrawal_has_been_sent';
 	remove_entity_relationship($mission->guid, 'mission_applied', $applicant->guid);
 }
-if(check_entity_relationship($mission->guid, 'mission_offered', $applicant->guid)) {
+if (check_entity_relationship($mission->guid, 'mission_offered', $applicant->guid)) {
 	$message_return = 'missions:declination_has_been_sent';
 	remove_entity_relationship($mission->guid, 'mission_offered', $applicant->guid);
 }
-if(check_entity_relationship($mission->guid, 'mission_accepted', $applicant->guid)) {
+if (check_entity_relationship($mission->guid, 'mission_accepted', $applicant->guid)) {
 	$message_return = 'missions:withdrawal_has_been_sent';
 	remove_entity_relationship($mission->guid, 'mission_accepted', $applicant->guid);
   mm_complete_mission_inprogress_reports($mission, true);

Braces +1 added lines, -2 removed lines

@@ -18,8 +18,7 @@
 if($reason == 'missions:other') {
 	$raw_reason = $reason;
 	$reason = get_input('other_text');
-}
-else {
+} else {
 	$raw_reason = $reason;
 	$reason = elgg_echo($reason);
 }

mod/missions/actions/missions/search-simple.php

Indentation +64 added lines, -64 removed lines

@@ -15,84 +15,84 @@
 $search = $_GET['search'];
 
 if ($search_form['simple'] == '') {
-    $search_form['simple'] = $search;
+	$search_form['simple'] = $search;
 }
 
 if(trim($search_form['simple']) == '' ) {
 
-    $err .= elgg_echo('missions:error:search_field_empty');
+	$err .= elgg_echo('missions:error:search_field_empty');
     
 }
 
 // Currently no error checking is being done for the search form
 if ($err != '') {
-    register_error($err);
-    forward(REFERER);
+	register_error($err);
+	forward(REFERER);
 } else {
-    $array = array();
+	$array = array();
 
-    switch($_SESSION['mission_search_switch']) {
-        case 'candidate':
-            // A multipurpose query which will be applied to skills, experience and education objects.
-            if (!empty($search_form['simple'])) {
-            	$string_to_array = explode(',', str_replace(', ', ',', $search_form['simple']));
+	switch($_SESSION['mission_search_switch']) {
+		case 'candidate':
+			// A multipurpose query which will be applied to skills, experience and education objects.
+			if (!empty($search_form['simple'])) {
+				$string_to_array = explode(',', str_replace(', ', ',', $search_form['simple']));
 
-            	foreach($string_to_array as $value) {
-            		$array[] = preg_replace('/[^\p{L}\p{N}_]+/u', ' ', $value);
-            	}
-            }
-            $returned = mm_simple_search_database_for_candidates($array, max($_SESSION['candidate_entities_per_page'], 10));
-            break;
-        default:            
-            // A broad range search which determines whether the input text exists within the title, type or description of the mission.
-            // This also checks guid but this is mostly for testing and admin purposes.
-            if (! empty($search_form['simple'])) {
-                $array[0] = array(
-                    'name' => 'job_title',
-                    'operand' => 'LIKE',
-                    'value' => '%' . $search_form['simple'] . '%'
-                );
-                $array[1] = array(
-                    'name' => 'descriptor',
-                    'operand' => 'LIKE',
-                    'value' => '%' . $search_form['simple'] . '%'
-                );
-                $array[2] = array(
-                    'name' => 'meta_guid',
-                    'operand' => '=',
-                    'value' => $search_form['simple']
-                );
+				foreach($string_to_array as $value) {
+					$array[] = preg_replace('/[^\p{L}\p{N}_]+/u', ' ', $value);
+				}
+			}
+			$returned = mm_simple_search_database_for_candidates($array, max($_SESSION['candidate_entities_per_page'], 10));
+			break;
+		default:            
+			// A broad range search which determines whether the input text exists within the title, type or description of the mission.
+			// This also checks guid but this is mostly for testing and admin purposes.
+			if (! empty($search_form['simple'])) {
+				$array[0] = array(
+					'name' => 'job_title',
+					'operand' => 'LIKE',
+					'value' => '%' . $search_form['simple'] . '%'
+				);
+				$array[1] = array(
+					'name' => 'descriptor',
+					'operand' => 'LIKE',
+					'value' => '%' . $search_form['simple'] . '%'
+				);
+				$array[2] = array(
+					'name' => 'meta_guid',
+					'operand' => '=',
+					'value' => $search_form['simple']
+				);
 
-                $translation_key = mm_get_translation_key_from_setting_string($search_form['simple'], elgg_get_plugin_setting('opportunity_type_string', 'missions'));
-                if($translation_key) {
-	                $array[3] = array(
-	                    'name' => 'job_type',
-	                    'operand' => '=',
-	                    'value' => $translation_key
-	                );
-                }
-            }
+				$translation_key = mm_get_translation_key_from_setting_string($search_form['simple'], elgg_get_plugin_setting('opportunity_type_string', 'missions'));
+				if($translation_key) {
+					$array[3] = array(
+						'name' => 'job_type',
+						'operand' => '=',
+						'value' => $translation_key
+					);
+				}
+			}
 
-            // Specify which missions' states we would like to filter by.  Inclusive.
-            $mission_state_include_array = ['posted'];
-            if (isset($_SESSION['mission_search_switch_subtype']) && $_SESSION['mission_search_switch_subtype'] == 'archive') {
-                $mission_state_include_array = ['cancelled', 'completed'];
-                unset($_SESSION['mission_search_switch_subtype']);
-            }
+			// Specify which missions' states we would like to filter by.  Inclusive.
+			$mission_state_include_array = ['posted'];
+			if (isset($_SESSION['mission_search_switch_subtype']) && $_SESSION['mission_search_switch_subtype'] == 'archive') {
+				$mission_state_include_array = ['cancelled', 'completed'];
+				unset($_SESSION['mission_search_switch_subtype']);
+			}
             
-            $returned = mm_search_database_for_missions($array, 'OR', elgg_get_plugin_setting('search_limit', 'missions'), $mission_state_include_array);
-    }
+			$returned = mm_search_database_for_missions($array, 'OR', elgg_get_plugin_setting('search_limit', 'missions'), $mission_state_include_array);
+	}
 
-    if (! $returned) {
-        forward(REFERER);
-    } else {
-        // reset the offset on new search
-        $ref = $_SERVER['HTTP_REFERER'];
-        $ref = preg_replace('/([?&])offset=[^&]+(&|$)/','$1', $ref);
-      //  elgg_clear_sticky_form('searchsimplefill');
-        if($search_form['hidden_return']) {
-        	forward($ref);
-        }
-        forward(elgg_get_site_url() . 'missions/display-search-set');
-    }
+	if (! $returned) {
+		forward(REFERER);
+	} else {
+		// reset the offset on new search
+		$ref = $_SERVER['HTTP_REFERER'];
+		$ref = preg_replace('/([?&])offset=[^&]+(&|$)/','$1', $ref);
+	  //  elgg_clear_sticky_form('searchsimplefill');
+		if($search_form['hidden_return']) {
+			forward($ref);
+		}
+		forward(elgg_get_site_url() . 'missions/display-search-set');
+	}
 }

Spacing +8 added lines, -8 removed lines

@@ -18,7 +18,7 @@ 
     $search_form['simple'] = $search;
 }
 
-if(trim($search_form['simple']) == '' ) {
+if (trim($search_form['simple']) == '') {
 
     $err .= elgg_echo('missions:error:search_field_empty');
     
@@ -31,13 +31,13 @@ 
 } else {
     $array = array();
 
-    switch($_SESSION['mission_search_switch']) {
+    switch ($_SESSION['mission_search_switch']) {
         case 'candidate':
             // A multipurpose query which will be applied to skills, experience and education objects.
             if (!empty($search_form['simple'])) {
             	$string_to_array = explode(',', str_replace(', ', ',', $search_form['simple']));
 
-            	foreach($string_to_array as $value) {
+            	foreach ($string_to_array as $value) {
             		$array[] = preg_replace('/[^\p{L}\p{N}_]+/u', ' ', $value);
             	}
             }
@@ -46,7 +46,7 @@ 
         default:            
             // A broad range search which determines whether the input text exists within the title, type or description of the mission.
             // This also checks guid but this is mostly for testing and admin purposes.
-            if (! empty($search_form['simple'])) {
+            if (!empty($search_form['simple'])) {
                 $array[0] = array(
                     'name' => 'job_title',
                     'operand' => 'LIKE',
@@ -64,7 +64,7 @@ 
                 );
 
                 $translation_key = mm_get_translation_key_from_setting_string($search_form['simple'], elgg_get_plugin_setting('opportunity_type_string', 'missions'));
-                if($translation_key) {
+                if ($translation_key) {
 	                $array[3] = array(
 	                    'name' => 'job_type',
 	                    'operand' => '=',
@@ -83,14 +83,14 @@ 
             $returned = mm_search_database_for_missions($array, 'OR', elgg_get_plugin_setting('search_limit', 'missions'), $mission_state_include_array);
     }
 
-    if (! $returned) {
+    if (!$returned) {
         forward(REFERER);
     } else {
         // reset the offset on new search
         $ref = $_SERVER['HTTP_REFERER'];
-        $ref = preg_replace('/([?&])offset=[^&]+(&|$)/','$1', $ref);
+        $ref = preg_replace('/([?&])offset=[^&]+(&|$)/', '$1', $ref);
       //  elgg_clear_sticky_form('searchsimplefill');
-        if($search_form['hidden_return']) {
+        if ($search_form['hidden_return']) {
         	forward($ref);
         }
         forward(elgg_get_site_url() . 'missions/display-search-set');

mod/missions/actions/missions/mission-offer.php

Indentation +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 			add_entity_relationship($mission->guid, 'mission_offered', $applicant->guid);
 
 			// Create a record of when the mission is offered for Analytics
-      $ia = elgg_set_ignore_access(true);
+	  $ia = elgg_set_ignore_access(true);
 			$accept_record = new ElggObject();
 			$accept_record->subtype = 'mission-wasoffered';
 			$accept_record->title = 'Mission Offer Report';
@@ -45,7 +45,7 @@ 
 			$accept_record->owner_guid = $applicant->guid;
 			$accept_record->mission_guid = $mission->guid;
 			$accept_record->save();
-      elgg_set_ignore_access($ia);
+	  elgg_set_ignore_access($ia);
 
 			$finalize_link = elgg_view('output/url', array(
 					'href' => elgg_get_site_url() . 'missions/view/' . $mission->guid,

Spacing +3 added lines, -3 removed lines

@@ -15,11 +15,11 @@ 
 
 $err = '';
 
-if($mission == '') {
+if ($mission == '') {
 	$err .= elgg_echo('missions:error:entity_does_not_exist');
 }
 else {
-	if(!check_entity_relationship($mission->guid, 'mission_applied', $applicant->guid)) {
+	if (!check_entity_relationship($mission->guid, 'mission_applied', $applicant->guid)) {
 		$err .= elgg_echo('missions:error:applicant_not_applied_to_mission', array($applicant->name));
 	}
 	else {
@@ -29,7 +29,7 @@ 
 				'count' => true
 		));
 	    
-		if($relationship_count >= $mission->number) {
+		if ($relationship_count >= $mission->number) {
 			$err .= elgg_echo('missions:error:mission_full');
 		}
 		else {

Braces +4 added lines, -8 removed lines

@@ -17,12 +17,10 @@ 
 
 if($mission == '') {
 	$err .= elgg_echo('missions:error:entity_does_not_exist');
-}
-else {
+} else {
 	if(!check_entity_relationship($mission->guid, 'mission_applied', $applicant->guid)) {
 		$err .= elgg_echo('missions:error:applicant_not_applied_to_mission', array($applicant->name));
-	}
-	else {
+	} else {
 		$relationship_count = elgg_get_entities_from_relationship(array(
 				'relationship' => 'mission_accepted',
 				'relationship_guid' => $mission->guid,
@@ -31,8 +29,7 @@ 
 	    
 		if($relationship_count >= $mission->number) {
 			$err .= elgg_echo('missions:error:mission_full');
-		}
-		else {
+		} else {
 			remove_entity_relationship($mission->guid, 'mission_applied', $applicant->guid);
 			add_entity_relationship($mission->guid, 'mission_offered', $applicant->guid);
 
@@ -62,8 +59,7 @@ 
 if ($err != '') {
 	register_error($err);
 	forward(REFERER);
-}
-else {
+} else {
 	system_message(elgg_echo('missions:offered_user_position', array($applicant->name, $mission->job_title)));
 	forward($mission->getURL());
 }
\ No newline at end of file

mod/missions/actions/missions/post-mission-third-form.php

Indentation +140 added lines, -140 removed lines

@@ -37,41 +37,41 @@ 
 
 // Error reporting for bad user input
 if ($err != '') {
-    register_error($err);
-    forward(REFERER);
+	register_error($err);
+	forward(REFERER);
 } else {
-    // $third_form = combine_time_table_from_array($third_form);
+	// $third_form = combine_time_table_from_array($third_form);
 
-    // Creation of an ELGGObject of subtype Mission
-    $mission = new ElggObject();
-    $mission->subtype = 'mission';
-    $mission->title = $second_form['job_title'];
-    $mission->description = $second_form['description'];
-    $mission->access_id = ACCESS_LOGGED_IN;
-    $mission->owner_guid = elgg_get_logged_in_user_guid();
+	// Creation of an ELGGObject of subtype Mission
+	$mission = new ElggObject();
+	$mission->subtype = 'mission';
+	$mission->title = $second_form['job_title'];
+	$mission->description = $second_form['description'];
+	$mission->access_id = ACCESS_LOGGED_IN;
+	$mission->owner_guid = elgg_get_logged_in_user_guid();
 
-    // Attaches the form data as metadata to the object
-    $mission->name = $first_form['name'];
+	// Attaches the form data as metadata to the object
+	$mission->name = $first_form['name'];
 
-    // If the organization tree is loaded, then the custom dropdown values will be processed and stored.
-    if(mo_get_tree_root()) {
+	// If the organization tree is loaded, then the custom dropdown values will be processed and stored.
+	if(mo_get_tree_root()) {
 	   	$department_string = mo_get_last_input_node($first_form);
 		$department_paths = mo_string_all_ancestors($department_string);
 		$mission->department = $department_string;
 		$mission->department_path_english = $department_paths['english_path'];
 		$mission->department_path_french = $department_paths['french_path'];
-    }
-    // If the organization tree is not loaded, then the basic free text entry will be stored.
-    else {
-    	$mission->department = $first_form['department'];
+	}
+	// If the organization tree is not loaded, then the basic free text entry will be stored.
+	else {
+		$mission->department = $first_form['department'];
 		$mission->department_path_english = $first_form['department'];
 		$mission->department_path_french = $first_form['department'];
-    }
+	}
 
-    $mission->email = $first_form['email'];
-    $mission->phone = $first_form['phone'];
+	$mission->email = $first_form['email'];
+	$mission->phone = $first_form['phone'];
 
-    $accounts = get_user_by_email($first_form['email']);
+	$accounts = get_user_by_email($first_form['email']);
 //Compare email and username for user with more than one account
 		foreach ($accounts as $key) {
 			if($key->name == $first_form['name']){
@@ -80,29 +80,29 @@ 
 		}
 
 		if($guid_account){
-			    $mission->account = array_pop($guid_account)->guid;
+				$mission->account = array_pop($guid_account)->guid;
 		}else{
-			    $mission->account = array_pop($accounts)->guid;
+				$mission->account = array_pop($accounts)->guid;
 		}
 
 
-    $mission->job_title = $second_form['job_title'];
-    $mission->role_type = $second_form['role_type'];
-    $mission->job_type = $second_form['job_type'];
+	$mission->job_title = $second_form['job_title'];
+	$mission->role_type = $second_form['role_type'];
+	$mission->job_type = $second_form['job_type'];
 	// Stores the value of program area selected unless it is other.
-    if($second_form['job_area'] != 'missions:other') {
-    	$mission->program_area = $second_form['job_area'];
-    }
+	if($second_form['job_area'] != 'missions:other') {
+		$mission->program_area = $second_form['job_area'];
+	}
 	// When other is selected, the free text entry is stored instead.
-    else {
-    	$mission->program_area = $second_form['other_text'];
-    }
-    $mission->number = $second_form['number'];
-    $mission->start_date = $second_form['start_date'];
-    $mission->completion_date = $second_form['completion_date'];
-    $mission->deadline = $second_form['deadline'];
-    $mission->descriptor = $second_form['description'];
-    $mission->openess = $second_form['openess'];
+	else {
+		$mission->program_area = $second_form['other_text'];
+	}
+	$mission->number = $second_form['number'];
+	$mission->start_date = $second_form['start_date'];
+	$mission->completion_date = $second_form['completion_date'];
+	$mission->deadline = $second_form['deadline'];
+	$mission->descriptor = $second_form['description'];
+	$mission->openess = $second_form['openess'];
 
 		//Nick - Adding group and level to the mission meta data
 		if($second_form['group']){
@@ -110,36 +110,36 @@ 
 			$mission->gl_level = $second_form['level'];
 		}
 
-    $mission->remotely = $third_form['remotely'];
-    //$mission->flexibility = $third_form['flexibility'];
-    $mission->security = $third_form['security'];
-    $mission->location = $third_form['location'];
-    $mission->time_commitment = $third_form['time_commitment'];
-    $mission->time_interval = $third_form['time_interval'];
-    $mission->timezone = $third_form['timezone'];
-
-    // Stores the multiple skill fields in a comma separated string.
-    $count = 0;
-    $key_skills = '';
-    $skill_array = array();
-    foreach($third_form as $key => $value) {
-    	if(!(strpos($key, 'skill') === false) && $value) {
-    		$skill_array[$count] = $value;
-    		if($count == 0) {
-    			$key_skills .= $value;
-    		}
-    		else {
-    			$key_skills .= ', ' . $value;
-    		}
-    		$count++;
-    	}
-    }
-    $mission->key_skills = $key_skills;
+	$mission->remotely = $third_form['remotely'];
+	//$mission->flexibility = $third_form['flexibility'];
+	$mission->security = $third_form['security'];
+	$mission->location = $third_form['location'];
+	$mission->time_commitment = $third_form['time_commitment'];
+	$mission->time_interval = $third_form['time_interval'];
+	$mission->timezone = $third_form['timezone'];
+
+	// Stores the multiple skill fields in a comma separated string.
+	$count = 0;
+	$key_skills = '';
+	$skill_array = array();
+	foreach($third_form as $key => $value) {
+		if(!(strpos($key, 'skill') === false) && $value) {
+			$skill_array[$count] = $value;
+			if($count == 0) {
+				$key_skills .= $value;
+			}
+			else {
+				$key_skills .= ', ' . $value;
+			}
+			$count++;
+		}
+	}
+	$mission->key_skills = $key_skills;
 
-    $mission->english = mm_pack_language($third_form['lwc_english'], $third_form['lwe_english'], $third_form['lop_english'], 'english');
-    $mission->french = mm_pack_language($third_form['lwc_french'], $third_form['lwe_french'], $third_form['lop_french'], 'french');
+	$mission->english = mm_pack_language($third_form['lwc_english'], $third_form['lwe_english'], $third_form['lop_english'], 'english');
+	$mission->french = mm_pack_language($third_form['lwc_french'], $third_form['lwe_french'], $third_form['lop_french'], 'french');
 
-    /*$mission->mon_start = mm_pack_time($third_form['mon_start_hour'], $third_form['mon_start_min'], 'mon_start');
+	/*$mission->mon_start = mm_pack_time($third_form['mon_start_hour'], $third_form['mon_start_min'], 'mon_start');
     $mission->mon_duration = mm_pack_time($third_form['mon_duration_hour'], $third_form['mon_duration_min'], 'mon_duration');
     $mission->tue_start = mm_pack_time($third_form['tue_start_hour'], $third_form['tue_start_min'], 'tue_start');
     $mission->tue_duration = mm_pack_time($third_form['tue_duration_hour'], $third_form['tue_duration_min'], 'tue_duration');
@@ -153,86 +153,86 @@ 
     $mission->sat_duration = mm_pack_time($third_form['sat_duration_hour'], $third_form['sat_duration_min'], 'sat_duration');
     $mission->sun_start = mm_pack_time($third_form['sun_start_hour'], $third_form['sun_start_min'], 'sun_start');
     $mission->sun_duration = mm_pack_time($third_form['sun_duration_hour'], $third_form['sun_duration_min'], 'sun_duration');*/
-    $mission->mon_start = $third_form['mon_start'];
-    $mission->mon_duration = $third_form['mon_duration'];
-    $mission->tue_start = $third_form['tue_start'];
-    $mission->tue_duration = $third_form['tue_duration'];
-    $mission->wed_start = $third_form['wed_start'];
-    $mission->wed_duration = $third_form['wed_duration'];
-    $mission->thu_start = $third_form['thu_start'];
-    $mission->thu_duration = $third_form['thu_duration'];
-    $mission->fri_start = $third_form['fri_start'];
-    $mission->fri_duration = $third_form['fri_duration'];
-    $mission->sat_start = $third_form['sat_start'];
-    $mission->sat_duration = $third_form['sat_duration'];
-    $mission->sun_start = $third_form['sun_start'];
-    $mission->sun_duration = $third_form['sun_duration'];
-
-    $mission->state = 'posted';
-    $mission->version = elgg_get_plugin_setting('mission_version', 'missions');
-
-    $mission->time_to_post = time() - $_SESSION['mission_creation_begin_timestamp'];
-
-    // Sends the object and all its metadata to the database
-    $mission->save();
-
-    $mission->meta_guid = $mission->guid;
-
-    $mission->save();
-
-    // Generate an analytics record to track "posted".
-    $analytics_record = new ElggObject();
-    $analytics_record->subtype = 'mission-posted';
-    $analytics_record->title = 'Mission Posted Report';
-    $analytics_record->mission_guid = $mission->guid;
-    $analytics_record->access_id = ACCESS_LOGGED_IN;
-    $analytics_record->save();
-
-    // Creates a relationships between the user (manager) and the mission.
-    add_entity_relationship($mission->account, 'mission_posted', $mission->guid);
-
-    // Add to the river so it can be seen on the main page.
-    elgg_create_river_item(array(
-        'view' => 'river/object/mission/create',
-        'action_type' => 'create',
-        'subject_guid' => $mission->owner_guid,
-        'object_guid' => $mission->getGUID()
-    ));
-    //add_to_river('river/object/mission/create', 'create', $mission->owner_guid, $mission->getGUID());
-
-    $_SESSION['mission_skill_match_array'] = $skill_array;
-    unset($_SESSION['mission_duplicating_override_first']);
-    unset($_SESSION['mission_duplicating_override_second']);
-    unset($_SESSION['mission_duplicating_override_third']);
-
-    if(count($skill_array) == 0) {
+	$mission->mon_start = $third_form['mon_start'];
+	$mission->mon_duration = $third_form['mon_duration'];
+	$mission->tue_start = $third_form['tue_start'];
+	$mission->tue_duration = $third_form['tue_duration'];
+	$mission->wed_start = $third_form['wed_start'];
+	$mission->wed_duration = $third_form['wed_duration'];
+	$mission->thu_start = $third_form['thu_start'];
+	$mission->thu_duration = $third_form['thu_duration'];
+	$mission->fri_start = $third_form['fri_start'];
+	$mission->fri_duration = $third_form['fri_duration'];
+	$mission->sat_start = $third_form['sat_start'];
+	$mission->sat_duration = $third_form['sat_duration'];
+	$mission->sun_start = $third_form['sun_start'];
+	$mission->sun_duration = $third_form['sun_duration'];
+
+	$mission->state = 'posted';
+	$mission->version = elgg_get_plugin_setting('mission_version', 'missions');
+
+	$mission->time_to_post = time() - $_SESSION['mission_creation_begin_timestamp'];
+
+	// Sends the object and all its metadata to the database
+	$mission->save();
+
+	$mission->meta_guid = $mission->guid;
+
+	$mission->save();
+
+	// Generate an analytics record to track "posted".
+	$analytics_record = new ElggObject();
+	$analytics_record->subtype = 'mission-posted';
+	$analytics_record->title = 'Mission Posted Report';
+	$analytics_record->mission_guid = $mission->guid;
+	$analytics_record->access_id = ACCESS_LOGGED_IN;
+	$analytics_record->save();
+
+	// Creates a relationships between the user (manager) and the mission.
+	add_entity_relationship($mission->account, 'mission_posted', $mission->guid);
+
+	// Add to the river so it can be seen on the main page.
+	elgg_create_river_item(array(
+		'view' => 'river/object/mission/create',
+		'action_type' => 'create',
+		'subject_guid' => $mission->owner_guid,
+		'object_guid' => $mission->getGUID()
+	));
+	//add_to_river('river/object/mission/create', 'create', $mission->owner_guid, $mission->getGUID());
+
+	$_SESSION['mission_skill_match_array'] = $skill_array;
+	unset($_SESSION['mission_duplicating_override_first']);
+	unset($_SESSION['mission_duplicating_override_second']);
+	unset($_SESSION['mission_duplicating_override_third']);
+
+	if(count($skill_array) == 0) {
 		elgg_clear_sticky_form('firstfill');
 		elgg_clear_sticky_form('secondfill');
 		elgg_clear_sticky_form('thirdfill');
 		elgg_clear_sticky_form('ldropfill');
 		elgg_clear_sticky_form('tdropfill');
-    	system_message(elgg_echo('missions:succesfully_posted', array($mission->job_title)));
-    	forward(elgg_get_site_url() . 'missions/main');
-    }
-    else {
-	    if($third_form['hidden_java_state'] == 'noscript') {
-	    	// Required action security tokens.
-	    	$ts = time();
-	    	$token = generate_action_token($ts);
-	    	set_input('__elgg_ts', $ts);
-	    	set_input('__elgg_token', $token);
-
-	    	action('missions/post-mission-skill-match');
-	    }
-	    else {
-		    $_SESSION['mission_skill_match_is_interlude'] = true;
-		    system_message(elgg_echo('missions:saved_beginning_skill_match', array($key_skills)));
-		    forward(REFERER);
-	    }
-    }
+		system_message(elgg_echo('missions:succesfully_posted', array($mission->job_title)));
+		forward(elgg_get_site_url() . 'missions/main');
+	}
+	else {
+		if($third_form['hidden_java_state'] == 'noscript') {
+			// Required action security tokens.
+			$ts = time();
+			$token = generate_action_token($ts);
+			set_input('__elgg_ts', $ts);
+			set_input('__elgg_token', $token);
+
+			action('missions/post-mission-skill-match');
+		}
+		else {
+			$_SESSION['mission_skill_match_is_interlude'] = true;
+			system_message(elgg_echo('missions:saved_beginning_skill_match', array($key_skills)));
+			forward(REFERER);
+		}
+	}
 
 
-    /*
+	/*
     // Finds a list of users who have the same skills that were input in the third form.
     $user_skill_match = array();
     foreach($skill_array as $skill) {

Spacing +12 added lines, -12 removed lines

@@ -31,7 +31,7 @@ 
 // A specialized function for checking for errors in the time fields
 $err .= mm_validate_time_all($third_form);
 
-if($err == '') {
+if ($err == '') {
 	$err .= mm_third_post_special_error_check($third_form);
 }
 
@@ -54,7 +54,7 @@ 
     $mission->name = $first_form['name'];
 
     // If the organization tree is loaded, then the custom dropdown values will be processed and stored.
-    if(mo_get_tree_root()) {
+    if (mo_get_tree_root()) {
 	   	$department_string = mo_get_last_input_node($first_form);
 		$department_paths = mo_string_all_ancestors($department_string);
 		$mission->department = $department_string;
@@ -74,14 +74,14 @@ 
     $accounts = get_user_by_email($first_form['email']);
 //Compare email and username for user with more than one account
 		foreach ($accounts as $key) {
-			if($key->name == $first_form['name']){
+			if ($key->name == $first_form['name']) {
 				$guid_account[] = $key;
 			}
 		}
 
-		if($guid_account){
+		if ($guid_account) {
 			    $mission->account = array_pop($guid_account)->guid;
-		}else{
+		} else {
 			    $mission->account = array_pop($accounts)->guid;
 		}
 
@@ -90,7 +90,7 @@ 
     $mission->role_type = $second_form['role_type'];
     $mission->job_type = $second_form['job_type'];
 	// Stores the value of program area selected unless it is other.
-    if($second_form['job_area'] != 'missions:other') {
+    if ($second_form['job_area'] != 'missions:other') {
     	$mission->program_area = $second_form['job_area'];
     }
 	// When other is selected, the free text entry is stored instead.
@@ -105,7 +105,7 @@ 
     $mission->openess = $second_form['openess'];
 
 		//Nick - Adding group and level to the mission meta data
-		if($second_form['group']){
+		if ($second_form['group']) {
 			$mission->gl_group = $second_form['group'];
 			$mission->gl_level = $second_form['level'];
 		}
@@ -122,10 +122,10 @@ 
     $count = 0;
     $key_skills = '';
     $skill_array = array();
-    foreach($third_form as $key => $value) {
-    	if(!(strpos($key, 'skill') === false) && $value) {
+    foreach ($third_form as $key => $value) {
+    	if (!(strpos($key, 'skill') === false) && $value) {
     		$skill_array[$count] = $value;
-    		if($count == 0) {
+    		if ($count == 0) {
     			$key_skills .= $value;
     		}
     		else {
@@ -205,7 +205,7 @@ 
     unset($_SESSION['mission_duplicating_override_second']);
     unset($_SESSION['mission_duplicating_override_third']);
 
-    if(count($skill_array) == 0) {
+    if (count($skill_array) == 0) {
 		elgg_clear_sticky_form('firstfill');
 		elgg_clear_sticky_form('secondfill');
 		elgg_clear_sticky_form('thirdfill');
@@ -215,7 +215,7 @@ 
     	forward(elgg_get_site_url() . 'missions/main');
     }
     else {
-	    if($third_form['hidden_java_state'] == 'noscript') {
+	    if ($third_form['hidden_java_state'] == 'noscript') {
 	    	// Required action security tokens.
 	    	$ts = time();
 	    	$token = generate_action_token($ts);

Braces +4 added lines, -7 removed lines

@@ -81,7 +81,7 @@ 
 
 		if($guid_account){
 			    $mission->account = array_pop($guid_account)->guid;
-		}else{
+		} else{
 			    $mission->account = array_pop($accounts)->guid;
 		}
 
@@ -127,8 +127,7 @@ 
     		$skill_array[$count] = $value;
     		if($count == 0) {
     			$key_skills .= $value;
-    		}
-    		else {
+    		} else {
     			$key_skills .= ', ' . $value;
     		}
     		$count++;
@@ -213,8 +212,7 @@ 
 		elgg_clear_sticky_form('tdropfill');
     	system_message(elgg_echo('missions:succesfully_posted', array($mission->job_title)));
     	forward(elgg_get_site_url() . 'missions/main');
-    }
-    else {
+    } else {
 	    if($third_form['hidden_java_state'] == 'noscript') {
 	    	// Required action security tokens.
 	    	$ts = time();
@@ -223,8 +221,7 @@ 
 	    	set_input('__elgg_token', $token);
 
 	    	action('missions/post-mission-skill-match');
-	    }
-	    else {
+	    } else {
 		    $_SESSION['mission_skill_match_is_interlude'] = true;
 		    system_message(elgg_echo('missions:saved_beginning_skill_match', array($key_skills)));
 		    forward(REFERER);

mod/missions/actions/missions/reopen-mission.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 system_message(elgg_echo('missions:has_been_reopened', array($mission->job_title)));
 
 // If the admin tool is calling the action then the user is returned to the admin tool page.
-if($from_admin) {
+if ($from_admin) {
 	forward(REFERER);
 }
 

mod/missions/actions/missions/advanced-search-form.php

Indentation +41 added lines, -41 removed lines

@@ -26,60 +26,60 @@
 // Detects if backup fields are active or not. If they are then Javascript is disabled.
 $noscript = false;
 foreach ($advanced_form as $name => $value) {
-    if(strpos($name, 'backup_') !== false) {
-        if($value != '') {
-            $noscript = true;
-        }
-    }
+	if(strpos($name, 'backup_') !== false) {
+		if($value != '') {
+			$noscript = true;
+		}
+	}
 }
 
 // Currently no error checking is done but the support for it is set.
 if ($err != '') {
-    register_error($err);
-    forward(REFERER);
+	register_error($err);
+	forward(REFERER);
 } else {
-    $query_clean = '';
-    $array = array();
+	$query_clean = '';
+	$array = array();
     
-    /*
+	/*
      * Runs through all the search fields and evaluates them.
      * Evaluation is different when Javascript is enabled or disabled.
      * Empty evaluations are discarded.
      */
-    for ($i = 0; $i < $element_total; $i ++) {
-        if($noscript) {
-            $query_clean = mm_analyze_backup($i, $advanced_form);
-        } 
-        else {
-            $query_clean = mm_analyze_advanced_search_element($i, $advanced_form);
-        }
-        if(!empty($query_clean)) {
-            $array[$i] = $query_clean;
-        }
-    }
+	for ($i = 0; $i < $element_total; $i ++) {
+		if($noscript) {
+			$query_clean = mm_analyze_backup($i, $advanced_form);
+		} 
+		else {
+			$query_clean = mm_analyze_advanced_search_element($i, $advanced_form);
+		}
+		if(!empty($query_clean)) {
+			$array[$i] = $query_clean;
+		}
+	}
     
-    // These functions executes the query and returns true or false depending on how succesful that query was.
-    switch($_SESSION['mission_search_switch']) {
-        case 'candidate':
-            // Function for candidate searching.
-            $returned = mm_advanced_search_database_for_candidates($array, 'AND', elgg_get_plugin_setting('search_limit', 'missions'));
-            break;
-        default:
-            // Function for mission searching.
-            $returned = mm_search_database_for_missions($array, 'AND', elgg_get_plugin_setting('search_limit', 'missions'));
-    }
+	// These functions executes the query and returns true or false depending on how succesful that query was.
+	switch($_SESSION['mission_search_switch']) {
+		case 'candidate':
+			// Function for candidate searching.
+			$returned = mm_advanced_search_database_for_candidates($array, 'AND', elgg_get_plugin_setting('search_limit', 'missions'));
+			break;
+		default:
+			// Function for mission searching.
+			$returned = mm_search_database_for_missions($array, 'AND', elgg_get_plugin_setting('search_limit', 'missions'));
+	}
     
-    /*
+	/*
      * If the $returned value is null then the user is sent back to the search page.
      * Otherwise they are sent to the search result.
      */
-    if (! $returned) {
-        forward(REFERER);
-    } else {
-        //elgg_clear_sticky_form('advancedfill');
-        if($advanced_form['hidden_return']) {
-        	forward(REFERER);
-        }
-        forward(elgg_get_site_url() . 'missions/display-search-set');
-    }
+	if (! $returned) {
+		forward(REFERER);
+	} else {
+		//elgg_clear_sticky_form('advancedfill');
+		if($advanced_form['hidden_return']) {
+			forward(REFERER);
+		}
+		forward(elgg_get_site_url() . 'missions/display-search-set');
+	}
 }
\ No newline at end of file

Spacing +8 added lines, -8 removed lines

@@ -26,8 +26,8 @@ 
 // Detects if backup fields are active or not. If they are then Javascript is disabled.
 $noscript = false;
 foreach ($advanced_form as $name => $value) {
-    if(strpos($name, 'backup_') !== false) {
-        if($value != '') {
+    if (strpos($name, 'backup_') !== false) {
+        if ($value != '') {
             $noscript = true;
         }
     }
@@ -46,20 +46,20 @@ 
      * Evaluation is different when Javascript is enabled or disabled.
      * Empty evaluations are discarded.
      */
-    for ($i = 0; $i < $element_total; $i ++) {
-        if($noscript) {
+    for ($i = 0; $i < $element_total; $i++) {
+        if ($noscript) {
             $query_clean = mm_analyze_backup($i, $advanced_form);
         } 
         else {
             $query_clean = mm_analyze_advanced_search_element($i, $advanced_form);
         }
-        if(!empty($query_clean)) {
+        if (!empty($query_clean)) {
             $array[$i] = $query_clean;
         }
     }
     
     // These functions executes the query and returns true or false depending on how succesful that query was.
-    switch($_SESSION['mission_search_switch']) {
+    switch ($_SESSION['mission_search_switch']) {
         case 'candidate':
             // Function for candidate searching.
             $returned = mm_advanced_search_database_for_candidates($array, 'AND', elgg_get_plugin_setting('search_limit', 'missions'));
@@ -73,11 +73,11 @@ 
      * If the $returned value is null then the user is sent back to the search page.
      * Otherwise they are sent to the search result.
      */
-    if (! $returned) {
+    if (!$returned) {
         forward(REFERER);
     } else {
         //elgg_clear_sticky_form('advancedfill');
-        if($advanced_form['hidden_return']) {
+        if ($advanced_form['hidden_return']) {
         	forward(REFERER);
         }
         forward(elgg_get_site_url() . 'missions/display-search-set');

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
     for ($i = 0; $i < $element_total; $i ++) {
         if($noscript) {
             $query_clean = mm_analyze_backup($i, $advanced_form);
-        } 
-        else {
+        } else {
             $query_clean = mm_analyze_advanced_search_element($i, $advanced_form);
         }
         if(!empty($query_clean)) {

mod/missions/actions/missions/cancel-mission.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 ));
 
 // Does not allow the misssion to be cancelled if the count is not zero.
-if($relationship_count > 0) {
+if ($relationship_count > 0) {
 	register_error(elgg_echo('missions:cannot_cancel_mission_with_participants'));
 	forward(REFERER);
 }
@@ -50,7 +50,7 @@ 
 	system_message(elgg_echo('missions:has_been_cancelled', array($mission->job_title)));
 	
 	// If the admin tool is calling the action then the user is returned to the admin tool page.
-	if($from_admin) {
+	if ($from_admin) {
 		forward(REFERER);
 	}
 	

Braces +1 added lines, -2 removed lines

@@ -30,8 +30,7 @@
 if($relationship_count > 0) {
 	register_error(elgg_echo('missions:cannot_cancel_mission_with_participants'));
 	forward(REFERER);
-}
-else {
+} else {
 	$mission->state = 'cancelled';
 	$mission->time_to_cancel = time() - $mission->time_created;
 	$mission->time_closed = time();

mod/missions/actions/missions/post-mission-second-form.php

Indentation +3 added lines, -3 removed lines

@@ -22,8 +22,8 @@
 $err .= mm_second_post_error_check($second_form);
 
 if ($err == '') {
-    forward(elgg_get_site_url() . 'missions/mission-post/step-three');
+	forward(elgg_get_site_url() . 'missions/mission-post/step-three');
 } else {
-    register_error($err);
-    forward(REFERER);
+	register_error($err);
+	forward(REFERER);
 }