ModPleio\Import

Complexity

Total Complexity

14

Size/Duplication

Total Lines	73
Duplicated Lines	15.07 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	extractData()	0	12	3
A	registerUser()	0	19	4
A	generateUniqueUsername()	11	23	3
A	getUserByAttributes()	0	14	4

<?php
namespace ModPleio;

class Import {
    public function extractData($columns, $data) {
        $result = [];
        foreach ($columns as $id => $metadata_name) {
            if (!$metadata_name) {
                continue;
            }

            $result[$metadata_name] = $data[$id];
        }

        return $result;
    }

    public function registerUser($data) {
        if (!$data["name"] || !$data["email"]) {
            return false;
        }

        $user = false;

        try {
            $username = Import::generateUniqueUsername($data);
            $password = generate_random_cleartext_password();
            $guid = register_user($username, $password, $data["name"], $data["email"]);
            elgg_set_user_validation_status($guid, true, "email");

It seems like $guid defined by register_user($username, $password, $data['name'], $data['email']) on line 28 can also be of type false or null; however, elgg_set_user_validation_status() does only seem to accept integer, maybe add an additional type check?

            $user = get_entity($guid);

It seems like $guid defined by register_user($username, $password, $data['name'], $data['email']) on line 28 can also be of type false or null; however, get_entity() does only seem to accept integer, maybe add an additional type check?

        } catch (Exception $e) {

The class ModPleio\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

            elgg_log("Could not register user " . $e->getMessage(), "ERROR");
        }

        return $user;
    }

    public function generateUniqueUsername($data) {
        $email = $data["email"];
        list($name, $email) = explode("@", $email);

The assignment to $email is unused. Consider omitting it like so list($first,,$third).

        $name = trim($name);

        $hidden = access_show_hidden_entities(true);

        if (get_user_by_username($name)) {
            $i = 1;

            while (get_user_by_username($name . $i)) {
                $i++;
            }
            
            $result = $name . $i;
        } else {
            $result = $name;
        }

        access_show_hidden_entities($hidden);

        return $result;
    }

    public function getUserByAttributes($data) {
        $user = false;

        if ($data["guid"]) {
            $user = get_entity($data["guid"]);
        } elseif ($data["username"]) {
            $user = get_user_by_username($data["username"]);
        } elseif ($data["email"]) {
            $users = get_user_by_email($data["email"]);
            $user = $users[0];
        }

        return $user;
    }
}