start.php ➔ solr_api_init() - Code Metrics - Inspection of "added api calls for solr" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — api-test ( c6440b )

unknown

created 2018-05-11 18:39 UTC

start.php ➔ solr_api_init() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	87
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	52
nc	1
nop	0
dl	0
loc	87
rs	8.6296
c	0
b	0
f	0

How to fix Long Method

<?php

elgg_register_event_handler('init','system','solr_api_init');


function solr_api_init() {



	elgg_register_event_handler('delete', 'object', 'intercept_object_deletion'); 
	//elgg_register_event_handler('create','object','cp_create_notification',900);
	// @TODO limit access to only the specified user agent string for more strict security
	// @TODO list all subtypes and types

	// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.entity_list&type=object&subtype=blog
	// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.user_list
	// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.group_list
 

	// @TODO will need authentication mechanism for this
	elgg_ws_expose_function(
		'delete.updated_index_list',
		'delete_updated_index_list',
		[
			'guids' => [
				'type' => 'array',
				'required' => false,
				'description' => 'deletes records based on collection of entity guids'
			]
		],
		'deletes record that already updated the solr index',
		'POST',
		false,
		false
	);


	// api expose function calls
	// parameters: method, function, array of parameters, description, call method/get or post, require api authentication, require user authentication
	elgg_ws_expose_function(
        'get.entity_list',
        'get_entity_list',
        [
            'type' => [
                    'type' => 'string',
                    'required' => true,
                    'description' => 'the type of entity in string format',
            ],
            'subtype' => [
                    'type' => 'string',
                    'required' => false,
                    'description' => 'the subtype of entity in string format, not required',
            ],

        ],
        'retrieves all entities filtered by type [and subtype]',
        'GET',
        false,
        false
	);


	elgg_ws_expose_function(
        'get.user_list',
        'get_user_list',
        null,
        'retrieves a user list',
        'GET',
        false,
        false
	);

	elgg_ws_expose_function(
        'get.group_list',
        'get_group_list',
        null,
        'retrieves a group list',
        'GET',
        false,
        false
	);

	elgg_ws_expose_function(
		'get.list_of_deleted_records',
		'get_list_of_deleted_records',
		null,
		'retrieves a list of deleted content',
		'GET',
		false,
		false
	);
}
 

function delete_updated_index_list($guids) {

	$ids = array();
	foreach ($guids as $guid) {

		error_log(".... guid array: " . $guid);

		if (is_numeric($guid)) {
			error_log("guid is an int");
			$ids[] = "id = {$guid}";
		}

	}
	error_log("the size is.. " . sizeof($ids));
	if (sizeof($ids) > 0) {
		$ids = implode(" OR ",$ids);
		$query = "DELETE FROM deleted_object_tracker WHERE {$ids}";
		error_log("query: " . $query);
		$result = delete_data($query);
	}

	return "ehhh";
}


function intercept_object_deletion($event, $type, $object) {
	$unixtime = time();
	error_log("deleting ... id: {$object->guid}  //  title: {$object->title} on " . time());


	$query = "INSERT INTO deleted_object_tracker (id, time_deleted) VALUES ({$object->guid}, {$unixtime})";
	
	try {
		$insert_record = insert_data($query);
	} catch (Exception $e) {
		error_log("error occurred: {$e}");
	}

	$query = "SELECT * FROM deleted_object_tracker";
	$deleted_records = get_data($query);

	foreach ($deleted_records as $deleted_record) {
		error_log("the id: " . $deleted_record->id);
	}


	return false;
}

function clear_deleted_object_tracker_table() {

}

// api calls with sample set of limit 15
function get_list_of_deleted_records() {

	$query = "SELECT * FROM deleted_object_tracker";
	$deleted_records = get_data($query);

	foreach ($deleted_records as $deleted_record) {
		error_log("the id: " . $deleted_record->id);
		//$datetime = new DateTime("@{$deleted_record->time_deleted}");
		//$datetime->setTimeZone(new DateTimeZone('America/New York'));
		$arr[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'guid' => $deleted_record->id,
			'time_deleted' => $deleted_record->time_deleted
		);
	}

	return $arr;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

function get_user_list() {

	$users = elgg_get_entities(array(
		'type' => 'user',
		'limit' => 15
	));

	foreach ($users as $user) {

		$name_array['en'] = $user->name;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$name_array['fr'] = $user->name;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

		$arr[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'guid' => $user->getGUID(),
			'name' => $name_array,
			'username' => $user->username,
			'email' => $user->email,
			'type' => $user->getType(),
			'date_created' => date("Y-m-d\TH:m:s\Z", $user->time_created),
			'date_modified' => date("Y-m-d\TH:m:s\Z", $user->time_created),
			'url' => $user->getURL()
		);
	}
	
    return $arr;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

function get_group_list() {

	$groups = elgg_get_entities(array(
		'type' => 'group',
		'limit' => 15
	));

	foreach ($groups as $group) {

		if (isJson($group->name)) {
			$name_array = json_decode($group->name, true);
			$name_array['en'] = str_replace('"', '\"', $name_array['en']);
			$name_array['fr'] = str_replace('"', '\"', $name_array['fr']);
		} else {
			$name_array['en'] = $group->name;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$name_array['fr'] = $group->name;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		if (isJson($group->description)) {
			$description_array = json_decode($group->description, true);
			$description_array['en'] = str_replace('"', '\"', $description_array['en']);
			$description_array['fr'] = str_replace('"', '\"', $description_array['fr']);
		} else {
			$description_array['en'] = $group->description;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$description_array['fr'] = $group->description;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		$arr[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'guid' => $group->getGUID(),
			'name' => $name_array,
			'description' => $description_array,
			'type' => $group->getType(),
			'access_id' => $group->access_id,
			'date_created' => date("Y-m-d\TH:m:s\Z", $group->time_created),
			'date_modified' => date("Y-m-d\TH:m:s\Z", $group->time_updated),
			'url' => $group->getURL()
		);
	}
	
    return $arr;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}


function get_entity_list($type, $subtype) {

	$entities = elgg_get_entities(array(
		'type' => $type,
		'subtype' => $subtype,
		'limit' => 15
	));

	foreach ($entities as $entity) {

		if (isJson($entity->title)) {
			$title_array = json_decode($entity->title, true);
			$title_array['en'] = str_replace('"', '\"', $title_array['en']);
			$title_array['fr'] = str_replace('"', '\"', $title_array['fr']);
		} else {
			$title_array['en'] = $entity->title;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$title_array['fr'] = $entity->title;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		if (isJson($entity->description)) {
			$description_array = json_decode($entity->description, true);
			$description_array['en'] = str_replace('"', '\"', $description_array['en']);
			$description_array['fr'] = str_replace('"', '\"', $description_array['fr']);
		} else {
			$description_array['en'] = $entity->description;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$description_array['fr'] = $entity->description;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		$arr[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'guid' => $entity->getGUID(), 
			'title' => $title_array,
			'description' => $description_array,
			'type' => $entity->getType(),
			'subtype' => $entity->getSubtype(),
			'access_id' => $entity->access_id,
			'date_created' => date("Y-m-d\TH:m:s\Z", $entity->time_created),
			'date_modified' => date("Y-m-d\TH:m:s\Z", $entity->time_updated),
			'url' => $entity->getURL()
		);
	}
	
    return $arr;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}



function isJson($string) {
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
	json_decode($string);
	return (json_last_error() == JSON_ERROR_NONE);
}



Push — api-test ( c6440b )

start.php ➔ solr_api_init() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			elgg_register_event_handler('init','system','solr_api_init');
4
5
6			function solr_api_init() {
7
8
9
10			elgg_register_event_handler('delete', 'object', 'intercept_object_deletion');
11			//elgg_register_event_handler('create','object','cp_create_notification',900);
12			// @TODO limit access to only the specified user agent string for more strict security
13			// @TODO list all subtypes and types
14
15			// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.entity_list&type=object&subtype=blog
16			// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.user_list
17			// http://192.168.245.130/gcconnex/services/api/rest/json/?method=get.group_list
18
19
20			// @TODO will need authentication mechanism for this
21			elgg_ws_expose_function(
22			'delete.updated_index_list',
23			'delete_updated_index_list',
24			[
25			'guids' => [
26			'type' => 'array',
27			'required' => false,
28			'description' => 'deletes records based on collection of entity guids'
29			]
30			],
31			'deletes record that already updated the solr index',
32			'POST',
33			false,
34			false
35			);
36
37
38			// api expose function calls
39			// parameters: method, function, array of parameters, description, call method/get or post, require api authentication, require user authentication
40			elgg_ws_expose_function(

gctools-outilsgc / gcconnex

Push — api-test ( c6440b )

start.php ➔ solr_api_init() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like