mod/phpmailer/start.php ➔ phpmailer_send()

Complexity

Conditions	25
Paths	1348

Size

Total Lines

141

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function phpmailer_send($to, $to_name, $subject, $body, array $bcc = NULL, $html = true, array $files = NULL, array $params = NULL, $image = NULL) {

	require_once elgg_get_plugins_path() . '/phpmailer/vendors/class.phpmailer.php';
	$phpmailer = new PHPMailer(true); //defaults to using php "mail()"; the true param means it will throw exceptions on errors, which we need to catch

The call to PHPMailer::__construct() has too many arguments starting with true.

	// CONFIGURE SERVER INFORMATION defaults
	$phpmailer->IsSMTP(); // telling the class to use SMTP
	$phpmailer->Host       = elgg_get_plugin_setting('phpmailer_host', 'phpmailer'); // SMTP server
	$phpmailer->Port       = elgg_get_plugin_setting('ep_phpmailer_port', 'phpmailer'); // SMTP server port
	$phpmailer->SMTPAuth   = elgg_get_plugin_setting('phpmailer_smtp_auth', 'phpmailer');
	$phpmailer->SMTPSecure = "";	// set below
	$phpmailer->Username = elgg_get_plugin_setting('phpmailer_username', 'phpmailer');
	$phpmailer->Password = elgg_get_plugin_setting('phpmailer_password', 'phpmailer');
	$phpmailer->SetFrom( elgg_get_plugin_setting('phpmailer_from_email', 'phpmailer'), elgg_get_plugin_setting('phpmailer_from_name', 'phpmailer') );

The method SetFrom() does not seem to exist on object<PHPMailer>.

	/*if (!$from) {
		throw new NotificationException(sprintf(elgg_echo('NotificationException:MissingParameter'), 'from'));
	}*/

	if (!$to && !$bcc) {
		throw new NotificationException(sprintf(elgg_echo('NotificationException:MissingParameter'), 'to'));
	}

	if (!$subject) {
		throw new NotificationException(sprintf(elgg_echo('NotificationException:MissingParameter'), 'subject'));
	}

	// set line ending if admin selected \n (if admin did not change setting, null is returned)
	if (elgg_get_plugin_setting('nonstd_mta', 'phpmailer'))
		$phpmailer->LE = "\n";
	else
		$phpmailer->LE = "\r\n";
	
	////////////////////////////////////
	// Format message
	$phpmailer->SMTPDebug = 0; // Set to 1 for debugging information

The property $SMTPDebug was declared of type boolean, but 0 is of type integer. Maybe add a type cast?

	$phpmailer->ClearAllRecipients();
	$phpmailer->ClearAttachments();

	// Set the from name and email
	//$phpmailer->From = $from;
	//$phpmailer->FromName = $from_name;

	if (!filter_var($to, FILTER_VALIDATE_EMAIL)) {
		return;
	}

	// Set destination address
	if (isset($to)) {
		$phpmailer->AddAddress($to, $to_name);
	}

	// set bccs if exists
	if ($bcc && is_array($bcc)) {
		foreach ($bcc as $address)
			$phpmailer->AddBCC($address);
	}

	$phpmailer->Subject = $subject;
	
	if ($image)
		$phpmailer->AddEmbeddedImage($image, 'wire_image');

	if (!$html) {
		$phpmailer->CharSet = 'utf-8';
		$phpmailer->IsHTML(false);
		if ($params && array_key_exists('altbody', $params)) {
			$phpmailer->AltBody = $params['altbody'];
		}

		$trans_tbl = get_html_translation_table(HTML_ENTITIES);
		$trans_tbl[chr(146)] = '’';
		foreach ($trans_tbl as $k => $v) {
			$ttr[$v] = utf8_encode($k);

$ttr was never initialized. Although not strictly required by PHP, it is generally a good practice to add $ttr = array(); before regardless.

		}
		$source = strtr($body, $ttr);

The variable $ttr does not seem to be defined for all execution paths leading up to this point.

		$body = strip_tags($source);

		$phpmailer->Body = $body;
	
	} else {
	
		//$phpmailer->IsHTML(true);
		$phpmailer->CharSet = 'utf-8';
		$phpmailer->MsgHTML($body);
	}


	if ($files && is_array($files)) {
		foreach ($files as $file) {
			if (isset($file['path']))
				$phpmailer->AddAttachment($file['path'], $file['name']);
		}
	}

	$is_smtp   = elgg_get_plugin_setting('phpmailer_smtp', 'phpmailer');
	$smtp_host = elgg_get_plugin_setting('phpmailer_host', 'phpmailer');
	$smtp_auth = elgg_get_plugin_setting('phpmailer_smtp_auth', 'phpmailer');

	$is_ssl    = elgg_get_plugin_setting('ep_phpmailer_ssl', 'phpmailer');
	$smtp_port  = elgg_get_plugin_setting('ep_phpmailer_port', 'phpmailer');

	try {

		if ($is_smtp && isset($smtp_host)) {

			if ($smtp_auth && $is_ssl) {

				$phpmailer->SMTPSecure = "tls";
				
			}
		} else {
			// use php's mail
			$phpmailer->IsMail();
		}

		$phpmailer->Port = $smtp_port;
	
		$return = $phpmailer->Send();

	} catch (phpmailerException $e) {

The class phpmailerException does not exist. Did you forget a USE statement, or did you not list all dependencies?

		
		$errMess = $e->getMessage();
		$errStack = $e->getTraceAsString();
		$errType = $e->getCode();
		phpmailer_logging($errMess, $errStack, 'PHPMailer', $errType);
	}



	if (!$return) {

The variable $return does not seem to be defined for all execution paths leading up to this point.

		
		$errMess = $phpmailer->ErrorInfo;
		$errStack = "";
		$errType = "custom";
		phpmailer_logging($errMess, $errStack, 'PHPMailer', $errType);
	}

	return $return;
}

}