| Conditions | 1 |
| Paths | 1 |
| Total Lines | 69 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function testMissionActionsMustBeRegistered() { |
||
| 28 | //global $CONFIG; |
||
| 29 | |||
| 30 | $this->assertTrue(array_key_exists('missions/post-mission-first-form', _elgg_services()->actions->getAllActions())); |
||
| 31 | $this->assertTrue(array_key_exists('missions/post-mission-second-form', _elgg_services()->actions->getAllActions())); |
||
| 32 | $this->assertTrue(array_key_exists('missions/post-mission-third-form', _elgg_services()->actions->getAllActions())); |
||
| 33 | $this->assertTrue(array_key_exists('missions/delete-mission', _elgg_services()->actions->getAllActions())); |
||
| 34 | $this->assertTrue(array_key_exists('missions/search-simple', _elgg_services()->actions->getAllActions())); |
||
| 35 | $this->assertTrue(array_key_exists('missions/advanced-search-form', _elgg_services()->actions->getAllActions())); |
||
| 36 | $this->assertTrue(array_key_exists('missions/application-form', _elgg_services()->actions->getAllActions())); |
||
| 37 | $this->assertTrue(array_key_exists('missions/accept-invite', _elgg_services()->actions->getAllActions())); |
||
| 38 | $this->assertTrue(array_key_exists('missions/decline-invite', _elgg_services()->actions->getAllActions())); |
||
| 39 | $this->assertTrue(array_key_exists('missions/invite-user', _elgg_services()->actions->getAllActions())); |
||
| 40 | $this->assertTrue(array_key_exists('missions/remove-applicant', _elgg_services()->actions->getAllActions())); |
||
| 41 | $this->assertTrue(array_key_exists('missions/change-mission-form', _elgg_services()->actions->getAllActions())); |
||
| 42 | //$this->assertTrue(array_key_exists('missions/remove-pending-invites', _elgg_services()->actions->getAllActions())); |
||
| 43 | $this->assertTrue(array_key_exists('missions/opt-from-main', _elgg_services()->actions->getAllActions())); |
||
| 44 | $this->assertTrue(array_key_exists('missions/cancel-mission', _elgg_services()->actions->getAllActions())); |
||
| 45 | $this->assertTrue(array_key_exists('missions/complete-mission', _elgg_services()->actions->getAllActions())); |
||
| 46 | $this->assertTrue(array_key_exists('missions/feedback-form', _elgg_services()->actions->getAllActions())); |
||
| 47 | $this->assertTrue(array_key_exists('missions/refine-my-missions-form', _elgg_services()->actions->getAllActions())); |
||
| 48 | $this->assertTrue(array_key_exists('missions/reopen-mission', _elgg_services()->actions->getAllActions())); |
||
| 49 | |||
| 50 | $this->assertTrue(array_key_exists('missions/admin-form', _elgg_services()->actions->getAllActions())); |
||
| 51 | $this->assertTrue(array_key_exists('missions/change-entities-per-page', _elgg_services()->actions->getAllActions())); |
||
| 52 | $this->assertTrue(array_key_exists('missions/duplicate-mission', _elgg_services()->actions->getAllActions())); |
||
| 53 | $this->assertTrue(array_key_exists('missions/endorse-user', _elgg_services()->actions->getAllActions())); |
||
| 54 | $this->assertTrue(array_key_exists('missions/graph-data-form', _elgg_services()->actions->getAllActions())); |
||
| 55 | $this->assertTrue(array_key_exists('missions/graph-interval-form', _elgg_services()->actions->getAllActions())); |
||
| 56 | $this->assertTrue(array_key_exists('missions/mission-invite-selector', _elgg_services()->actions->getAllActions())); |
||
| 57 | $this->assertTrue(array_key_exists('missions/mission-offer', _elgg_services()->actions->getAllActions())); |
||
| 58 | $this->assertTrue(array_key_exists('missions/post-mission-skill-match', _elgg_services()->actions->getAllActions())); |
||
| 59 | $this->assertTrue(array_key_exists('missions/pre-create-opportunity', _elgg_services()->actions->getAllActions())); |
||
| 60 | $this->assertTrue(array_key_exists('missions/remove-department-from-graph', _elgg_services()->actions->getAllActions())); |
||
| 61 | $this->assertTrue(array_key_exists('missions/wire-post', _elgg_services()->actions->getAllActions())); |
||
| 62 | |||
| 63 | $this->assertTrue(elgg_action_exists('missions/post-mission-first-form')); |
||
| 64 | $this->assertTrue(elgg_action_exists('missions/post-mission-second-form')); |
||
| 65 | $this->assertTrue(elgg_action_exists('missions/post-mission-third-form')); |
||
| 66 | $this->assertTrue(elgg_action_exists('missions/delete-mission')); |
||
| 67 | $this->assertTrue(elgg_action_exists('missions/search-simple')); |
||
| 68 | $this->assertTrue(elgg_action_exists('missions/advanced-search-form')); |
||
| 69 | $this->assertTrue(elgg_action_exists('missions/application-form')); |
||
| 70 | $this->assertTrue(elgg_action_exists('missions/accept-invite')); |
||
| 71 | $this->assertTrue(elgg_action_exists('missions/decline-invite')); |
||
| 72 | $this->assertTrue(elgg_action_exists('missions/invite-user')); |
||
| 73 | $this->assertTrue(elgg_action_exists('missions/remove-applicant')); |
||
| 74 | $this->assertTrue(elgg_action_exists('missions/change-mission-form')); |
||
| 75 | //$this->assertTrue(elgg_action_exists('missions/remove-pending-invites')); |
||
| 76 | $this->assertTrue(elgg_action_exists('missions/opt-from-main')); |
||
| 77 | $this->assertTrue(elgg_action_exists('missions/cancel-mission')); |
||
| 78 | $this->assertTrue(elgg_action_exists('missions/complete-mission')); |
||
| 79 | $this->assertTrue(elgg_action_exists('missions/feedback-form')); |
||
| 80 | $this->assertTrue(elgg_action_exists('missions/refine-my-missions-form')); |
||
| 81 | $this->assertTrue(elgg_action_exists('missions/reopen-mission')); |
||
| 82 | |||
| 83 | $this->assertTrue(elgg_action_exists('missions/admin-form')); |
||
| 84 | $this->assertTrue(elgg_action_exists('missions/change-entities-per-page')); |
||
| 85 | $this->assertTrue(elgg_action_exists('missions/duplicate-mission')); |
||
| 86 | $this->assertTrue(elgg_action_exists('missions/endorse-user')); |
||
| 87 | $this->assertTrue(elgg_action_exists('missions/graph-data-form')); |
||
| 88 | $this->assertTrue(elgg_action_exists('missions/graph-interval-form')); |
||
| 89 | $this->assertTrue(elgg_action_exists('missions/mission-invite-selector')); |
||
| 90 | $this->assertTrue(elgg_action_exists('missions/mission-offer')); |
||
| 91 | $this->assertTrue(elgg_action_exists('missions/post-mission-skill-match')); |
||
| 92 | $this->assertTrue(elgg_action_exists('missions/pre-create-opportunity')); |
||
| 93 | $this->assertTrue(elgg_action_exists('missions/remove-department-from-graph')); |
||
| 94 | $this->assertTrue(elgg_action_exists('missions/wire-post')); |
||
| 95 | } |
||
| 96 | |||
| 184 | } |