ElggBlog::canComment() - Code Metrics - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

ElggBlog::canComment() A
last analyzed 2021-05-27 17:40 UTC

↳ Parent: ElggBlog

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
nc	3
nop	1
dl	12
loc	12
ccs	0
cts	10
cp	0
crap	12
rs	9.8666
c	0
b	0
f	0

<?php
/**
 * Extended class to override the time_created
 * 
 * @property string $status      The published status of the blog post (published, draft)
 * @property string $comments_on Whether commenting is allowed (Off, On)
 * @property string $excerpt     An excerpt of the blog post used when displaying the post
 */
class ElggBlog extends ElggObject {

	/**
	 * Set subtype to blog.
	 */
	protected function initializeAttributes() {
		parent::initializeAttributes();

		$this->attributes['subtype'] = "blog";
	}

	/**
	 * Can a user comment on this blog?
	 *
	 * @see ElggObject::canComment()
	 *
	 * @param int $user_guid User guid (default is logged in user)
	 * @return bool
	 * @since 1.8.0
	 */
	public function canComment($user_guid = 0) {

		$result = parent::canComment($user_guid);
		if ($result == false) {

			return $result;
		}

		if ($this->comments_on == 'Off') {
			return false;
		}
		
		return true;
	}

	/**
	 * Get the excerpt for this blog post
	 * 
	 * @param int $length Length of the excerpt (optional)
	 * @return string
	 * @since 1.9.0
	 */
	public function getExcerpt($length = 250) {
		if ($this->excerpt) {
			return $this->excerpt;
		} else {
			return elgg_get_excerpt($this->description, $length);
		}
	}
}

1		<?php
2		/**
3		* Extended class to override the time_created
4		*
5		* @property string $status The published status of the blog post (published, draft)
6		* @property string $comments_on Whether commenting is allowed (Off, On)
7		* @property string $excerpt An excerpt of the blog post used when displaying the post
8		*/
9		class ElggBlog extends ElggObject {
10
11		/**
12		* Set subtype to blog.
13		*/
14		protected function initializeAttributes() {
15		parent::initializeAttributes();
16
17		$this->attributes['subtype'] = "blog";
18		}
19
20		/**
21		* Can a user comment on this blog?
22		*
23		* @see ElggObject::canComment()
24		*
25		* @param int $user_guid User guid (default is logged in user)
26		* @return bool
27		* @since 1.8.0
28		*/
29	View Code Duplication	public function canComment($user_guid = 0) {
		0 ignored issues – show Duplication introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		$result = parent::canComment($user_guid);
31		if ($result == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
32		return $result;
33		}
34
35		if ($this->comments_on == 'Off') {
36		return false;
37		}
38
39		return true;
40		}
41
42		/**
43		* Get the excerpt for this blog post
44		*
45		* @param int $length Length of the excerpt (optional)
46		* @return string
47		* @since 1.9.0
48		*/
49		public function getExcerpt($length = 250) {
50		if ($this->excerpt) {
51		return $this->excerpt;
52		} else {
53		return elgg_get_excerpt($this->description, $length);
54		}
55		}
56		}

gctools-outilsgc / gcconnex

ElggBlog::canComment() A last analyzed 2021-05-27 17:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ElggBlog::canComment() A
last analyzed 2021-05-27 17:40 UTC