ElggPluginManifestParser17

Complexity

Total Complexity

10

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	parse()	0	36	8
A	getAttribute()	0	7	2

<?php
/**
 * Plugin manifest.xml parser for Elgg 1.7 and lower.
 *
 * @package    Elgg.Core
 * @subpackage Plugins
 * @since      1.8
 */
class ElggPluginManifestParser17 extends \ElggPluginManifestParser {
	/**
	 * The valid top level attributes and defaults for a 1.7 manifest
	 */
	protected $validAttributes = array(
		'author', 'version', 'description', 'website',
		'copyright', 'license', 'licence', 'elgg_version',

		// were never really used and not enforced in code.
		'requires', 'recommends', 'conflicts',

		// not a 1.7 field, but we need it
		'name',
	);

	/**
	 * Parse a manifest object from 1.7 or earlier.
	 *
	 * @return void
	 */
	public function parse() {
		if (!isset($this->manifestObject->children)) {
			return false;
		}

		$elements = array();

		foreach ($this->manifestObject->children as $element) {
			$key = $element->attributes['key'];
			$value = $element->attributes['value'];

			// create arrays if multiple fields are set
			if (array_key_exists($key, $elements)) {
				if (!is_array($elements[$key])) {
					$orig = $elements[$key];
					$elements[$key] = array($orig);
				}

				$elements[$key][] = $value;
			} else {
				$elements[$key] = $value;
			}
		}

		if ($elements && !array_key_exists('name', $elements)) {

The expression $elements of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			$elements['name'] = $this->caller->getName();
		}

		$this->manifest = $elements;

		if (!$this->manifest) {

The expression $this->manifest of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			return false;
		}

		return true;
	}

	/**
	 * Return an attribute in the manifest.
	 *
	 * Overrides \ElggPluginManifestParser::getAttribute() because before 1.8
	 * there were no rules...weeeeeeeee!
	 *
	 * @param string $name Attribute name
	 * @return mixed
	 */
	public function getAttribute($name) {
		if (isset($this->manifest[$name])) {
			return $this->manifest[$name];
		}

		return false;
	}
}