ElggAnnotation

Complexity

Total Complexity

20

Size/Duplication

Total Lines	154
Duplicated Lines	27.92 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeAttributes()	0	5	1
A	__construct()	20	20	4
A	save()	14	14	3
A	delete()	0	8	2
A	disable()	0	3	1
A	enable()	0	3	1
B	canEdit()	9	30	7
A	getObjectFromID()	0	3	1

<?php
/**
 * Elgg Annotations
 *
 * Annotations allow you to attach bits of information to entities. They are
 * essentially the same as metadata, but with additional helper functions for
 * performing calculations.
 *
 * @note Internal: Annotations are stored in the annotations table.
 *
 * @package    Elgg.Core
 * @subpackage DataModel.Annotations
 */
class ElggAnnotation extends \ElggExtender {

	/**
	 * (non-PHPdoc)
	 *
	 * @see \ElggData::initializeAttributes()
	 *
	 * @return void
	 */
	protected function initializeAttributes() {
		parent::initializeAttributes();

		$this->attributes['type'] = 'annotation';
	}

	/**
	 * Construct a new annotation object
	 *
	 * Plugin developers will probably never use the constructor.
	 * See \ElggEntity for its API for adding annotations.
	 *
	 * @param \stdClass $row Database row as \stdClass object
	 */
	public function __construct($row = null) {

This method seems to be duplicated in your project.

		$this->initializeAttributes();

		if (!empty($row)) {
			// Create from db row
			if ($row instanceof \stdClass) {
				$annotation = $row;

				$objarray = (array) $annotation;
				foreach ($objarray as $key => $value) {
					$this->attributes[$key] = $value;
				}
			} else {
				// get an \ElggAnnotation object and copy its attributes
				elgg_deprecated_notice('Passing an ID to constructor is deprecated. Use elgg_get_annotation_from_id()', 1.9);
				$annotation = elgg_get_annotation_from_id($row);
				$this->attributes = $annotation->attributes;
			}
		}
	}

	/**
	 * Save this instance
	 *
	 * @return int an object id
	 *
	 * @throws IOException
	 */
	public function save() {

This method seems to be duplicated in your project.

		if ($this->id > 0) {
			return update_annotation($this->id, $this->name, $this->value, $this->value_type,

The expression update_annotation($this->id, $this->name, $this->value, $this->value_type, $this->owner_guid, $this->access_id); of type integer|boolean adds the type integer to the return on line 67 which is incompatible with the return type declared by the abstract method ElggData::save of type boolean.

				$this->owner_guid, $this->access_id);
		} else {
			$this->id = create_annotation($this->entity_guid, $this->name, $this->value,
				$this->value_type, $this->owner_guid, $this->access_id);

			if (!$this->id) {

The expression $this->id of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

				throw new \IOException("Unable to save new " . get_class());
			}
			return $this->id;

The return type of return $this->id; (integer) is incompatible with the return type declared by the abstract method ElggData::save of type boolean.

		}
	}

	/**
	 * Delete the annotation.
	 *
	 * @return bool
	 */
	public function delete() {
		$result = _elgg_delete_metastring_based_object_by_id($this->id, 'annotation');
		if ($result) {
			elgg_delete_river(array('annotation_id' => $this->id));
		}

		return $result;
	}

	/**
	 * Disable the annotation.
	 *
	 * @return bool
	 * @since 1.8
	 */
	public function disable() {
		return _elgg_set_metastring_based_object_enabled_by_id($this->id, 'no', 'annotations');
	}

	/**
	 * Enable the annotation.
	 *
	 * @return bool
	 * @since 1.8
	 */
	public function enable() {
		return _elgg_set_metastring_based_object_enabled_by_id($this->id, 'yes', 'annotations');
	}

	/**
	 * Determines whether or not the user can edit this annotation
	 *
	 * @param int $user_guid The GUID of the user (defaults to currently logged in user)
	 *
	 * @return bool
	 * @see elgg_set_ignore_access()
	 */
	public function canEdit($user_guid = 0) {

		if ($user_guid) {
			$user = get_user($user_guid);
			if (!$user) {
				return false;
			}
		} else {
			$user = _elgg_services()->session->getLoggedInUser();
			$user_guid = _elgg_services()->session->getLoggedInUserGuid();
		}

		$result = false;
		if ($user) {
			// If the owner of annotation is the specified user, they can edit.
			if ($this->getOwnerGUID() == $user_guid) {
				$result = true;
			}

			// If the user can edit the entity this is attached to, they can edit.
			$entity = $this->getEntity();
			if ($result == false && $entity->canEdit($user->getGUID())) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

				$result = true;
			}
		}

		// Trigger plugin hook - note that $user may be null
		$params = array('entity' => $entity, 'user' => $user, 'annotation' => $this);

The variable $entity does not seem to be defined for all execution paths leading up to this point.

		return _elgg_services()->hooks->trigger('permissions_check', 'annotation', $params, $result);
	}

	// SYSTEM LOG INTERFACE

	/**
	 * For a given ID, return the object associated with it.
	 * This is used by the river functionality primarily.
	 * This is useful for checking access permissions etc on objects.
	 *
	 * @param int $id An annotation ID.
	 *
	 * @return \ElggAnnotation
	 */
	public function getObjectFromID($id) {
		return elgg_get_annotation_from_id($id);

The return type of return elgg_get_annotation_from_id($id); (ElggExtender) is incompatible with the return type declared by the interface Loggable::getObjectFromID of type ElggEntity.

	}
}