HttpMessageServiceProvider::register() - Code Metrics - gcamrit/ramro-framework - Measure and Improve Code Quality continuously with Scrutinizer

HttpMessageServiceProvider::register() A
last analyzed 2017-04-14 18:19 UTC

↳ Parent: HttpMessageServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

namespace Ramro\Providers;

use League\Container\ServiceProvider\AbstractServiceProvider;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\EmitterInterface;
use Zend\Diactoros\Response\SapiEmitter;
use Zend\Diactoros\ServerRequestFactory;

class HttpMessageServiceProvider extends AbstractServiceProvider
{
    protected $provides = [
        ResponseInterface::class,
        ServerRequestInterface::class,
        EmitterInterface::class,
    ];

    public function register()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->container->share(ResponseInterface::class, function () {
            return new \Zend\Diactoros\Response;
        });

        $this->container->share(ServerRequestInterface::class, function () {
            return ServerRequestFactory::fromGlobals(
                $_SERVER, $_GET, $_POST, $_COOKIE, $_FILES
            );
        });

        $this->container->share(EmitterInterface::class, function () {
            return new SapiEmitter;
        });
    }
}


1			<?php
2
3			namespace Ramro\Providers;
4
5			use League\Container\ServiceProvider\AbstractServiceProvider;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr\Http\Message\ServerRequestInterface;
8			use Zend\Diactoros\Response\EmitterInterface;
9			use Zend\Diactoros\Response\SapiEmitter;
10			use Zend\Diactoros\ServerRequestFactory;
11
12			class HttpMessageServiceProvider extends AbstractServiceProvider
13			{
14			protected $provides = [
15			ResponseInterface::class,
16			ServerRequestInterface::class,
17			EmitterInterface::class,
18			];
19
20			public function register()
			0 ignored issues – show Coding Style introduced 2017-04-14 17:51 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-04-14 17:51 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-04-14 17:51 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-04-14 17:51 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-04-14 17:51 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21			{
22			$this->container->share(ResponseInterface::class, function () {
23			return new \Zend\Diactoros\Response;
24			});
25
26			$this->container->share(ServerRequestInterface::class, function () {
27			return ServerRequestFactory::fromGlobals(
28			$_SERVER, $_GET, $_POST, $_COOKIE, $_FILES
29			);
30			});
31
32			$this->container->share(EmitterInterface::class, function () {
33			return new SapiEmitter;
34			});
35			}
36			}
37

gcamrit / ramro-framework

HttpMessageServiceProvider::register() A last analyzed 2017-04-14 18:19 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

HttpMessageServiceProvider::register() A
last analyzed 2017-04-14 18:19 UTC