Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php declare(strict_types = 1); |
||
| 10 | View Code Duplication | class Listing extends Container |
|
|
|
|||
| 11 | { |
||
| 12 | /** |
||
| 13 | * Stringify if value is a scalar, throw an expection otherwise. |
||
| 14 | */ |
||
| 15 | protected static function checkMember($value) |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Check whether an equal member alredy exists in this Listing. |
||
| 26 | */ |
||
| 27 | public function contains($member): bool |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Join List members with a string |
||
| 34 | * @param $glue string |
||
| 35 | */ |
||
| 36 | public function implode(string $glue): string |
||
| 40 | } |
||
| 41 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.