Issues (10)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Server.php (10 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php declare(strict_types = 1);
2
3
namespace JSKOS;
4
5
use Psr\Http\Message\RequestInterface;
6
use Psr\Http\Message\ResponseInterface;
7
use Http\Message\ResponseFactory;
8
use Http\Discovery\MessageFactoryDiscovery;
9
use Psr\Log\LoggerInterface;
10
use Psr\Log\NullLogger;
11
12
/**
13
 * A JSKOS Server.
14
 */
15
class Server implements \Psr\Log\LoggerAwareInterface
16
{
17
    protected $service;
18
    protected $responseFactory;
19
    protected $logger;
20
21
    public function __construct(
22
        Service $service, 
23
        ResponseFactory $responseFactory=null,
24
        LoggerInterface $logger=null 
25
    )
26
    {
27
        $this->service = $service;
28
        $this->responseFactory = $responseFactory ?: MessageFactoryDiscovery::find();
29
        $this->logger = $logger ?: new NullLogger();
30
    }
31
32
    public function setLogger(LoggerInterface $logger)
33
    {
34
        $this->logger = $logger;
35
    }
36
37
    public function queryService(array $query, string $path=''): ResponseInterface 
38
    {
39
        if (preg_match('/^[$A-Z_][0-9A-Z_$.]*$/i', $query['callback'] ?? '')) {
40
            $callback = $query['callback'];
41
            unset($query['callback']);
42
        }
43
44
        # TODO: detect conflicting parameters?
45
        # if (isset($params['uri']) and isset($params['search'])) {
0 ignored issues
show
Unused Code Comprehensibility introduced by
80% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
46
        #   $error = new Error(422, 'request_error', 'Conflicting request parameters uri & search');
0 ignored issues
show
Unused Code Comprehensibility introduced by
56% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
47
        # }
48
49
        try {
50
            $result = $this->service->query($query, $path);
51
            // TODO
52
        } catch(Error $error) {
53
            $result = $error;
54
        }
55
56
        # TODO: catch other kinds of errors:
57
        # } catch (\Exception $e) {
0 ignored issues
show
Unused Code Comprehensibility introduced by
50% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
58
        # $this->logger->error('Service Exception', ['exception' => $e]);
0 ignored issues
show
Unused Code Comprehensibility introduced by
69% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
59
        # $error = new Error(500, 'Internal server error');
0 ignored issues
show
Unused Code Comprehensibility introduced by
54% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
60
61
        return $this->buildResponse($result, 'GET', $callback ?? null);
62
    }
63
64
    public function query(RequestInterface $request): ResponseInterface
65
    {    
66
        $method = $request->getMethod();
67
68
        if ($method == 'OPTIONS') {            
69
            return $this->optionsResponse();
70
        } elseif ($method != 'GET' && $method != 'HEAD') {
71
            return $this->buildResponse(new Error(405, 'Method not allowed'));
72
        }
73
74
        $uri = $request->getUri();
75
        $path = $uri->getPath();        
76
        $query = [];
77
        parse_str($uri->getQuery(), $query);
78
79
        # TODO: get language parameter from headers
80
81
        return $this->queryService($query, $path);
0 ignored issues
show
It seems like $query can also be of type null; however, JSKOS\Server::queryService() does only seem to accept array, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
82
    }
83
84
    protected function buildResponse($result, $method='GET', $callback=null): ResponseInterface
85
    {
86
        $body = $result->json();
87
        $context = Resource::DEFAULT_CONTEXT;
88
89
        $headers = [
90
            'Access-Control-Allow-Origin' => '*',
91
            'Content-Type' => 'application/json; charset=UTF-8',
92
            'Content-Length' => strlen($body),
93
            'Link' => "<$context>; rel=\"http://www.w3.org/ns/json-ld#context\"; type=\"application/ld+json\""
94
        ];
95
96
        if ($method == 'HEAD') {
97
            $body = '';
98
        }
99
100
        if ($callback) {
101
            $body = "/**/$callback($body);";
102
            $headers['Content-Type'] = 'application/javascript; charset=UTF-8';
103
        }
104
105
        if ($result instanceof Result) {
106
            $headers['X-Total-Count'] = $result->getTotalCount();
107
            $code = '200';
108
        } else {
109
            $code = $result->code;
110
        }
111
 
112
        return $this->responseFactory->createResponse($code, null, $headers, $body);
113
    }
114
115
    public function optionsResponse(): ResponseInterface
116
    {
117
        $headers = [
118
            'Access-Control-Allow-Methods' => 'GET, HEAD, OPTIONS',
119
        ];
120
121
        # TODO:
122
        # if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_METHOD']) &&
0 ignored issues
show
Unused Code Comprehensibility introduced by
77% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
123
        #    $_SERVER['HTTP_ACCESS_CONTROL_REQUEST_METHOD'] == 'GET') {
0 ignored issues
show
Unused Code Comprehensibility introduced by
59% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
124
        #    $response->headers['Access-Control-Allow-Origin'] = '*';
0 ignored issues
show
Unused Code Comprehensibility introduced by
59% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
125
        #    $response->headers['Acess-Control-Expose-Headers'] = 'Link, X-Total-Count';
0 ignored issues
show
Unused Code Comprehensibility introduced by
59% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
126
127
        return $this->responseFactory->createResponse(200, null, $headers, '');
128
    }
129
130
    /**
131
     * TODO: Extract requested languages(s) from request.
132
    public function extractRequestLanguage($params)
133
    {
134
        $language = null;
135
136
        # get query modifier: language
137
        if (isset($params['language'])) {
138
            $language = $params['language'];
139
            unset($params['language']);
140
            # TODO: parse language
141
        } elseif (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
142
            # parse accept-language-header
143
            preg_match_all(
144
                '/([a-z]+(?:-[a-z]+)?)\s*(?:;\s*q\s*=\s*(1|0?\.[0-9]+))?/i',
145
                $_SERVER['HTTP_ACCEPT_LANGUAGE'],
146
                $match);
147
            if (count($match[1])) {
148
                foreach ($match[1] as $i => $l) {
149
                    if (isset($match[2][$i]) && $match[2][$i] != '') {
150
                        $langs[strtolower($l)] = (float) $match[2][$i];
151
                    } else {
152
                        $langs[strtolower($l)] = 1;
153
                    }
154
                }
155
                arsort($langs, SORT_NUMERIC);
156
                reset($langs);
157
                $language = key($langs); # most wanted language
158
            }
159
        }
160
        
161
        return $language;
162
    }
163
*/
164
165
	/**
166
	 * Utility function to emit a Response without additional framework.
167
	 */
168
    public static function sendResponse(ResponseInterface $response) 
169
    {
170
		$code = $response->getStatusCode();
171
		$reason = $response->getReasonPhrase();
172
		header(
173
			sprintf('HTTP/%s %s %s', $response->getProtocolVersion(), $code, $reason),
174
			true, $code 
175
		);
176
177
		foreach ($response->getHeaders() as $header => $values) {
178
			foreach ($values as $value) {
179
				header("$header: $value", false);
180
			}
181
		}
182
183
		echo $response->getBody();
184
	}
185
}
186