CreateIndexCommand::configure() - Code Metrics - Inspection of "feat: command to create index" - gbprod/elasticsearch-extra-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a36c27...010ee5 )

by GBProd

created 2016-03-24 08:33 UTC

CreateIndexCommand::configure() A

↳ Parent: CreateIndexCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
ccs	12
cts	12
cp	1
rs	9.4285
cc	1
eloc	12
nc	1
nop	0
crap	1

<?php

namespace GBProd\ElasticsearchExtraBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Command to create index
 * 
 * @author gbprod <[email protected]>
 */
class CreateIndexCommand extends ContainerAwareCommand
{
    protected function configure()
    {
        $this
            ->setName('elasticsearch:create_index')
            ->setDescription('Create index from configuration')
            ->addArgument(
                'client_id',
                InputArgument::REQUIRED,
                'Which client ?'
            )
            ->addArgument(
                'index_id',
                InputArgument::REQUIRED,
                'Which index ?'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $clientId = $input->getArgument('client_id');
        $indexId  = $input->getArgument('index_id');
        
        $output->writeln(sprintf(
            'Creating index "%s" for client "%s"...',
            $indexId,
            $clientId
        ));
        
        $handler = $this
            ->getContainer()
            ->get('gbprod.elasticsearch_extra.create_index_handler')
        ;
        
        $handler->handle($clientId, $indexId);
        
        $output->writeln("Done");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
}

1		<?php
2
3		namespace GBProd\ElasticsearchExtraBundle\Command;
4
5		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6		use Symfony\Component\Console\Input\InputArgument;
7		use Symfony\Component\Console\Input\InputInterface;
8		use Symfony\Component\Console\Input\InputOption;
9		use Symfony\Component\Console\Output\OutputInterface;
10
11		/**
12		* Command to create index
13		*
14		* @author gbprod <[email protected]>
15		*/
16		class CreateIndexCommand extends ContainerAwareCommand
17		{
18		protected function configure()
19		{
20	1	$this
21	1	->setName('elasticsearch:create_index')
22	1	->setDescription('Create index from configuration')
23	1	->addArgument(
24	1	'client_id',
25	1	InputArgument::REQUIRED,
26		'Which client ?'
27	1	)
28	1	->addArgument(
29	1	'index_id',
30	1	InputArgument::REQUIRED,
31		'Which index ?'
32	1	)
33		;
34	1	}
35
36		protected function execute(InputInterface $input, OutputInterface $output)
37	1	{
38	1	$clientId = $input->getArgument('client_id');
39	1	$indexId = $input->getArgument('index_id');
40
41	1	$output->writeln(sprintf(
42	1	'Creating index "%s" for client "%s"...',
43	1	$indexId,
44		$clientId
45	1	));
46
47	1	$handler = $this
48	1	->getContainer()
49	1	->get('gbprod.elasticsearch_extra.create_index_handler')
50	1	;
51
52	1	$handler->handle($clientId, $indexId);
53
54	1	$output->writeln("Done");
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-24 08:36 UTC by Report Bug Copy Issue Report The string literal `Done` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
55		}
56		}

gbprod / elasticsearch-extra-bundle

Push — master ( a36c27...010ee5 )

CreateIndexCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like