GBProd\ElasticsearchExtraBundle\Repository\ClientRepository

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	8	2

<?php

namespace GBProd\ElasticsearchExtraBundle\Repository;

use Elasticsearch\Client;

/**
 * Repository for clients
 * 
 * @author gbprod <contact@gb-prod.fr>
 */
class ClientRepository
{
    /**
     * @var array<Client>
     */
    private $clients;
    
    /**
     * @param array $clients
     */
    public function __construct(array $clients = array())
    {
        $this->clients = $clients; 
    }
    
    /**
     * Get client from his id
     * 
     * @param string $id
     * 
     * @return Elasticsearch\Client

Should the return type not be null|Client?

     */
    public function get($id)
    {
        if (!isset($this->clients[$id])) {
            return null;
        }
        
        return $this->clients[$id];
    }
}