GBProd\ElasticsearchExtraBundle\Handler\PutIndexSettingsHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

87.5%

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	18	3
A	extractSettings()	0	8	2

<?php

namespace GBProd\ElasticsearchExtraBundle\Handler;

use Elasticsearch\Client;
use GBProd\ElasticsearchExtraBundle\Repository\ClientRepository;
use GBProd\ElasticsearchExtraBundle\Repository\IndexConfigurationRepository;

/**
 * Handler to put index settings command
 *
 * @author gbprod <contact@gb-prod.fr>
 */
class PutIndexSettingsHandler
{
    /**
     * @var IndexConfigurationRepository
     */
    private $configurationRepository;

    /**
     * @param IndexConfigurationRepository $configurationRepository
     */
    public function __construct(IndexConfigurationRepository $configurationRepository)
    {
        $this->configurationRepository = $configurationRepository;
    }

    /**
     * Handle index creation command
     *
     * @param Client $client
     * @param string $index
     */
    public function handle($client, $index)
    {
        $config = $this->configurationRepository->get($client, $index);

$client is of type object<Elasticsearch\Client>, but the function expects a string.

The call to IndexConfigurationRepository::get() has too many arguments starting with $index.

        if (null === $client || null === $config) {
            throw new \InvalidArgumentException();
        }

        $client
            ->indices()
            ->putSettings([
                'index' => $index,
                'body'  => [
                    'settings' => $this->extractSettings($config),
                ],
            ])
        ;
    }

    private function extractSettings($config)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (isset($config['settings'])) {
            return $config['settings'];
        }

        return [];
    }
}