ElasticsearchDataProviderBundle\Command\ProvidingProgressBarTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	114
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	10	1
A	testOnStartedHandlingDisplayNumberOfEntries()	0	15	1
A	testOnStartedProvidingDisplayProviderName()	0	18	1
A	testOnStartedProvidingCreateProgressBar()	0	21	1
A	testOnIndexedDocumentAdvanceProgress()	18	18	1
A	testOnFinishedProvidingFinishProgress()	20	20	1

<?php

namespace ElasticsearchDataProviderBundle\Command;

use GBProd\ElasticsearchDataProviderBundle\Command\ProvidingProgressBar;
use GBProd\ElasticsearchDataProviderBundle\DataProvider\DataProviderInterface;
use GBProd\ElasticsearchDataProviderBundle\DataProvider\RegistryEntry;
use GBProd\ElasticsearchDataProviderBundle\Event\HasFinishedProviding;
use GBProd\ElasticsearchDataProviderBundle\Event\HasIndexedDocument;
use GBProd\ElasticsearchDataProviderBundle\Event\HasStartedHandling;
use GBProd\ElasticsearchDataProviderBundle\Event\HasStartedProviding;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

/**
 * Tests for ProvidingProgressBar
 *
 * @author gbprod <contact@gb-prod.fr>
 */
class ProvidingProgressBarTest extends \PHPUnit_Framework_TestCase
{
    private $testedInstance;
    private $dispatcher;
    private $output;

Consider using a different property name as you override a private property of the parent class.

    public function setUp()
    {
        $this->dispatcher = $this->getMock(EventDispatcherInterface::class);
        $this->output     = $this->getMock(OutputInterface::class);

        $this->testedInstance = new ProvidingProgressBar(
            $this->dispatcher,
            $this->output
        );
    }

    public function testOnStartedHandlingDisplayNumberOfEntries()
    {
        $event = new HasStartedHandling([1, 2, 3]);

array(1, 2, 3) is of type array<integer,integer,{"0":"integer","1":"integer","2":"integer"}>, but the function expects a array<integer,object<GBProd\ElasticsearchDataProviderBundle\Event\RegistryEntry>>.

        $this
            ->output
            ->expects($this->once())
            ->method('writeln')
            ->with(
                $this->stringContains('<comment>3</comment>')
            )
        ;

        $this->testedInstance->onStartedHandling($event);
    }

    public function testOnStartedProvidingDisplayProviderName()
    {
        $provider = $this->getMock(DataProviderInterface::class);
        $entry = new RegistryEntry($provider, 'my_index', 'my_type');

        $event = new HasStartedProviding($entry);

        $this
            ->output
            ->expects($this->once())
            ->method('writeln')
            ->with($this->stringContains(get_class($provider)))
        ;

        $this->testedInstance->onStartedProviding($event);

        $this->assertEmpty($this->testedInstance->progressBar);
    }

    public function testOnStartedProvidingCreateProgressBar()
    {
        $provider = $this->getMock(DataProviderInterface::class);
        $provider
            ->expects($this->any())
            ->method('count')
            ->willReturn(42)
        ;

        $entry = new RegistryEntry($provider, 'my_index', 'my_type');
        $event = new HasStartedProviding($entry);

        $this->testedInstance->onStartedProviding($event);

        $this->assertNotEmpty($this->testedInstance->progressBar);
        $this->assertInstanceOf(
            ProgressBar::class,
            $this->testedInstance->progressBar
        );
        $this->assertEquals(42, $this->testedInstance->progressBar->getMaxSteps());
    }

    public function testOnIndexedDocumentAdvanceProgress()

This method seems to be duplicated in your project.

    {
        $provider = $this->getMock(DataProviderInterface::class);
        $entry = new RegistryEntry($provider, 'my_index', 'my_type');
        $event = new HasIndexedDocument($entry);

$entry is of type object<GBProd\ElasticsearchDataProviderBundle\DataProvider\RegistryEntry>, but the function expects a string.

        $this->testedInstance->progressBar = $this
            ->getMock(ProgressBar::class, [], [$this->output])
        ;

        $this->testedInstance
            ->progressBar
            ->expects($this->once())
            ->method('advance')
        ;

        $this->testedInstance->onIndexedDocument($event);
    }

    public function testOnFinishedProvidingFinishProgress()

This method seems to be duplicated in your project.

    {
        $provider = $this->getMock(DataProviderInterface::class);
        $entry = new RegistryEntry($provider, 'my_index', 'my_type');
        $event = new HasFinishedProviding($entry);

        $this->testedInstance->progressBar = $this
            ->getMock(ProgressBar::class, [], [$this->output])
        ;

        $this->testedInstance
            ->progressBar
            ->expects($this->once())
            ->method('finish')
        ;

        $this->testedInstance->onFinishedProviding($event);

        $this->assertEmpty($this->testedInstance->progressBar);
    }
}