AndXBuilderTest::testBuildThrowExceptionIfNotAndXSpecification() - Code Metrics - Inspection of "feat: handler" - gbprod/elastica-specification - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#6)

by GBProd

created 2016-09-04 12:39 UTC

testBuildThrowExceptionIfNotAndXSpecification() A

↳ Parent: AndXBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	10
loc	10
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

namespace Tests\GBProd\ElasticaSpecification;

use Elastica\QueryBuilder;
use Elastica\Query\AbstractQuery;
use Elastica\Query\BoolQuery;
use GBProd\ElasticaSpecification\ExpressionBuilder\AndXBuilder;
use GBProd\ElasticaSpecification\ExpressionBuilder\Builder;
use GBProd\ElasticaSpecification\Registry;
use GBProd\Specification\AndX;
use GBProd\Specification\Specification;

class AndXBuilderTest extends \PHPUnit_Framework_TestCase
{
    public function testConstruct()
    {
        $builder = new AndXBuilder(new Registry());

        $this->assertInstanceOf(AndXBuilder::class, $builder);
    }

    public function testBuildReturnsAndxExpression()
    {
        $andx = $this->createAndX();
        $registry = $this->createRegistry($andx);

        $builder = new AndXBuilder($registry);

        $query = $builder->build($andx, new QueryBuilder());

        $this->assertInstanceOf(BoolQuery::class, $query);

        $this->assertArrayHasKey('bool', $query->toArray());
        $this->assertArrayHasKey('must', $query->toArray()['bool']);
        $this->assertCount(2, $query->toArray()['bool']['must']);
    }

    /**
     * @return AndX
     */
    private function createAndX()
    {
        return new AndX(
            $this->createMock(Specification::class),
            $this->createMock(Specification::class)
        );
    }

    /**
     * @param AndX $andx
     *
     * @return Registry
     */
    private function createRegistry($andx)
    {
        $builder = $this->createMock(Builder::class);
        $builder
            ->expects($this->any())
            ->method('build')
            ->willReturn($this->createMock(AbstractQuery::class))
        ;

        $registry = new Registry();

        $registry->register(get_class($andx->getFirstPart()), $builder);
        $registry->register(get_class($andx->getSecondPart()), $builder);

        return $registry;
    }


    public function testBuildThrowExceptionIfNotAndXSpecification()

    {
        $spec = $this->createMock(Specification::class);
        $registry = new Registry();
        $builder = new AndXBuilder($registry);

        $this->expectException(\InvalidArgumentException::class);

        $expr = $builder->build($spec, new QueryBuilder());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1		<?php
2
3		namespace Tests\GBProd\ElasticaSpecification;
4
5		use Elastica\QueryBuilder;
6		use Elastica\Query\AbstractQuery;
7		use Elastica\Query\BoolQuery;
8		use GBProd\ElasticaSpecification\ExpressionBuilder\AndXBuilder;
9		use GBProd\ElasticaSpecification\ExpressionBuilder\Builder;
10		use GBProd\ElasticaSpecification\Registry;
11		use GBProd\Specification\AndX;
12		use GBProd\Specification\Specification;
13
14		class AndXBuilderTest extends \PHPUnit_Framework_TestCase
15		{
16		public function testConstruct()
17		{
18		$builder = new AndXBuilder(new Registry());
19
20		$this->assertInstanceOf(AndXBuilder::class, $builder);
21		}
22
23		public function testBuildReturnsAndxExpression()
24		{
25		$andx = $this->createAndX();
26		$registry = $this->createRegistry($andx);
27
28		$builder = new AndXBuilder($registry);
29
30		$query = $builder->build($andx, new QueryBuilder());
31
32		$this->assertInstanceOf(BoolQuery::class, $query);
33
34		$this->assertArrayHasKey('bool', $query->toArray());
35		$this->assertArrayHasKey('must', $query->toArray()['bool']);
36		$this->assertCount(2, $query->toArray()['bool']['must']);
37		}
38
39		/**
40		* @return AndX
41		*/
42		private function createAndX()
43		{
44		return new AndX(
45		$this->createMock(Specification::class),
46		$this->createMock(Specification::class)
47		);
48		}
49
50		/**
51		* @param AndX $andx
52		*
53		* @return Registry
54		*/
55		private function createRegistry($andx)
56		{
57		$builder = $this->createMock(Builder::class);
58		$builder
59		->expects($this->any())
60		->method('build')
61		->willReturn($this->createMock(AbstractQuery::class))
62		;
63
64		$registry = new Registry();
65
66		$registry->register(get_class($andx->getFirstPart()), $builder);
67		$registry->register(get_class($andx->getSecondPart()), $builder);
68
69		return $registry;
70		}
71
72
73	View Code Duplication	public function testBuildThrowExceptionIfNotAndXSpecification()
		0 ignored issues – show Duplication introduced 2016-09-04 11:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$spec = $this->createMock(Specification::class);
76		$registry = new Registry();
77		$builder = new AndXBuilder($registry);
78
79		$this->expectException(\InvalidArgumentException::class);
80
81		$expr = $builder->build($spec, new QueryBuilder());
		0 ignored issues – show Unused Code introduced 2016-09-04 07:52 UTC by Report Bug Copy Issue Report `$expr` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
82		}
83		}
84

gbprod / elastica-specification

Pull Request — master (#6)

testBuildThrowExceptionIfNotAndXSpecification() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like