NotBuilderTest::createNot() - Code Metrics - Inspection of "feat: not" - gbprod/elastica-specification - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#5)

by GBProd

created 2016-09-04 11:54 UTC

NotBuilderTest::createNot() A

↳ Parent: NotBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Tests\GBProd\ElasticaSpecification;

use Elastica\QueryBuilder;
use Elastica\Query\AbstractQuery;
use Elastica\Query\BoolQuery;
use GBProd\ElasticaSpecification\ExpressionBuilder\NotBuilder;
use GBProd\ElasticaSpecification\ExpressionBuilder\Builder;
use GBProd\ElasticaSpecification\Registry;
use GBProd\Specification\Not;
use GBProd\Specification\Specification;

class NotBuilderTest extends \PHPUnit_Framework_TestCase
{
    public function testConstruct()
    {
        $builder = new NotBuilder(new Registry());

        $this->assertInstanceOf(NotBuilder::class, $builder);
    }

    public function testBuildReturnsNotExpression()

    {
        $not = $this->createNot();
        $registry = $this->createRegistry($not);

        $builder = new NotBuilder($registry);

        $query = $builder->build($not, new QueryBuilder());

        $this->assertInstanceOf(BoolQuery::class, $query);

        $this->assertArrayHasKey('bool', $query->toArray());
        $this->assertArrayHasKey('must_not', $query->toArray()['bool']);
        $this->assertCount(1, $query->toArray()['bool']['must_not']);
    }

    /**
     * @return Not
     */
    private function createNot()
    {
        return new Not(
            $this->createMock(Specification::class)
        );
    }

    /**
     * @param Not $not
     *
     * @return Registry
     */
    private function createRegistry($not)
    {
        $builder = $this->createMock(Builder::class);
        $builder
            ->expects($this->any())
            ->method('build')
            ->willReturn($this->createMock(AbstractQuery::class))
        ;

        $registry = new Registry();

        $registry->register(get_class($not->getWrappedSpecification()), $builder);

        return $registry;
    }


    public function testBuildThrowExceptionIfNotNotSpecification()

    {
        $spec = $this->createMock(Specification::class);
        $registry = new Registry();
        $builder = new NotBuilder($registry);

        $this->setExpectedException(\InvalidArgumentException::class);


        $expr = $builder->build($spec, new QueryBuilder());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1		<?php
2
3		namespace Tests\GBProd\ElasticaSpecification;
4
5		use Elastica\QueryBuilder;
6		use Elastica\Query\AbstractQuery;
7		use Elastica\Query\BoolQuery;
8		use GBProd\ElasticaSpecification\ExpressionBuilder\NotBuilder;
9		use GBProd\ElasticaSpecification\ExpressionBuilder\Builder;
10		use GBProd\ElasticaSpecification\Registry;
11		use GBProd\Specification\Not;
12		use GBProd\Specification\Specification;
13
14		class NotBuilderTest extends \PHPUnit_Framework_TestCase
15		{
16		public function testConstruct()
17		{
18		$builder = new NotBuilder(new Registry());
19
20		$this->assertInstanceOf(NotBuilder::class, $builder);
21		}
22
23	View Code Duplication	public function testBuildReturnsNotExpression()
		0 ignored issues – show Duplication introduced 2016-09-04 11:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		$not = $this->createNot();
26		$registry = $this->createRegistry($not);
27
28		$builder = new NotBuilder($registry);
29
30		$query = $builder->build($not, new QueryBuilder());
31
32		$this->assertInstanceOf(BoolQuery::class, $query);
33
34		$this->assertArrayHasKey('bool', $query->toArray());
35		$this->assertArrayHasKey('must_not', $query->toArray()['bool']);
36		$this->assertCount(1, $query->toArray()['bool']['must_not']);
37		}
38
39		/**
40		* @return Not
41		*/
42		private function createNot()
43		{
44		return new Not(
45		$this->createMock(Specification::class)
46		);
47		}
48
49		/**
50		* @param Not $not
51		*
52		* @return Registry
53		*/
54		private function createRegistry($not)
55		{
56		$builder = $this->createMock(Builder::class);
57		$builder
58		->expects($this->any())
59		->method('build')
60		->willReturn($this->createMock(AbstractQuery::class))
61		;
62
63		$registry = new Registry();
64
65		$registry->register(get_class($not->getWrappedSpecification()), $builder);
66
67		return $registry;
68		}
69
70
71	View Code Duplication	public function testBuildThrowExceptionIfNotNotSpecification()
		0 ignored issues – show Duplication introduced 2016-09-04 11:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		{
73		$spec = $this->createMock(Specification::class);
74		$registry = new Registry();
75		$builder = new NotBuilder($registry);
76
77		$this->setExpectedException(\InvalidArgumentException::class);
		0 ignored issues – show Deprecated Code introduced 2016-09-04 11:56 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
78
79		$expr = $builder->build($spec, new QueryBuilder());
		0 ignored issues – show Unused Code introduced 2016-09-04 11:56 UTC by Report Bug Copy Issue Report `$expr` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
80		}
81		}
82

gbprod / elastica-specification

Pull Request — master (#5)

NotBuilderTest::createNot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like