HandlerTest - Code Metrics - gbprod/algolia-specification - Measure and Improve Code Quality continuously with Scrutinizer

HandlerTest A
last analyzed 2018-02-26 09:41 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	7
dl	0
loc	70
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	setUp()	5	1
A	testConstructWillRegisterBaseFactoriess()	20	1
A	testRegisterFactoryAddFactoryInRegistry()	12	1
A	testHandle()	17	1

<?php

namespace Tests\GBProd\AlgoliaSpecification;

use GBProd\AlgoliaSpecification\Handler;
use GBProd\AlgoliaSpecification\QueryFactory\AndXFactory;
use GBProd\AlgoliaSpecification\QueryFactory\Factory;
use GBProd\AlgoliaSpecification\QueryFactory\NotFactory;
use GBProd\AlgoliaSpecification\QueryFactory\OrXFactory;
use GBProd\AlgoliaSpecification\Registry;
use GBProd\Specification\AndX;
use GBProd\Specification\Not;
use GBProd\Specification\OrX;
use GBProd\Specification\Specification;
use PHPUnit\Framework\TestCase;

class HandlerTest extends TestCase
{
    /**
     * @var Registry
     */
    private $registry;

    /**
     * @var Handler
     */
    private $handler;

    protected function setUp()
    {
        $this->registry = new Registry();
        $this->handler = new Handler($this->registry);
    }

    public function testConstructWillRegisterBaseFactoriess()
    {
        $spec1 = $this->createMock(Specification::class);
        $spec2 = $this->createMock(Specification::class);

        $this->assertInstanceOf(
            AndXFactory::class,
            $this->registry->getFactory(new AndX($spec1, $spec2))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->assertInstanceOf(
            OrXFactory::class,
            $this->registry->getFactory(new OrX($spec1, $spec2))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->assertInstanceOf(
            NotFactory::class,
            $this->registry->getFactory(new Not($spec1))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    public function testRegisterFactoryAddFactoryInRegistry()
    {
        $factory = $this->createMock(Factory::class);
        $spec = $this->createMock(Specification::class);

        $this->handler->registerFactory(get_class($spec), $factory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(
            $factory,
            $this->registry->getFactory($spec)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    public function testHandle()
    {
        $this->handler = new Handler(new Registry());

        $factory = $this->prophesize(Factory::class);

        $spec = $this->createMock(Specification::class);
        $this->handler->registerFactory(get_class($spec), $factory->reveal());

        $factory
            ->create($spec)
            ->willReturn('query')
            ->shouldBeCalled()
        ;

        $this->assertEquals('query', $this->handler->handle($spec));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Tests\GBProd\AlgoliaSpecification;
4
5			use GBProd\AlgoliaSpecification\Handler;
6			use GBProd\AlgoliaSpecification\QueryFactory\AndXFactory;
7			use GBProd\AlgoliaSpecification\QueryFactory\Factory;
8			use GBProd\AlgoliaSpecification\QueryFactory\NotFactory;
9			use GBProd\AlgoliaSpecification\QueryFactory\OrXFactory;
10			use GBProd\AlgoliaSpecification\Registry;
11			use GBProd\Specification\AndX;
12			use GBProd\Specification\Not;
13			use GBProd\Specification\OrX;
14			use GBProd\Specification\Specification;
15			use PHPUnit\Framework\TestCase;
16
17			class HandlerTest extends TestCase
18			{
19			/**
20			* @var Registry
21			*/
22			private $registry;
23
24			/**
25			* @var Handler
26			*/
27			private $handler;
28
29			protected function setUp()
30			{
31			$this->registry = new Registry();
32			$this->handler = new Handler($this->registry);
33			}
34
35			public function testConstructWillRegisterBaseFactoriess()
36			{
37			$spec1 = $this->createMock(Specification::class);
38			$spec2 = $this->createMock(Specification::class);
39
40			$this->assertInstanceOf(
41			AndXFactory::class,
42			$this->registry->getFactory(new AndX($spec1, $spec2))
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec1` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			);
44
45			$this->assertInstanceOf(
46			OrXFactory::class,
47			$this->registry->getFactory(new OrX($spec1, $spec2))
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec1` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			);
49
50			$this->assertInstanceOf(
51			NotFactory::class,
52			$this->registry->getFactory(new Not($spec1))
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec1` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			);
54			}
55
56			public function testRegisterFactoryAddFactoryInRegistry()
57			{
58			$factory = $this->createMock(Factory::class);
59			$spec = $this->createMock(Specification::class);
60
61			$this->handler->registerFactory(get_class($spec), $factory);
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$factory` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\AlgoliaSpe...n\QueryFactory\Factory>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62
63			$this->assertEquals(
64			$factory,
65			$this->registry->getFactory($spec)
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
66			);
67			}
68
69			public function testHandle()
70			{
71			$this->handler = new Handler(new Registry());
72
73			$factory = $this->prophesize(Factory::class);
74
75			$spec = $this->createMock(Specification::class);
76			$this->handler->registerFactory(get_class($spec), $factory->reveal());
77
78			$factory
79			->create($spec)
80			->willReturn('query')
81			->shouldBeCalled()
82			;
83
84			$this->assertEquals('query', $this->handler->handle($spec));
			0 ignored issues – show Documentation introduced 2018-02-22 17:10 UTC by Report Bug Copy Issue Report `$spec` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<GBProd\Specification\Specification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85			}
86			}
87

gbprod / algolia-specification

HandlerTest A last analyzed 2018-02-26 09:41 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

HandlerTest A
last analyzed 2018-02-26 09:41 UTC