gbere / simple-auth-bundle

src/Command/GbUserPromoteCommand.php

<?php

declare(strict_types=1);

namespace Gbere\SimpleAuth\Command;

use Gbere\SimpleAuth\Entity\Role;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\Console\Style\SymfonyStyle;

final class GbUserPromoteCommand extends AbstractCommand
{
    private const QUESTION_MAX_ATTEMPTS = 3;

    protected static $defaultName = 'gb:user:promote';

    protected function configure(): void
    {
        $this
            ->setDescription('Promote a user')
            ->addArgument('email', InputArgument::OPTIONAL)
            ->addArgument('role', InputArgument::OPTIONAL)
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $io = new SymfonyStyle($input, $output);
        $helper = $this->getHelper('question');
        $email = $input->getArgument('email');
        $roleName = $input->getArgument('role');

        /** @var Role[] $allRoles */
        $allRoles = $this->findAllRoles();
        if (0 === \count($allRoles)) {
            $io->error('There is no role to select. Please, create some role first.');

            return 1;
        }

        if (null === $email) {
            $question = new Question('Please, enter the email address of the user: ');
            $question->setValidator(function ($answer) {
                if (null === $answer) {
                    throw new \Exception('The email address of the user to promote is required');
                }

                return $answer;
            });
            $question->setMaxAttempts(self::QUESTION_MAX_ATTEMPTS);
            if ($this->isTestEnv()) {
                $question->setMaxAttempts(1);
            }
            $email = $helper->ask($input, $output, $question);
        }
        $user = $this->findUserByEmail($email);
        if (null === $user) {
            $io->error(sprintf('The user with the email "%s" doesnt exist', $email));

            return 1;
        }

        $role = null;
        if (null !== $roleName) {
            $role = $this->findRoleByName($roleName);

It seems like $roleName can also be of type string[]; however, parameter $name of Gbere\SimpleAuth\Command\AbstractCommand::findRoleByName() does only seem to accept string, maybe add an additional type check?

            if (null === $role) {
                $io->warning(sprintf('The role "%s" doesnt exist. Please, select a valid role', $roleName));

It seems like $roleName can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            }
        }
        if (null === $role) {
            $question = new ChoiceQuestion('Select a role', $allRoles);
            $question->setErrorMessage('The role %s is invalid.');
            $roleName = $helper->ask($input, $output, $question);
            $role = $this->findRoleByName($roleName);
        }
        $user->addRoleEntity($role);

It seems like $role can also be of type null; however, parameter $role of Gbere\SimpleAuth\Model\UserInterface::addRoleEntity() does only seem to accept Gbere\SimpleAuth\Entity\Role, maybe add an additional type check?

        $this->getEntityManager()->persist($user);
        $this->getEntityManager()->flush();

        $io->success(sprintf('The role %s was added to the user %s', $roleName, $email));

        return 0;
    }
}