Issues in user.js (master) - Issues in master - garyvv/node-sharp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (124)

app/controller/user.js (11 issues)

Labels

Severity

const Response = require('../util/response')
const Validate = require('../util/validate')

const ModelUser = require('../model/users')
const General = require('../helpers/general')
const ApiError = require('../util/api_error')

module.exports = {

	detail: async function (ctx) {

		let data = await ModelUser.getUser(ctx.uid)
		return Response.output(ctx, data)
	},

	edit: async function (ctx) {
		console.log('--------- ctx-uid: --------' + ctx.uid)

		console.log(ctx.input.nickname)
		let updateData = {}
		if (!!ctx.input.nickname) updateData.nickname = ctx.input.nickname
if (a > 0)
    b = 42;
		if (!!ctx.input.gender) updateData.gender = ctx.input.gender
if (a > 0)
    b = 42;
		if (!!ctx.input.avatar) updateData.avatar = ctx.input.avatar
if (a > 0)
    b = 42;
		if (!!ctx.input.country) updateData.country = ctx.input.country
if (a > 0)
    b = 42;
		if (!!ctx.input.province) updateData.province = ctx.input.province
if (a > 0)
    b = 42;
		if (!!ctx.input.city) updateData.city = ctx.input.city
if (a > 0)
    b = 42;
		if (!!ctx.input.mobile) updateData.mobile = ctx.input.mobile
if (a > 0)
    b = 42;
		if (!!ctx.input.language) updateData.language = ctx.input.language
if (a > 0)
    b = 42;

		let where = {
			'id': ctx.uid,
		}

		if (await General.isEmpty(updateData)) {
			throw new ApiError('common.paramsEmpty', '更新内容')
		} else {
			let data = await ModelUser.editUser(updateData, where)

			return Response.output(ctx, {})
		}

	}

}

1			const Response = require('../util/response')
2			const Validate = require('../util/validate')
			0 ignored issues – show Unused Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `Validate` seems to be never used. Consider removing it. Loading history...
3			const ModelUser = require('../model/users')
4			const General = require('../helpers/general')
5			const ApiError = require('../util/api_error')
6
7			module.exports = {
8
9			detail: async function (ctx) {
10
11			let data = await ModelUser.getUser(ctx.uid)
12			return Response.output(ctx, data)
13			},
14
15			edit: async function (ctx) {
16			console.log('--------- ctx-uid: --------' + ctx.uid)
			0 ignored issues – show Debugging Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
17			console.log(ctx.input.nickname)
18			let updateData = {}
19			if (!!ctx.input.nickname) updateData.nickname = ctx.input.nickname
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
20			if (!!ctx.input.gender) updateData.gender = ctx.input.gender
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
21			if (!!ctx.input.avatar) updateData.avatar = ctx.input.avatar
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
22			if (!!ctx.input.country) updateData.country = ctx.input.country
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
23			if (!!ctx.input.province) updateData.province = ctx.input.province
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
24			if (!!ctx.input.city) updateData.city = ctx.input.city
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
25			if (!!ctx.input.mobile) updateData.mobile = ctx.input.mobile
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
26			if (!!ctx.input.language) updateData.language = ctx.input.language
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
27
28			let where = {
29			'id': ctx.uid,
30			}
31
32			if (await General.isEmpty(updateData)) {
33			throw new ApiError('common.paramsEmpty', '更新内容')
34			} else {
35			let data = await ModelUser.editUser(updateData, where)
			0 ignored issues – show Unused Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `data` seems to be never used. Consider removing it. Loading history...
36			return Response.output(ctx, {})
37			}
38
39			}
40
41			}

garyvv / node-sharp

Issues (124)

app/controller/user.js (11 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like