module.exports.edit - Code Metrics - Inspection of "Merge pull request #38 from garyvv/develop" - garyvv/node-sharp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1adf40...f067da )

by lv

created 2018-07-31 16:10 UTC

module.exports.edit C

↳ Parent: app/controller/catering/customer.js

Complexity

Conditions	10
Paths	256

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	17
c	1
b	0
f	0
nc	256
dl	0
loc	23
rs	5.9999
nop	1

How to fix Complexity

const Response = require('../../util/response')
const Validate = require('request-validate')
const ModelCustomer = require('../../model/catering/customer')
const ModelSeller = require('../../model/catering/seller')
const ApiError = require('../../util/api_error')
const WeChatSDK = require('../../util/wechat/wechat_sdk')
const _ = require('underscore')
const OssSdk = require('../../libraries/ossSdk')
const ConfigOss = require('../../../config/oss')
const Uuid = require('../../libraries/uuid')
const fs = require('fs')

module.exports = {

	detail: async function (ctx) {

		let data = await ModelCustomer.first(ctx.uid)
		return Response.output(ctx, data)
	},

	/**
     * @api {put} /api/catering/v1/customer/:customerId 编辑用户信息
	 * @apiVersion 1.0.0
	 * @apiName 编辑用户信息
     * @apiGroup customer
     * @apiPermission user
	 * 
	 * @apiDescription API to edit the customer information.
	 * 
	 * @apiExample Example usage:
    	curl --request PUT \
			--url https://garylv.com/api/catering/v1/customers/1 \
			--header 'mina-source: catering' \
			--header 'store-id: 0'
	 * 
     * @apiParam {String} [nickName] nickName
     * @apiParam {String} [gender] gender
     * @apiParam {String} [avatarUrl] avatarUrl
     * @apiParam {String} [country] country
     * @apiParam {String} [province] province
     * @apiParam {String} [city] city
     * @apiParam {String} [mobile] mobile
     * @apiParam {String} [language] language
	 * 
	 * @apiSuccess {String} data response data
	 * 
     * @apiSuccessExample {json} Visual Preview:
		{
			"code": 200,
			"message": "请求成功",
			"data": {}
		}
	 * @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId
     */
	edit: async function (ctx) {
		let updateData = {}
		if (!!ctx.input.nickName) updateData.nickname = ctx.input.nickName
if (a > 0)
    b = 42;
		if (!!ctx.input.gender) updateData.gender = ctx.input.gender
if (a > 0)
    b = 42;
		if (!!ctx.input.avatarUrl) updateData.avatar = ctx.input.avatarUrl
if (a > 0)
    b = 42;
		if (!!ctx.input.country) updateData.country = ctx.input.country
if (a > 0)
    b = 42;
		if (!!ctx.input.province) updateData.province = ctx.input.province
if (a > 0)
    b = 42;
		if (!!ctx.input.city) updateData.city = ctx.input.city
if (a > 0)
    b = 42;
		if (!!ctx.input.mobile) updateData.mobile = ctx.input.mobile
if (a > 0)
    b = 42;
		if (!!ctx.input.language) updateData.language = ctx.input.language
if (a > 0)
    b = 42;

		let where = {
			'id': ctx.uid,
		}

		if (_.isEmpty(updateData)) {
			throw new ApiError('common.paramsEmpty', '更新内容')
		} else {
			let data = await ModelCustomer.edit(updateData, where)

			return Response.output(ctx, {})
		}

	},

	/**
     * @api {post} /api/catering/v1/customer/:customerId/seller 申请成为商家
	 * @apiVersion 1.0.0
     * @apiGroup customer
     * @apiPermission user
	 * 
	 * @apiDescription 普通用户申请开店
	 * 
     * @apiParam {String} company 店铺名称
     * @apiParam {String} avatar 店铺头像
     * @apiParam {String} tel 店铺联系电话
     * @apiParam {String} address 店铺地址
     * @apiParam {String} license 店铺营业执照路径
	 * 
	 * @apiSuccess {String} data response data
	 * 
     * @apiSuccessExample {json} Visual Preview:
		{
			"code": 200,
			"message": "请求成功",
			"data": {}
		}
	 * @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId/sellers
     */
	applySeller: async function (ctx) {
		Validate(ctx.input, {
			company: 'required',
			avatar: 'required',
			tel: 'required',
			address: 'required',
			license: 'required',
		})

		let check = await ModelSeller.first(ctx.uid)
		if (check) {
			let updateData = {
				company: ctx.input.company,
				avatar: ctx.input.avatar,
				tel: ctx.input.tel,
				address: ctx.input.address,
				license: ctx.input.license,
			}
			await ModelSeller.edit(updateData, { seller_id: ctx.uid })
			updateData.seller_id = ctx.uid
			return Response.output(ctx, updateData)
		}

		let insertData = {
			seller_id: ctx.uid,
			company: ctx.input.company,
			avatar: ctx.input.avatar,
			tel: ctx.input.tel,
			address: ctx.input.address,
			license: ctx.input.license,
		}

		let data = await ModelSeller.add(insertData)

		return Response.output(ctx, insertData)

	},

	/**
     * @api {post} /api/catering/v1/customer/:customerId/mina_qrcodes 小程序码
	 * @apiVersion 1.0.0
     * @apiGroup customer
     * @apiPermission user
	 * 
	 * @apiDescription 小程序码
	 * 
     * @apiParam {String} action 行为['apply_seller']
     * @apiParam {String} action_id 行为ID
	 * 
	 * @apiSuccess {String} data response data
	 * 
     * @apiSuccessExample {json} Visual Preview:
		{
			"code": 200,
			"message": "请求成功",
			"data": {}
		}
	 * @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId/mina_qrcodes
     */
	minaQRcode: async function (ctx) {
		Validate(ctx.input, {
			action: 'required|in:apply_seller',
			action_id: 'required|numeric',
		})

		let config = ctx.header['mina-source']
		let wechatSdk = new WeChatSDK(config)

		let sence = 'seller_id=' + ctx.input.action_id
		let page = 'pages/admin/seller/audit'
		let imgResult = await wechatSdk.minaTmpQRCode(sence, page)

		let ossSdk = new OssSdk(ConfigOss.catering)
		let object = 'customer/' + ctx.uid + '/qrcode/' + imgResult.img_name
		await ossSdk.uploadFile(object, imgResult.img_file)

		fs.unlink(imgResult.img_file, function (err) {
			if (err) {
				console.log(err)

			}
			console.log('文件:' + imgResult.img_file + '删除成功！')
		})

		let result = {
			'object': object,
			'url': ConfigOss.catering.view_server + object
		}

		return Response.output(ctx, result)

	},

	oss: async function (ctx) {
		console.log('inputttttttttttttt')

		console.log(ctx.input)
		console.log(ctx.input.files.content)
		console.log(ctx.input.files.content.path)

		let files = ctx.input.files.content
		let postData = ctx.input.fields

		Validate(postData, {
			folder: 'required'
		})

		let ossSdk = new OssSdk(ConfigOss.catering)
		let fileType = files.type.split('/').pop()
		let object = 'customer/' + ctx.uid + '/' + postData.folder + '/' + await Uuid.genOrderNo() + '.' + fileType
		await ossSdk.uploadFile(object, files.path)

		let resp = {
			'object': object,
			'url': ConfigOss.catering.view_server + object + '?x-oss-process=style/preview'
		}

		return Response.output(ctx, resp)
	}

}

1			const Response = require('../../util/response')
2			const Validate = require('request-validate')
3			const ModelCustomer = require('../../model/catering/customer')
4			const ModelSeller = require('../../model/catering/seller')
5			const ApiError = require('../../util/api_error')
6			const WeChatSDK = require('../../util/wechat/wechat_sdk')
7			const _ = require('underscore')
8			const OssSdk = require('../../libraries/ossSdk')
9			const ConfigOss = require('../../../config/oss')
10			const Uuid = require('../../libraries/uuid')
11			const fs = require('fs')
12
13			module.exports = {
14
15			detail: async function (ctx) {
16
17			let data = await ModelCustomer.first(ctx.uid)
18			return Response.output(ctx, data)
19			},
20
21			/**
22			* @api {put} /api/catering/v1/customer/:customerId 编辑用户信息
23			* @apiVersion 1.0.0
24			* @apiName 编辑用户信息
25			* @apiGroup customer
26			* @apiPermission user
27			*
28			* @apiDescription API to edit the customer information.
29			*
30			* @apiExample Example usage:
31			curl --request PUT \
32			--url https://garylv.com/api/catering/v1/customers/1 \
33			--header 'mina-source: catering' \
34			--header 'store-id: 0'
35			*
36			* @apiParam {String} [nickName] nickName
37			* @apiParam {String} [gender] gender
38			* @apiParam {String} [avatarUrl] avatarUrl
39			* @apiParam {String} [country] country
40			* @apiParam {String} [province] province
41			* @apiParam {String} [city] city
42			* @apiParam {String} [mobile] mobile
43			* @apiParam {String} [language] language
44			*
45			* @apiSuccess {String} data response data
46			*
47			* @apiSuccessExample {json} Visual Preview:
48			{
49			"code": 200,
50			"message": "请求成功",
51			"data": {}
52			}
53			* @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId
54			*/
55			edit: async function (ctx) {
56			let updateData = {}
57			if (!!ctx.input.nickName) updateData.nickname = ctx.input.nickName
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
58			if (!!ctx.input.gender) updateData.gender = ctx.input.gender
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
59			if (!!ctx.input.avatarUrl) updateData.avatar = ctx.input.avatarUrl
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
60			if (!!ctx.input.country) updateData.country = ctx.input.country
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
61			if (!!ctx.input.province) updateData.province = ctx.input.province
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
62			if (!!ctx.input.city) updateData.city = ctx.input.city
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
63			if (!!ctx.input.mobile) updateData.mobile = ctx.input.mobile
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
64			if (!!ctx.input.language) updateData.language = ctx.input.language
			0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
65
66			let where = {
67			'id': ctx.uid,
68			}
69
70			if (_.isEmpty(updateData)) {
71			throw new ApiError('common.paramsEmpty', '更新内容')
72			} else {
73			let data = await ModelCustomer.edit(updateData, where)
			0 ignored issues – show Unused Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report The variable `data` seems to be never used. Consider removing it. Loading history...
74			return Response.output(ctx, {})
75			}
76
77			},
78
79			/**
80			* @api {post} /api/catering/v1/customer/:customerId/seller 申请成为商家
81			* @apiVersion 1.0.0
82			* @apiGroup customer
83			* @apiPermission user
84			*
85			* @apiDescription 普通用户申请开店
86			*
87			* @apiParam {String} company 店铺名称
88			* @apiParam {String} avatar 店铺头像
89			* @apiParam {String} tel 店铺联系电话
90			* @apiParam {String} address 店铺地址
91			* @apiParam {String} license 店铺营业执照路径
92			*
93			* @apiSuccess {String} data response data
94			*
95			* @apiSuccessExample {json} Visual Preview:
96			{
97			"code": 200,
98			"message": "请求成功",
99			"data": {}
100			}
101			* @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId/sellers
102			*/
103			applySeller: async function (ctx) {
104			Validate(ctx.input, {
105			company: 'required',
106			avatar: 'required',
107			tel: 'required',
108			address: 'required',
109			license: 'required',
110			})
111
112			let check = await ModelSeller.first(ctx.uid)
113			if (check) {
114			let updateData = {
115			company: ctx.input.company,
116			avatar: ctx.input.avatar,
117			tel: ctx.input.tel,
118			address: ctx.input.address,
119			license: ctx.input.license,
120			}
121			await ModelSeller.edit(updateData, { seller_id: ctx.uid })
122			updateData.seller_id = ctx.uid
123			return Response.output(ctx, updateData)
124			}
125
126			let insertData = {
127			seller_id: ctx.uid,
128			company: ctx.input.company,
129			avatar: ctx.input.avatar,
130			tel: ctx.input.tel,
131			address: ctx.input.address,
132			license: ctx.input.license,
133			}
134
135			let data = await ModelSeller.add(insertData)
			0 ignored issues – show Unused Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report The variable `data` seems to be never used. Consider removing it. Loading history...
136			return Response.output(ctx, insertData)
137
138			},
139
140			/**
141			* @api {post} /api/catering/v1/customer/:customerId/mina_qrcodes 小程序码
142			* @apiVersion 1.0.0
143			* @apiGroup customer
144			* @apiPermission user
145			*
146			* @apiDescription 小程序码
147			*
148			* @apiParam {String} action 行为['apply_seller']
149			* @apiParam {String} action_id 行为ID
150			*
151			* @apiSuccess {String} data response data
152			*
153			* @apiSuccessExample {json} Visual Preview:
154			{
155			"code": 200,
156			"message": "请求成功",
157			"data": {}
158			}
159			* @apiSampleRequest https://garylv.com/api/catering/v1/customers/:customerId/mina_qrcodes
160			*/
161			minaQRcode: async function (ctx) {
162			Validate(ctx.input, {
163			action: 'required\|in:apply_seller',
164			action_id: 'required\|numeric',
165			})
166
167			let config = ctx.header['mina-source']
168			let wechatSdk = new WeChatSDK(config)
169
170			let sence = 'seller_id=' + ctx.input.action_id
171			let page = 'pages/admin/seller/audit'
172			let imgResult = await wechatSdk.minaTmpQRCode(sence, page)
173
174			let ossSdk = new OssSdk(ConfigOss.catering)
175			let object = 'customer/' + ctx.uid + '/qrcode/' + imgResult.img_name
176			await ossSdk.uploadFile(object, imgResult.img_file)
177
178			fs.unlink(imgResult.img_file, function (err) {
179			if (err) {
180			console.log(err)
			0 ignored issues – show Debugging Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
181			}
182			console.log('文件:' + imgResult.img_file + '删除成功！')
183			})
184
185			let result = {
186			'object': object,
187			'url': ConfigOss.catering.view_server + object
188			}
189
190			return Response.output(ctx, result)
191
192			},
193
194			oss: async function (ctx) {
195			console.log('inputttttttttttttt')
			0 ignored issues – show Debugging Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
196			console.log(ctx.input)
197			console.log(ctx.input.files.content)
198			console.log(ctx.input.files.content.path)
199
200			let files = ctx.input.files.content
201			let postData = ctx.input.fields
202
203			Validate(postData, {
204			folder: 'required'
205			})
206
207			let ossSdk = new OssSdk(ConfigOss.catering)
208			let fileType = files.type.split('/').pop()
209			let object = 'customer/' + ctx.uid + '/' + postData.folder + '/' + await Uuid.genOrderNo() + '.' + fileType
210			await ossSdk.uploadFile(object, files.path)
211
212			let resp = {
213			'object': object,
214			'url': ConfigOss.catering.view_server + object + '?x-oss-process=style/preview'
215			}
216
217			return Response.output(ctx, resp)
218			}
219
220			}

garyvv / node-sharp

Push — master ( 1adf40...f067da )

module.exports.edit C

Complexity

Size

Duplication

Importance

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like