app/model/catering/product.js - Code Metrics - garyvv/node-sharp - Measure and Improve Code Quality continuously with Scrutinizer

app/model/catering/product.js A
last analyzed 2019-04-10 06:27 UTC

↳ Parent: Project

Complexity

Total Complexity	6
Complexity/F	1.5

Size

Lines of Code	50
Function Count	4

Duplication

Duplicated Lines	50
Ratio	100 %

Importance

Changes

Metric	Value
cc	0
wmc	6
eloc	26
c	0
b	0
f	0
nc	1
mnd	1
bc	5
fnc	4
dl	50
loc	50
rs	10
bpm	1.25
cpm	1.5
noi	2

4 Functions

Rating	Name	Duplication	Size	Complexity
A	module.exports.edit	5	5	1
A	module.exports.first	11	11	1
A	module.exports.add	4	4	1
A	module.exports.list	18	18	3

How to fix Duplicated Code

const DB = require('../../libraries/db')

const ModelBase = require('../../model/base')
const _ = require('underscore')

const table = 'mist_product'

module.exports = {
    add: async function (data) {
        let res = await ModelBase.execInsert(table, data)
        return res;
    },

	list: async function (storeId, filter) {

		let result = DB.readMysql.select(
			'*'
		)
			.from(table)
			.where('store_id', storeId)
			.whereNot('status', -1)

		if (_.has(filter, 'status')) result.where('status', filter.status)
if (a > 0)
    b = 42;

		if (_.has(filter, 'category_id')) {

			// todo
		}

		return await result

	},

	first: async function (id) {

		let result = DB.readMysql.first(
			'*'
		)
			.from(table)
			.where('id', id)

		return await result

	},

	edit: async function (data, where, notWhere = {}) {
		let result = ModelBase.execUpdate(table, data, where, notWhere)

		return await result
	}

}


1	View Code Duplication	const DB = require('../../libraries/db')
		0 ignored issues – show Duplication introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2		const ModelBase = require('../../model/base')
3		const _ = require('underscore')
4
5		const table = 'mist_product'
6
7		module.exports = {
8		add: async function (data) {
9		let res = await ModelBase.execInsert(table, data)
10		return res;
11		},
12
13		list: async function (storeId, filter) {
14
15		let result = DB.readMysql.select(
16		'*'
17		)
18		.from(table)
19		.where('store_id', storeId)
20		.whereNot('status', -1)
21
22		if (_.has(filter, 'status')) result.where('status', filter.status)
		0 ignored issues – show Coding Style Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
23
24		if (_.has(filter, 'category_id')) {
		0 ignored issues – show Comprehensibility Documentation Best Practice introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report This code block is empty. Consider removing it or adding a comment to explain. Loading history...
25		// todo
26		}
27
28		return await result
29
30		},
31
32		first: async function (id) {
33
34		let result = DB.readMysql.first(
35		'*'
36		)
37		.from(table)
38		.where('id', id)
39
40		return await result
41
42		},
43
44		edit: async function (data, where, notWhere = {}) {
45		let result = ModelBase.execUpdate(table, data, where, notWhere)
46
47		return await result
48		}
49
50		}
51

garyvv / node-sharp

app/model/catering/product.js A last analyzed 2019-04-10 06:27 UTC

Complexity

Size

Duplication

Importance

4 Functions

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

app/model/catering/product.js A
last analyzed 2019-04-10 06:27 UTC