Issues in Swoole.php (master) - Issues in master - garveen/laravoole - Measure and Improve Code Quality continuously with Scrutinizer

Issues (68)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Wrapper/Swoole.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Laravoole\Wrapper;

use swoole_http_server;

use Laravoole\Base;
use Exception;

abstract class Swoole extends Base
{

    // http://wiki.swoole.com/wiki/page/274.html
    public static function getParams()
    {
        return [
            'reactor_num',
            'worker_num',
            'max_request' => 2000,
            'max_conn',
            'task_worker_num',
            'task_ipc_mode',
            'task_max_request',
            'task_tmpdir',
            'dispatch_mode',
            'message_queue_key',
            'daemonize' => 1,
            'backlog',
            'log_file' => [self::class, 'getLogFile'],
            'log_level',
            'heartbeat_check_interval',
            'heartbeat_idle_time',
            'open_eof_check',
            'open_eof_split',
            'package_eof',
            'open_length_check',
            'package_length_type',
            'package_max_length',
            'open_cpu_affinity',
            'cpu_affinity_ignore',
            'open_tcp_nodelay',
            'tcp_defer_accept',
            'ssl_cert_file',
            'ssl_method',
            'user',
            'group',
            'chroot',
            'pipe_buffer_size',
            'buffer_output_size',
            'enable_unsafe_event',
            'discard_timeout_request',
            'enable_reuse_port',
        ];
    }

    public function start()
    {
        $callbacks = array_merge([
            'Start' => [$this, 'onServerStart'],
            'Shutdown' => [$this, 'onServerShutdown'],
            'WorkerStart' => [$this, 'onWorkerStart'],
        ], $this->callbacks);
        if (isset($this->wrapper_config['swoole_ontask'])) {
            $callbacks['Task'] = $this->wrapper_config['swoole_ontask'];
            $callbacks['Finish'] = $this->wrapper_config['swoole_onfinish'];
        }
        foreach ($callbacks as $on => $method) {
            $this->server->on($on, $method);

        }
        return $this->server->start();

    }

    /**
     * @codeCoverageIgnore
     */
    public function onServerStart()
    {
        // put pid
        file_put_contents(
            $this->pid_file,
            $this->getPid()
        );
    }

    public function onWorkerStart($serv, $worker_id)
    {
        parent::prepareKernel();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $server = $this->server;
        $this->app->singleton('laravoole.server', function ($app) use ($server) {

            return $server;
        });
    }

    /**
     * @codeCoverageIgnore
     */
    public function onServerShutdown($serv)

    {
        @unlink($this->pid_file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    public static function getLogFile()
    {
        return app()->storagePath() . '/logs/laravoole.log';
    }

    public function on($event, callable $callback)
    {
        return $this->server->on($event, $callback);

    }

    public function send($fd, $content)
    {
        return $this->server->send($fd, $content);

    }

    public function close($fd)
    {
        return $this->server->close($fd);

    }

    public function getPid()
    {
        return $this->server->master_pid;
    }


}


1		<?php
2		namespace Laravoole\Wrapper;
3
4		use swoole_http_server;
5
6		use Laravoole\Base;
7		use Exception;
8
9		abstract class Swoole extends Base
10		{
11
12		// http://wiki.swoole.com/wiki/page/274.html
13		public static function getParams()
14		{
15		return [
16		'reactor_num',
17		'worker_num',
18		'max_request' => 2000,
19		'max_conn',
20		'task_worker_num',
21		'task_ipc_mode',
22		'task_max_request',
23		'task_tmpdir',
24		'dispatch_mode',
25		'message_queue_key',
26		'daemonize' => 1,
27		'backlog',
28		'log_file' => [self::class, 'getLogFile'],
29		'log_level',
30		'heartbeat_check_interval',
31		'heartbeat_idle_time',
32		'open_eof_check',
33		'open_eof_split',
34		'package_eof',
35		'open_length_check',
36		'package_length_type',
37		'package_max_length',
38		'open_cpu_affinity',
39		'cpu_affinity_ignore',
40		'open_tcp_nodelay',
41		'tcp_defer_accept',
42		'ssl_cert_file',
43		'ssl_method',
44		'user',
45		'group',
46		'chroot',
47		'pipe_buffer_size',
48		'buffer_output_size',
49		'enable_unsafe_event',
50		'discard_timeout_request',
51		'enable_reuse_port',
52		];
53		}
54
55	12	public function start()
56		{
57	12	$callbacks = array_merge([
58	12	'Start' => [$this, 'onServerStart'],
59	12	'Shutdown' => [$this, 'onServerShutdown'],
60	12	'WorkerStart' => [$this, 'onWorkerStart'],
61	12	], $this->callbacks);
62	12	if (isset($this->wrapper_config['swoole_ontask'])) {
63		$callbacks['Task'] = $this->wrapper_config['swoole_ontask'];
64	2	$callbacks['Finish'] = $this->wrapper_config['swoole_onfinish'];
65		}
66	12	foreach ($callbacks as $on => $method) {
67	12	$this->server->on($on, $method);
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `on()` does not seem to exist on `object<Laravoole\Workerman\Worker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68	6	}
69	12	return $this->server->start();
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `start()` does not seem to exist on `object<Laravoole\Workerman\Worker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
70		}
71
72		/**
73		* @codeCoverageIgnore
74		*/
75		public function onServerStart()
76		{
77		// put pid
78		file_put_contents(
79		$this->pid_file,
80		$this->getPid()
81		);
82		}
83
84	12	public function onWorkerStart($serv, $worker_id)
85		{
86	12	parent::prepareKernel();
		0 ignored issues – show Comprehensibility Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`prepareKernel()` instead of `onWorkerStart()`). Are you sure this is correct? If so, you might want to change this to `$this->prepareKernel()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
87	12	$server = $this->server;
88	12	$this->app->singleton('laravoole.server', function ($app) use ($server) {
		0 ignored issues – show Unused Code introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
89		return $server;
90	12	});
91	12	}
92
93		/**
94		* @codeCoverageIgnore
95		*/
96		public function onServerShutdown($serv)
		0 ignored issues – show Unused Code introduced 2017-08-11 06:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$serv` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
97		{
98		@unlink($this->pid_file);
		0 ignored issues – show Security Best Practice introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
99		}
100
101		public static function getLogFile()
102		{
103		return app()->storagePath() . '/logs/laravoole.log';
104		}
105
106	6	public function on($event, callable $callback)
107	6	{
108		return $this->server->on($event, $callback);
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `on()` does not seem to exist on `object<Laravoole\Workerman\Worker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
109		}
110
111		public function send($fd, $content)
112		{
113		return $this->server->send($fd, $content);
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `send()` does not seem to exist on `object<Laravoole\Workerman\Worker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
114		}
115
116	2	public function close($fd)
117		{
118	2	return $this->server->close($fd);
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `close()` does not seem to exist on `object<Laravoole\Workerman\Worker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
119		}
120
121		public function getPid()
122		{
123		return $this->server->master_pid;
124		}
125
126
127		}
128

garveen / laravoole

Issues (68)

Security Analysis not enabled

src/Wrapper/Swoole.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like