garveen / laravoole

src/Commands/LaravooleCommand.php

<?php

namespace Laravoole\Commands;

use ReflectionClass;

use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;

class LaravooleCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'laravoole {action : start | stop | reload | reload_task | restart | quit}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Laravoole control utilities';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command before Laravel < 5.5.
     * 
     * @return mixed
     */
    public function fire()
    {
        $this->handle();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        switch ($action = $this->argument('action')) {

            case 'start':
                $this->start();
                break;
            case 'restart':
                $pid = $this->sendSignal(SIGTERM);

Are you sure the assignment to $pid is correct as $this->sendSignal(SIGTERM) (which targets Laravoole\Commands\LaravooleCommand::sendSignal()) seems to always return null.

                $time = 0;
                while (posix_getpgid($pid) && $time <= 10) {
                    usleep(100000);
                    $time++;
                }
                if ($time > 100) {
                    echo 'timeout' . PHP_EOL;
                    exit(1);

The method handle() contains an exit expression.

                }
                $this->start();
                break;
            case 'stop':
            case 'quit':
            case 'reload':
            case 'reload_task':

The case body in a switch statement must start on the line following the statement.

                $map = [
                    'stop' => SIGTERM,
                    'quit' => SIGQUIT,
                    'reload' => SIGUSR1,
                    'reload_task' => SIGUSR2,
                ];
                $this->sendSignal($map[$action]);
                break;

        }
    }

    protected function sendSignal($sig)
    {
        if ($pid = $this->getPid()) {

            posix_kill($pid, $sig);
        } else {

            echo "not running!" . PHP_EOL;
            exit(1);

The method sendSignal() contains an exit expression.

        }
    }

    protected function start()
    {
        if ($this->getPid()) {

The expression $this->getPid() of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            echo 'already running' . PHP_EOL;
            exit(1);

The method start() contains an exit expression.

        }

        $mode = config('laravoole.base_config.mode');
        if (!$mode) {
            echo "Laravoole needs Swoole or Workerman." . PHP_EOL .
                "You can install Swoole by command:" . PHP_EOL .
                " pecl install swoole" . PHP_EOL .
                "Or you can install Workerman by command:" . PHP_EOL .
                " composer require workerman/workerman" . PHP_EOL;
            exit;

The method start() contains an exit expression.

        }

        if(!class_exists($wrapper = "Laravoole\\Wrapper\\{$mode}Wrapper")) {
            $wrapper = $mode;
        }
        $ref = new ReflectionClass($wrapper);
        $wrapper_file = $ref->getFileName();

        $handler_config = [];
        $params = $wrapper::getParams();
        foreach ($params as $paramName => $default) {
            if (is_int($paramName)) {
                $paramName = $default;
                $default = null;
            }
            $key = $paramName;
            $value = config("laravoole.handler_config.{$key}", function () use ($key, $default) {
                return env("LARAVOOLE_" . strtoupper($key), $default);
            });
            if ($value !== null) {
                if ((is_array($value) || is_object($value)) && is_callable($value)) {
                    $value = $value();
                }
                $handler_config[$paramName] = $value;
            }

        }

        $host = config('laravoole.base_config.host');
        $port = config('laravoole.base_config.port');
        $socket = @stream_socket_server("tcp://{$host}:{$port}");
        if(!$socket) {
            throw new \Exception("Address {$host}:{$port} already in use", 1);
        } else {
            fclose($socket);
        }

        $configs = [
            'host' => $host,
            'port' => $port,
            'wrapper_file' => $wrapper_file,
            'wrapper' => $wrapper,
            'pid_file' => config('laravoole.base_config.pid_file'),
            'root_dir' => base_path(),
            'callbacks' => config('laravoole.base_config.callbacks'),
            // for swoole / workerman
            'handler_config' => $handler_config,
            // for wrapper, like http / fastcgi / websocket
            'wrapper_config' => config('laravoole.wrapper_config'),
            'base_config' => config('laravoole.base_config'),
        ];

        $handle = popen(PHP_BINARY . ' ' . __DIR__ . '/../../src/Entry.php', 'w');
        fwrite($handle, serialize($configs));
        fclose($handle);
    }

    protected function getPid()
    {

        $pid_file = config('laravoole.base_config.pid_file');
        if (file_exists($pid_file)) {
            $pid = file_get_contents($pid_file);
            if (posix_getpgid($pid)) {
                return $pid;
            } else {
                unlink($pid_file);
            }
        }
        return false;
    }

}