Issues in PaintApp.java (master) - Issues in master - gann-cdf/graphics - Measure and Improve Code Quality continuously with Scrutinizer

Issues (88)

src/main/java/projectstems/paint/PaintApp.java (7 issues)

Labels

Severity

package projectstems.paint;

import org.gannacademy.cdf.graphics.Drawable;
import org.gannacademy.cdf.graphics.geom.Rectangle;
import org.gannacademy.cdf.graphics.ui.AppWindow;

import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.MouseMotionListener;
import java.awt.geom.Point2D;

public class PaintApp extends AppWindow implements MouseListener, MouseMotionListener {
  private Rectangle rectButton;

  private Tool active;
  private Point2D start;

  private Drawable current;


  public static void main(String[] args) {
    new PaintApp();
  }

  @Override
  protected void setup() {
    rectButton = new Rectangle(5, 5, 15, 15, getDrawingPanel());
    active = Tool.none;
    getDrawingPanel().addMouseListener(this);
    getDrawingPanel().addMouseMotionListener(this);
  }

  @Override
  public void mouseClicked(MouseEvent e) {
    if (rectButton.contains(e.getPoint())) {
      active = Tool.Rect;
    }
  }

  @Override
  public void mousePressed(MouseEvent e) {
    switch (active) {
      case Rect:

        if (!rectButton.contains(e.getPoint())) {
          start = e.getPoint();
          current = new Rectangle(e.getX(), e.getY(), 1, 1, getDrawingPanel());
        }
      case none:
        // do nothing
    }
  }

  @Override
  public void mouseReleased(MouseEvent e) {
    current = null;
  }

  @Override
  public void mouseEntered(MouseEvent e) {


  }

  @Override
  public void mouseExited(MouseEvent e) {


  }

  @Override
  public void mouseDragged(MouseEvent e) {
    if (active != Tool.none) {
      current.setWidth(Math.abs(e.getX() - start.getX()));
      current.setHeight(Math.abs(e.getY() - start.getY()));
      if (e.getX() < start.getX()) {
        current.setX(e.getX());
      }
      if (e.getY() < start.getY()) {
        current.setY(e.getY());
      }
    }
  }

  @Override
  public void mouseMoved(MouseEvent e) {


  }

  private enum Tool {Rect, none}
}


1			package projectstems.paint;
2
3			import org.gannacademy.cdf.graphics.Drawable;
4			import org.gannacademy.cdf.graphics.geom.Rectangle;
5			import org.gannacademy.cdf.graphics.ui.AppWindow;
6
7			import java.awt.event.MouseEvent;
8			import java.awt.event.MouseListener;
9			import java.awt.event.MouseMotionListener;
10			import java.awt.geom.Point2D;
11
12			public class PaintApp extends AppWindow implements MouseListener, MouseMotionListener {
13			private Rectangle rectButton;
			0 ignored issues – show Bug Best Practice introduced 2021-04-16 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Fields like `rectButton` in a serializable class should either be transient or serializable. Loading history...
14			private Tool active;
15			private Point2D start;
			0 ignored issues – show Bug Best Practice introduced 2021-04-16 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Fields like `start` in a serializable class should either be transient or serializable. Loading history...
16			private Drawable current;
			0 ignored issues – show Bug Best Practice introduced 2021-04-16 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Fields like `current` in a serializable class should either be transient or serializable. Loading history...
17
18			public static void main(String[] args) {
19			new PaintApp();
20			}
21
22			@Override
23			protected void setup() {
24			rectButton = new Rectangle(5, 5, 15, 15, getDrawingPanel());
25			active = Tool.none;
26			getDrawingPanel().addMouseListener(this);
27			getDrawingPanel().addMouseMotionListener(this);
28			}
29
30			@Override
31			public void mouseClicked(MouseEvent e) {
32			if (rectButton.contains(e.getPoint())) {
33			active = Tool.Rect;
34			}
35			}
36
37			@Override
38			public void mousePressed(MouseEvent e) {
39			switch (active) {
40			case Rect:
			0 ignored issues – show Comprehensibility introduced 2018-07-17 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this End this switch case with an unconditional break, return or throw statement. Loading history...
41			if (!rectButton.contains(e.getPoint())) {
42			start = e.getPoint();
43			current = new Rectangle(e.getX(), e.getY(), 1, 1, getDrawingPanel());
44			}
45			case none:
46			// do nothing
47			}
48			}
49
50			@Override
51			public void mouseReleased(MouseEvent e) {
52			current = null;
53			}
54
55			@Override
56			public void mouseEntered(MouseEvent e) {
			0 ignored issues – show Bug introduced 2018-07-17 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this An empty method may be confusing. Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. Loading history...
57
58			}
59
60			@Override
61			public void mouseExited(MouseEvent e) {
			0 ignored issues – show Bug introduced 2018-07-17 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this An empty method may be confusing. Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. Loading history...
62
63			}
64
65			@Override
66			public void mouseDragged(MouseEvent e) {
67			if (active != Tool.none) {
68			current.setWidth(Math.abs(e.getX() - start.getX()));
69			current.setHeight(Math.abs(e.getY() - start.getY()));
70			if (e.getX() < start.getX()) {
71			current.setX(e.getX());
72			}
73			if (e.getY() < start.getY()) {
74			current.setY(e.getY());
75			}
76			}
77			}
78
79			@Override
80			public void mouseMoved(MouseEvent e) {
			0 ignored issues – show Bug introduced 2018-07-17 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this An empty method may be confusing. Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. Loading history...
81
82			}
83
84			private enum Tool {Rect, none}
85			}
86

gann-cdf / graphics

Issues (88)

src/main/java/projectstems/paint/PaintApp.java (7 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like