Issues in Arc.java (master) - Issues in master - gann-cdf/graphics - Measure and Improve Code Quality continuously with Scrutinizer

Issues (88)

java/org/gannacademy/cdf/graphics/geom/Arc.java (1 issue)

Labels

Best Practice 1

Severity

Critical 1

package org.gannacademy.cdf.graphics.geom;

import org.gannacademy.cdf.graphics.Drawable2D;
import org.gannacademy.cdf.graphics.DrawableException;
import org.gannacademy.cdf.graphics.ui.DrawingPanel;

import java.awt.*;
import java.awt.geom.Arc2D;
import java.awt.geom.Rectangle2D;

/**
 * <p>Draw an arc as a section of an ellipse</p>
 *
 * <p><img src="doc-files/Arc.png" alt="Arc diagram"></p>
 *
 * <p>Arcs are sections of ellipses, inscribed within their rectangular bounding box.</p>
 *
 * @author <a href="https://github.com/gann-cdf/graphics/issues" target="_blank">Seth Battis</a>
 */
public class Arc extends Drawable2D {
    /**
     * <p>Construct a new arc</p>
     *
     * <p><img src="doc-files/Arc.png" alt="Diagram of Arc parameters"></p>
     *
     * <p>All window coordinates are measured in pixels, with the X-axis increasing from left to right and the Y-axis
     * increasing from top to bottom. All window coordinates exist in the first quadrant.</p>
     *
     * <p><img src="../doc-files/window-coordinates.png" alt="Diagram of window coordinates"></p>
     *
     * @param x            coordinate of origin
     * @param y            coordinate of origin
     * @param width        in pixels
     * @param height       in pixels
     * @param start        angle in degrees (measured counter-clockwise from 0&deg; (a.k.a. "east")
     * @param extent       angle in degrees of the arc (measured counter-clockwise from {@code start})
     * @param drawingPanel on which to draw
     */
    public Arc(double x, double y, double width, double height, double start, double extent, DrawingPanel drawingPanel) {
        try {
            setShape(new Arc2D.Double(x, y, width, height, start, extent, Arc2D.PIE));
            setDrawingPanel(drawingPanel);
        } catch (DrawableException e) {
            System.err.println(e.getMessage());
            e.printStackTrace();

        }
    }

    /**
     * Underlying {@link Arc2D} geometry
     *
     * @return Underlying {@link Arc2D} geometry
     */
    protected Arc2D getShapeAsArc() {
        return (Arc2D) getShape();
    }

    @Override
    public void setShape(Shape shape) throws DrawableException {
        if (shape instanceof Arc2D) {
            super.setShape(shape);
        } else {
            throw new DrawableException("Attempt to set Arc's underlying shape to a non-Arc2D instance");
        }
    }

    /**
     * Start angle of arc
     *
     * @return Angle measured counter-clockwise in degrees from 0&deg; (East) of start of ellipse segment
     * @see Arc2D#getAngleStart()
     */
    public double getAngleStart() {
        return getShapeAsArc().getAngleStart();
    }

    /**
     * Extent angle of arc
     *
     * @return Angle measured counter-clockwise in degrees from start angle determining extent of arc
     * @see Arc2D#getAngleExtent()
     */
    public double getAngleExtent() {
        return getShapeAsArc().getAngleExtent();
    }

    /**
     * Set start angle of arc
     * 
     * @param start Angle measured counter-clockwise in degrees from 0&deg; (East) of start of ellipse segment
     * @see Arc2D#setAngleStart(double)
     */
    public void setAngleStart(double start) {
        getShapeAsArc().setAngleStart(start);
    }

    /**
     * Set extent angle of arc
     * 
     * @param extent Angle measured counter-clockwise in degrees from start angle determining extent of arc
     * @see Arc2D#setAngleExtent(double)
     */
    public void setAngleExtent(double extent) {
        getShapeAsArc().setAngleExtent(extent);
    }

    @Override
    public double getHeight() {
        return getShapeAsArc().getHeight();
    }

    @Override
    public double getWidth() {
        return getShapeAsArc().getWidth();
    }

    @Override
    public double getX() {
        return getShapeAsArc().getX();
    }

    @Override
    public double getY() {
        return getShapeAsArc().getY();
    }

    @Override
    public Rectangle2D getBounds() {
        return getShapeAsArc().getBounds();
    }
}


1			package org.gannacademy.cdf.graphics.geom;
2
3			import org.gannacademy.cdf.graphics.Drawable2D;
4			import org.gannacademy.cdf.graphics.DrawableException;
5			import org.gannacademy.cdf.graphics.ui.DrawingPanel;
6
7			import java.awt.*;
8			import java.awt.geom.Arc2D;
9			import java.awt.geom.Rectangle2D;
10
11			/**
12			* <p>Draw an arc as a section of an ellipse</p>
13			*
14			* <p><img src="doc-files/Arc.png" alt="Arc diagram"></p>
15			*
16			* <p>Arcs are sections of ellipses, inscribed within their rectangular bounding box.</p>
17			*
18			* @author <a href="https://github.com/gann-cdf/graphics/issues" target="_blank">Seth Battis</a>
19			*/
20			public class Arc extends Drawable2D {
21			/**
22			* <p>Construct a new arc</p>
23			*
24			* <p><img src="doc-files/Arc.png" alt="Diagram of Arc parameters"></p>
25			*
26			* <p>All window coordinates are measured in pixels, with the X-axis increasing from left to right and the Y-axis
27			* increasing from top to bottom. All window coordinates exist in the first quadrant.</p>
28			*
29			* <p><img src="../doc-files/window-coordinates.png" alt="Diagram of window coordinates"></p>
30			*
31			* @param x coordinate of origin
32			* @param y coordinate of origin
33			* @param width in pixels
34			* @param height in pixels
35			* @param start angle in degrees (measured counter-clockwise from 0° (a.k.a. "east")
36			* @param extent angle in degrees of the arc (measured counter-clockwise from {@code start})
37			* @param drawingPanel on which to draw
38			*/
39			public Arc(double x, double y, double width, double height, double start, double extent, DrawingPanel drawingPanel) {
40			try {
41			setShape(new Arc2D.Double(x, y, width, height, start, extent, Arc2D.PIE));
42			setDrawingPanel(drawingPanel);
43			} catch (DrawableException e) {
44			System.err.println(e.getMessage());
45			e.printStackTrace();
			0 ignored issues – show Best Practice introduced 2019-03-08 17:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Throwable.printStackTrace writes to the console which might not be available at runtime. Using a logger is preferred. Loading history...
46			}
47			}
48
49			/**
50			* Underlying {@link Arc2D} geometry
51			*
52			* @return Underlying {@link Arc2D} geometry
53			*/
54			protected Arc2D getShapeAsArc() {
55			return (Arc2D) getShape();
56			}
57
58			@Override
59			public void setShape(Shape shape) throws DrawableException {
60			if (shape instanceof Arc2D) {
61			super.setShape(shape);
62			} else {
63			throw new DrawableException("Attempt to set Arc's underlying shape to a non-Arc2D instance");
64			}
65			}
66
67			/**
68			* Start angle of arc
69			*
70			* @return Angle measured counter-clockwise in degrees from 0° (East) of start of ellipse segment
71			* @see Arc2D#getAngleStart()
72			*/
73			public double getAngleStart() {
74			return getShapeAsArc().getAngleStart();
75			}
76
77			/**
78			* Extent angle of arc
79			*
80			* @return Angle measured counter-clockwise in degrees from start angle determining extent of arc
81			* @see Arc2D#getAngleExtent()
82			*/
83			public double getAngleExtent() {
84			return getShapeAsArc().getAngleExtent();
85			}
86
87			/**
88			* Set start angle of arc
89			*
90			* @param start Angle measured counter-clockwise in degrees from 0° (East) of start of ellipse segment
91			* @see Arc2D#setAngleStart(double)
92			*/
93			public void setAngleStart(double start) {
94			getShapeAsArc().setAngleStart(start);
95			}
96
97			/**
98			* Set extent angle of arc
99			*
100			* @param extent Angle measured counter-clockwise in degrees from start angle determining extent of arc
101			* @see Arc2D#setAngleExtent(double)
102			*/
103			public void setAngleExtent(double extent) {
104			getShapeAsArc().setAngleExtent(extent);
105			}
106
107			@Override
108			public double getHeight() {
109			return getShapeAsArc().getHeight();
110			}
111
112			@Override
113			public double getWidth() {
114			return getShapeAsArc().getWidth();
115			}
116
117			@Override
118			public double getX() {
119			return getShapeAsArc().getX();
120			}
121
122			@Override
123			public double getY() {
124			return getShapeAsArc().getY();
125			}
126
127			@Override
128			public Rectangle2D getBounds() {
129			return getShapeAsArc().getBounds();
130			}
131			}
132

gann-cdf / graphics

Issues (88)

java/org/gannacademy/cdf/graphics/geom/Arc.java (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like