Issues in DrawingApp.java (master) - Issues in master - gann-cdf/graphics - Measure and Improve Code Quality continuously with Scrutinizer

Issues (88)

src/main/java/docs/DrawingApp.java (2 issues)

Labels

Severity

Critical 2

package docs;

import org.gannacademy.cdf.graphics.geom.Ellipse;
import org.gannacademy.cdf.graphics.geom.Rectangle;
import org.gannacademy.cdf.graphics.ui.AppWindow;

import java.awt.*;

/**
 * Build your app as an extension of the AppWindow class (which sets up the window and drawing panel for you)
 */
public class DrawingApp extends AppWindow {

  /**
   * Start your app by instantiating it in your main method
   */
  public static void main(String[] args) {
    new DrawingApp();
  }

  /**
   * Override the setup() method to define your drawing
   */
  @Override
  protected void setup() {
    // draw a blue rectangle with a thick outline
    Rectangle r = new Rectangle(200, 75, 200, 200, getDrawingPanel());

    r.setFillColor(Color.BLUE);

    // draw a red, transparent circle with a thick outline
    Ellipse e = new Ellipse(250, 125, 200, 200, getDrawingPanel());

    e.setFillColor(new Color(255, 100, 100, 200));
  }
}


1			package docs;
2
3			import org.gannacademy.cdf.graphics.geom.Ellipse;
4			import org.gannacademy.cdf.graphics.geom.Rectangle;
5			import org.gannacademy.cdf.graphics.ui.AppWindow;
6
7			import java.awt.*;
8
9			/**
10			* Build your app as an extension of the AppWindow class (which sets up the window and drawing panel for you)
11			*/
12			public class DrawingApp extends AppWindow {
13
14			/**
15			* Start your app by instantiating it in your main method
16			*/
17			public static void main(String[] args) {
18			new DrawingApp();
19			}
20
21			/**
22			* Override the setup() method to define your drawing
23			*/
24			@Override
25			protected void setup() {
26			// draw a blue rectangle with a thick outline
27			Rectangle r = new Rectangle(200, 75, 200, 200, getDrawingPanel());
			0 ignored issues – show Security Bug introduced 2019-03-08 17:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use try-with-resources or close this "Rectangle" in a "finally" clause. You may want to use `try {} ... finally {}` to close the resource or use the (relatively) new try-with-resources capability. Loading history...
28			r.setFillColor(Color.BLUE);
29
30			// draw a red, transparent circle with a thick outline
31			Ellipse e = new Ellipse(250, 125, 200, 200, getDrawingPanel());
			0 ignored issues – show Security Bug introduced 2019-03-08 17:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use try-with-resources or close this "Ellipse" in a "finally" clause. You may want to use `try {} ... finally {}` to close the resource or use the (relatively) new try-with-resources capability. Loading history...
32			e.setFillColor(new Color(255, 100, 100, 200));
33			}
34			}
35

gann-cdf / graphics

Issues (88)

src/main/java/docs/DrawingApp.java (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like