Update - Code Metrics - gamernetwork/yolk-database - Measure and Improve Code Quality continuously with Scrutinizer

Update A
last analyzed 2016-05-18 08:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	27.5 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
c	1
b	0
f	0
lcom	1
cbo	2
dl	22
loc	80
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	table()	0	4	1
A	set()	10	10	2
A	execute()	0	6	1
A	compile()	0	13	1
A	compileSet()	0	17	2
A	compileLimit()	12	12	2

How to fix Duplicated Code

<?php
/*
 * This file is part of Yolk - Gamer Network's PHP Framework.
 *
 * Copyright (c) 2013 Gamer Network Ltd.
 *
 * Distributed under the MIT License, a copy of which is available in the
 * LICENSE file that was bundled with this package, or online at:
 * https://github.com/gamernetwork/yolk-database
 */

namespace yolk\database\query;

use yolk\contracts\database\DatabaseConnection;

/**
 * Generic.
 */
class Update extends BaseQuery {

	protected $table;
	protected $set;

	public function __construct( DatabaseConnection $db ) {
		parent::__construct($db);
		$this->table = '';
		$this->set   = [];
	}

	public function table( $table ) {
		$this->table = $this->quoteIdentifier($table);
		return $this;
	}

	public function set( array $data, $replace = false ) {


		if( $replace )
			$this->set = [];

		$this->set = array_merge($this->set, $data);

		return $this;

	}

	public function execute() {
		return $this->db->execute(
			$this->__toString(),
			$this->params
		);
	}

	protected function compile() {

		return array_merge(
			[
				"UPDATE {$this->table}",
			],
			$this->compileSet(),
			$this->compileWhere(),
			$this->compileOrderBy(),
			$this->compileLimit()
		);

	}

	protected function compileSet() {

		$sql = [];
		$end = -1;

		foreach( $this->set as $column => $value ) {
			$this->bindParam($column, $value);
			$sql[] = "{$column} = :{$column},";
			$end++;
		}

		$sql[0]    = 'SET '. $sql[0];
		$sql[$end] = trim($sql[$end], ',');

		return $sql;

	}

	protected function compileLimit() {


		$sql = [];

		if( $this->limit ) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
			$sql[] = "LIMIT :limit";
			$this->params['limit']  = $this->limit;
		}

		return $sql;

	}

}

// EOF

1		<?php
2		/*
3		* This file is part of Yolk - Gamer Network's PHP Framework.
4		*
5		* Copyright (c) 2013 Gamer Network Ltd.
6		*
7		* Distributed under the MIT License, a copy of which is available in the
8		* LICENSE file that was bundled with this package, or online at:
9		* https://github.com/gamernetwork/yolk-database
10		*/
11
12		namespace yolk\database\query;
13
14		use yolk\contracts\database\DatabaseConnection;
15
16		/**
17		* Generic.
18		*/
19		class Update extends BaseQuery {
20
21		protected $table;
22		protected $set;
23
24		public function __construct( DatabaseConnection $db ) {
25		parent::__construct($db);
26		$this->table = '';
27		$this->set = [];
28		}
29
30		public function table( $table ) {
31		$this->table = $this->quoteIdentifier($table);
32		return $this;
33		}
34
35	View Code Duplication	public function set( array $data, $replace = false ) {
		0 ignored issues – show Duplication introduced 2016-02-25 17:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36
37		if( $replace )
38		$this->set = [];
39
40		$this->set = array_merge($this->set, $data);
41
42		return $this;
43
44		}
45
46		public function execute() {
47		return $this->db->execute(
48		$this->__toString(),
49		$this->params
50		);
51		}
52
53		protected function compile() {
54
55		return array_merge(
56		[
57		"UPDATE {$this->table}",
58		],
59		$this->compileSet(),
60		$this->compileWhere(),
61		$this->compileOrderBy(),
62		$this->compileLimit()
63		);
64
65		}
66
67		protected function compileSet() {
68
69		$sql = [];
70		$end = -1;
71
72		foreach( $this->set as $column => $value ) {
73		$this->bindParam($column, $value);
74		$sql[] = "{$column} = :{$column},";
75		$end++;
76		}
77
78		$sql[0] = 'SET '. $sql[0];
79		$sql[$end] = trim($sql[$end], ',');
80
81		return $sql;
82
83		}
84
85	View Code Duplication	protected function compileLimit() {
		0 ignored issues – show Duplication introduced 2016-02-25 17:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86
87		$sql = [];
88
89		if( $this->limit ) {
		0 ignored issues – show Bug Best Practice introduced 2016-02-25 17:13 UTC by Report Bug Copy Issue Report The expression `$this->limit` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
90		$sql[] = "LIMIT :limit";
91		$this->params['limit'] = $this->limit;
92		}
93
94		return $sql;
95
96		}
97
98		}
99
100		// EOF

gamernetwork / yolk-database

Update A last analyzed 2016-05-18 08:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Update A
last analyzed 2016-05-18 08:44 UTC