InMemorySettingRepository::findWithinSection() - Code Metrics - Inspection of "Fix configuration for scrutinizer test coverage" - galileo/GalileoSettingBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Kamil

created 2017-04-06 08:22 UTC

InMemorySettingRepository::findWithinSection() A

↳ Parent: InMemorySettingRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	13
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	2
crap	6

<?php

namespace Galileo\SettingBundle\Lib\Infrastructure\Internal;

use Galileo\SettingBundle\Lib\Model\Setting;
use Galileo\SettingBundle\Lib\Model\SettingRepositoryInterface;
use Galileo\SettingBundle\Lib\Model\ValueObject\Key;
use Galileo\SettingBundle\Lib\Model\ValueObject\Section;
use Galileo\SettingBundle\Lib\Model\ValueObject\Value;

class InMemorySettingRepository implements SettingRepositoryInterface
{
    private $values = [];


    public function __construct($settingPlainRows)
    {
        foreach ($settingPlainRows as $key) {
            $name = $key[0];
            $value = $key[1];
            $section = $key[2];
            $this->set($name, $value, $section);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function findWithinSection(Key $settingKey, Section $section)
    {
        $key = $settingKey->key();
        $sectionName = $section->name();

        if (!isset($this->values[$key][$sectionName])) {
            return null;
        }

        return Setting::issue(
            $settingKey,
            $this->values[$key][$sectionName],
            new Section($sectionName)
        );
    }

    /**
     * {@inheritdoc}
     */
    public function save(Setting $setting)
    {
        $this->set($setting->name(), $setting->value(), $setting->section());
    }

    /**
     * @param $name
     * @param $value
     * @param $section
     */
    private function set($name, $value, $section)
    {
        $section = $section ? $section : Section::EMPTY_SECTION;

        $this->values[$name][$section] = new Value($value);
    }
}


1			<?php
2
3			namespace Galileo\SettingBundle\Lib\Infrastructure\Internal;
4
5			use Galileo\SettingBundle\Lib\Model\Setting;
6			use Galileo\SettingBundle\Lib\Model\SettingRepositoryInterface;
7			use Galileo\SettingBundle\Lib\Model\ValueObject\Key;
8			use Galileo\SettingBundle\Lib\Model\ValueObject\Section;
9			use Galileo\SettingBundle\Lib\Model\ValueObject\Value;
10
11			class InMemorySettingRepository implements SettingRepositoryInterface
12			{
13			private $values = [];
14
15
16			public function __construct($settingPlainRows)
17			{
18			foreach ($settingPlainRows as $key) {
19			$name = $key[0];
20			$value = $key[1];
21			$section = $key[2];
22			$this->set($name, $value, $section);
23			}
24			}
25
26			/**
27			* {@inheritdoc}
28			*/
29			public function findWithinSection(Key $settingKey, Section $section)
30			{
31			$key = $settingKey->key();
32			$sectionName = $section->name();
33
34			if (!isset($this->values[$key][$sectionName])) {
35			return null;
36			}
37
38			return Setting::issue(
39			$settingKey,
40			$this->values[$key][$sectionName],
41			new Section($sectionName)
42			);
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function save(Setting $setting)
49			{
50			$this->set($setting->name(), $setting->value(), $setting->section());
51			}
52
53			/**
54			* @param $name
55			* @param $value
56			* @param $section
57			*/
58			private function set($name, $value, $section)
59			{
60			$section = $section ? $section : Section::EMPTY_SECTION;
61
62			$this->values[$name][$section] = new Value($value);
63			}
64			}
65

galileo / GalileoSettingBundle

Pull Request — master (#10)

InMemorySettingRepository::findWithinSection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like