ClassResolverFactory::createCache() - Code Metrics - Inspection of "Refactor extracting ClassResolverCache class" - gacela-project/gacela - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/improve-file-cache ( 6742d2 )

by Chema

created 2022-11-06 16:48 UTC

ClassResolverFactory::createCache() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	13
ccs	7
cts	7
cp	1
crap	2
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\Framework\ClassResolver;

use Gacela\Framework\Bootstrap\SetupGacelaInterface;
use Gacela\Framework\ClassResolver\Cache\CacheInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinder;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinderInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidator;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidatorInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithModulePrefix;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithoutModulePrefix;

final class ClassResolverFactory
{
    private SetupGacelaInterface $setupGacela;

    public function __construct(SetupGacelaInterface $setupGacela)
    {
        $this->setupGacela = $setupGacela;
    }

    public function createClassNameFinder(): ClassNameFinderInterface
    {
        return new ClassNameFinder(
            $this->createClassValidator(),
            $this->createFinderRules(),
            $this->getCache(),
            $this->getProjectNamespaces()
        );
    }

    private function createClassValidator(): ClassValidatorInterface
    {
        return new ClassValidator();
    }

    /**
     * @return list<FinderRuleInterface>
     */
    private function createFinderRules(): array
    {
        return [

            new FinderRuleWithModulePrefix(),
            new FinderRuleWithoutModulePrefix(),
        ];
    }

    private function getCache(): CacheInterface
    {
        return ClassResolverCache::getCache();
    }

    /**
     * @return list<string>
     */
    private function getProjectNamespaces(): array
    {
        return $this->setupGacela->getProjectNamespaces();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Framework\ClassResolver;
6
7		use Gacela\Framework\Bootstrap\SetupGacelaInterface;
8		use Gacela\Framework\ClassResolver\Cache\CacheInterface;
9		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinder;
10		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinderInterface;
11		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidator;
12		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidatorInterface;
13		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleInterface;
14		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithModulePrefix;
15		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithoutModulePrefix;
16
17		final class ClassResolverFactory
18		{
19		private SetupGacelaInterface $setupGacela;
20
21	18	public function __construct(SetupGacelaInterface $setupGacela)
22		{
23	18	$this->setupGacela = $setupGacela;
24		}
25
26	18	public function createClassNameFinder(): ClassNameFinderInterface
27		{
28	18	return new ClassNameFinder(
29	18	$this->createClassValidator(),
30	18	$this->createFinderRules(),
31	18	$this->getCache(),
32	18	$this->getProjectNamespaces()
33		);
34		}
35
36	18	private function createClassValidator(): ClassValidatorInterface
37		{
38	18	return new ClassValidator();
39		}
40
41		/**
42		* @return list<FinderRuleInterface>
43		*/
44	18	private function createFinderRules(): array
45		{
46		return [
		0 ignored issues – show Bug Best Practice introduced 2022-02-12 21:12 UTC by Report Bug Copy Issue Report The expression `return array(new Gacela\...eWithoutModulePrefix())` returns the type `array<integer,Gacela\Fra...uleWithoutModulePrefix>` which is incompatible with the documented return type `Gacela\Framework\ClassResolver\list`. Loading history...
47	18	new FinderRuleWithModulePrefix(),
48	18	new FinderRuleWithoutModulePrefix(),
49		];
50		}
51
52	18	private function getCache(): CacheInterface
53		{
54	18	return ClassResolverCache::getCache();
55		}
56
57		/**
58		* @return list<string>
59		*/
60	18	private function getProjectNamespaces(): array
61		{
62	18	return $this->setupGacela->getProjectNamespaces();
63		}
64		}
65

gacela-project / gacela

Push — feature/improve-file-cache ( 6742d2 )

ClassResolverFactory::createCache() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like