Gacela\Framework\Gacela

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

81.25%

Importance

Changes	5
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	bootstrap()	0	20	3
A	normalizeSetup()	0	11	3

<?php

declare(strict_types=1);

namespace Gacela\Framework;

use Gacela\Framework\Bootstrap\GacelaConfig;
use Gacela\Framework\Bootstrap\SetupGacela;
use Gacela\Framework\Bootstrap\SetupGacelaInterface;
use Gacela\Framework\ClassResolver\AbstractClassResolver;
use Gacela\Framework\Config\Config;

use function is_callable;

final class Gacela
{
    /**
     * Define the entry point of Gacela.
     *
     * @param null|SetupGacelaInterface|callable(GacelaConfig):void $configFn SetupGacelaInterface is deprecated
     */
    public static function bootstrap(string $appRootDir, $configFn = null): void
    {
        if ($configFn instanceof SetupGacelaInterface) {
            trigger_deprecation(
                'gacela-project/gacela',
                '0.18',
                '`SetupGacelaInterface` is deprecated. Use `callable(GacelaConfig)` instead.'
            );
        }

        $setup = self::normalizeSetup($configFn);

        if (!$setup->isClassResolverCached()) {
            AbstractClassResolver::resetCache();
        }

        Config::getInstance()
            ->setAppRootDir($appRootDir)
            ->setSetup($setup)
            ->init();
    }

    /**
     * @param null|SetupGacelaInterface|callable(GacelaConfig):void $configFn
     */
    private static function normalizeSetup($configFn): SetupGacelaInterface
    {
        if ($configFn === null) {
            return new SetupGacela();
        }

        if (is_callable($configFn)) {
            return SetupGacela::fromCallable($configFn);

It seems like $configFn can also be of type Gacela\Framework\Bootstrap\SetupGacelaInterface; however, parameter $setupGacelaFileFn of Gacela\Framework\Bootstrap\SetupGacela::fromCallable() does only seem to accept callable, maybe add an additional type check?

        }

        return $configFn;

The expression return $configFn could return the type callable which is incompatible with the type-hinted return Gacela\Framework\Bootstrap\SetupGacelaInterface. Consider adding an additional type-check to rule them out.

    }
}