EnforceModuleBoundariesForMethodCallRule::processNode()

Complexity

Conditions	5
Paths	5

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function processNode(Node $node, Scope $scope): array
    {
        // 1. Is the object we are calling a facade? If yes then exit.
        $type = $scope->getType($node->var);

Accessing var on the interface PhpParser\Node suggest that you code against a concrete implementation. How about adding an instanceof check?

        $facadeObjectType = new ObjectType(AbstractFacade::class);
        if ($facadeObjectType->isSuperTypeOf($type)->yes()) {
            return [];
        }

        // 2. Is this a call to code in the same module. If yes then exit.
        // 3. Or is this a call to code in an excluded namespace. If yes then exit.
        $namespaceOfCallingCode = $scope->getNamespace();
        foreach ($type->getReferencedClasses() as $referencedClass) {
            if ($this->moduleComparator->isSameModule($namespaceOfCallingCode, $referencedClass)) {
                return [];
            }

            if ($this->excludedNamespaceChecker->isExcludedNamespace($referencedClass)) {
                return [];
            }
        }

        // 4. Raise an error.
        return [
            RuleErrorBuilder::message('Method call to a different module is not allowed.')->build(),
        ];