Gacela\Framework\Gacela::normalizeSetup()

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

0

<?php
    private static function normalizeSetup($configFn): SetupGacelaInterface
    {
        if ($configFn === null) {
            return new SetupGacela();
        }

        if (is_callable($configFn)) {
            return SetupGacela::fromCallable($configFn);

It seems like $configFn can also be of type Gacela\Framework\Bootstrap\SetupGacelaInterface; however, parameter $setupGacelaFileFn of Gacela\Framework\Bootstrap\SetupGacela::fromCallable() does only seem to accept callable, maybe add an additional type check?

        }

        return $configFn;

The expression return $configFn could return the type callable which is incompatible with the type-hinted return Gacela\Framework\Bootstrap\SetupGacelaInterface. Consider adding an additional type-check to rule them out.

    }