ClassResolverFactory::isProjectCacheEnabled() - Code Metrics - Inspection of "Fixing setCacheEnable behaviour" - gacela-project/gacela - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#186)

by Jesús

created 2022-07-23 16:15 UTC

ClassResolverFactory::isProjectCacheEnabled() A

↳ Parent: ClassResolverFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\Framework\ClassResolver;

use Gacela\Framework\Bootstrap\SetupGacelaInterface;
use Gacela\Framework\ClassResolver\Cache\GacelaCache;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinder;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinderInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidator;
use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidatorInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleInterface;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithModulePrefix;
use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithoutModulePrefix;
use Gacela\Framework\Config\Config;

final class ClassResolverFactory
{
    private GacelaCache $gacelaCache;
    private SetupGacelaInterface $setupGacela;

    public function __construct(GacelaCache $gacelaCache, SetupGacelaInterface $setupGacela)
    {
        $this->gacelaCache = $gacelaCache;
        $this->setupGacela = $setupGacela;
    }

    public function createClassNameFinder(): ClassNameFinderInterface
    {
        return new ClassNameFinder(
            $this->createClassValidator(),
            $this->createFinderRules(),
            $this->createClassNameCache(),
            $this->getProjectNamespaces()
        );
    }

    public function createClassNameCache(): ClassNameCacheInterface
    {
        if (!$this->gacelaCache->isProjectCacheEnabled()) {
            return new InMemoryCache(ClassNameCache::class);
        }

        return new ClassNameCache(
            Config::getInstance()->getCacheDir(),
        );
    }

    private function createClassValidator(): ClassValidatorInterface
    {
        return new ClassValidator();
    }

    /**
     * @return list<FinderRuleInterface>
     */
    private function createFinderRules(): array
    {
        return [

            new FinderRuleWithModulePrefix(),
            new FinderRuleWithoutModulePrefix(),
        ];
    }

    /**
     * @return list<string>
     */
    private function getProjectNamespaces(): array
    {
        return $this->setupGacela->getProjectNamespaces();

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Framework\ClassResolver;
6
7		use Gacela\Framework\Bootstrap\SetupGacelaInterface;
8		use Gacela\Framework\ClassResolver\Cache\GacelaCache;
9		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinder;
10		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassNameFinderInterface;
11		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidator;
12		use Gacela\Framework\ClassResolver\ClassNameFinder\ClassValidatorInterface;
13		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleInterface;
14		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithModulePrefix;
15		use Gacela\Framework\ClassResolver\ClassNameFinder\Rule\FinderRuleWithoutModulePrefix;
16		use Gacela\Framework\Config\Config;
17
18		final class ClassResolverFactory
19		{
20		private GacelaCache $gacelaCache;
21		private SetupGacelaInterface $setupGacela;
22
23	28	public function __construct(GacelaCache $gacelaCache, SetupGacelaInterface $setupGacela)
24		{
25	28	$this->gacelaCache = $gacelaCache;
26	28	$this->setupGacela = $setupGacela;
27		}
28
29	28	public function createClassNameFinder(): ClassNameFinderInterface
30		{
31	28	return new ClassNameFinder(
32	28	$this->createClassValidator(),
33	28	$this->createFinderRules(),
34	28	$this->createClassNameCache(),
35	28	$this->getProjectNamespaces()
36		);
37		}
38
39	28	public function createClassNameCache(): ClassNameCacheInterface
40		{
41	28	if (!$this->gacelaCache->isProjectCacheEnabled()) {
42	4	return new InMemoryCache(ClassNameCache::class);
43		}
44
45	24	return new ClassNameCache(
46	24	Config::getInstance()->getCacheDir(),
47		);
48		}
49
50	28	private function createClassValidator(): ClassValidatorInterface
51		{
52	28	return new ClassValidator();
53		}
54
55		/**
56		* @return list<FinderRuleInterface>
57		*/
58	28	private function createFinderRules(): array
59		{
60		return [
		0 ignored issues – show Bug Best Practice introduced 2022-02-12 21:12 UTC by Report Bug Copy Issue Report The expression `return array(new Gacela\...eWithoutModulePrefix())` returns the type `array<integer,Gacela\Fra...uleWithoutModulePrefix>` which is incompatible with the documented return type `Gacela\Framework\ClassResolver\list`. Loading history...
61	28	new FinderRuleWithModulePrefix(),
62	28	new FinderRuleWithoutModulePrefix(),
63		];
64		}
65
66		/**
67		* @return list<string>
68		*/
69	28	private function getProjectNamespaces(): array
70		{
71	28	return $this->setupGacela->getProjectNamespaces();
		1 ignored issue – show Bug Best Practice introduced 2022-06-30 19:54 UTC by Report Bug Copy Issue Report The expression `return $this->setupGacela->getProjectNamespaces()` returns the type `array` which is incompatible with the documented return type `Gacela\Framework\ClassResolver\list`. Loading history...
72		}
73		}
74

gacela-project / gacela

Pull Request — master (#186)

ClassResolverFactory::isProjectCacheEnabled() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like