Gacela\Framework\ClassResolver\DependencyResolver\DependencyResolver

Complexity

Total Complexity

15

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Test Coverage

Coverage

89.74%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	resolveDependencies()	0	19	4
B	resolveDependenciesRecursively()	0	50	10

<?php

declare(strict_types=1);

namespace Gacela\Framework\ClassResolver\DependencyResolver;

use Gacela\Framework\Config\GacelaFileConfig\GacelaConfigFile;
use ReflectionClass;
use ReflectionNamedType;
use ReflectionParameter;
use RuntimeException;
use function is_callable;

final class DependencyResolver
{
    private GacelaConfigFile $gacelaConfigFile;

    public function __construct(GacelaConfigFile $gacelaConfigFile)
    {
        $this->gacelaConfigFile = $gacelaConfigFile;
    }

    /**
     * @param class-string $resolvedClassName

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

     *
     * @return list<mixed>
     */
    public function resolveDependencies(string $resolvedClassName): array
    {
        $reflection = new ReflectionClass($resolvedClassName);
        $constructor = $reflection->getConstructor();
        if (!$constructor) {
            return [];

The expression return array() returns the type array which is incompatible with the documented return type Gacela\Framework\ClassResolver\DependencyResolver\list.

        }

        /** @var list<mixed> $dependencies */
        $dependencies = [];
        foreach ($constructor->getParameters() as $parameter) {
            $paramType = $parameter->getType();
            if ($paramType) {
                /** @psalm-suppress MixedAssignment */
                $dependencies[] = $this->resolveDependenciesRecursively($parameter);
            }
        }

        return $dependencies;

The expression return $dependencies returns the type Gacela\Framework\ClassResolver\DependencyResolver\list which is incompatible with the type-hinted return array.

    }

    /**
     * @return mixed
     */
    private function resolveDependenciesRecursively(ReflectionParameter $parameter)
    {
        if (!$parameter->hasType()) {
            throw new RuntimeException("No parameter type for '{$parameter->getName()}'");
        }

        /** @var ReflectionNamedType $paramType */
        $paramType = $parameter->getType();
        $paramTypeName = $paramType->getName();
        if (!class_exists($paramTypeName) && !interface_exists($paramTypeName)) {
            return $parameter->getDefaultValue();
        }

        $reflection = new ReflectionClass($paramTypeName);

        // If it's an interface we need to figure out which concrete class do we want to use.
        if ($reflection->isInterface()) {
            $mappingInterfaces = $this->gacelaConfigFile->getMappingInterfaces();
            $concreteClass = $mappingInterfaces[$reflection->getName()] ?? '';
            // a callable will be a way to bypass the instantiation and instead
            // use the result from the callable that was defined in the gacela config file.
            if (is_callable($concreteClass)) {
                return $concreteClass();
            }
            // an Exception will be thrown if there is no concrete class found for the interface.
            if (empty($concreteClass)) {
                throw new DependencyResolverNotFoundException($reflection->getName());
            }
            // finally, override the $reflection (the interface) by the concrete resolved class.
            /** @var class-string $concreteClass */
            $reflection = new ReflectionClass($concreteClass);
        }

        $constructor = $reflection->getConstructor();
        if (!$constructor) {
            return $reflection->newInstance();
        }

        /** @var list<mixed> $innerDependencies */
        $innerDependencies = [];

        foreach ($constructor->getParameters() as $constructorParameter) {
            $paramType = $constructorParameter->getType();
            if ($paramType) {
                /** @psalm-suppress MixedAssignment */
                $innerDependencies[] = $this->resolveDependenciesRecursively($constructorParameter);
            }
        }

        return $reflection->newInstanceArgs($innerDependencies);

$innerDependencies of type Gacela\Framework\ClassResolver\DependencyResolver\list is incompatible with the type array expected by parameter $args of ReflectionClass::newInstanceArgs().

    }
}