Locator::get() - Code Metrics - Inspection of "Locator should not resolve interfaces magically" - gacela-project/gacela - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#243)

by Jesús

created 2022-12-05 08:54 UTC

Locator::get() A

↳ Parent: Locator

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	1
dl	0
loc	16
ccs	8
cts	8
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\Framework\Container;

use Gacela\Framework\ClassResolver\GlobalInstance\AnonymousGlobal;

final class Locator
{
    private static ?Locator $instance = null;

    /** @var array<string, mixed> */
    private array $instanceCache = [];

    private function __construct()
    {
    }

    /**
     * @codeCoverageIgnore
     */
    private function __clone()
    {
    }

    public static function getInstance(): self
    {
        if (self::$instance === null) {
            self::$instance = new self();
        }

        return self::$instance;

    }

    public static function resetInstance(): void
    {
        self::$instance = null;
    }

    /**
     * @template T
     *
     * @param class-string<T> $className

     *
     * @return T|null
     */
    public function get(string $className)
    {
        if (isset($this->instanceCache[$className])) {
            /** @var T $instance */
            $instance = $this->instanceCache[$className];

            return $instance;
        }

        $locatedInstance = AnonymousGlobal::getByClassName($className)
            ?? $this->newInstance($className);

        /** @psalm-suppress MixedAssignment */
        $this->instanceCache[$className] = $locatedInstance;

        return $locatedInstance;
    }

    /**
     * @template T
     *
     * @param class-string<T> $className

     *
     * @return T|null
     */
    private function newInstance(string $className)
    {
        if (class_exists($className)) {
            /** @psalm-suppress MixedMethodCall */
            return new $className();
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Framework\Container;
6
7		use Gacela\Framework\ClassResolver\GlobalInstance\AnonymousGlobal;
8
9		final class Locator
10		{
11		private static ?Locator $instance = null;
12
13		/** @var array<string, mixed> */
14		private array $instanceCache = [];
15
16	3	private function __construct()
17		{
18	3	}
19
20		/**
21		* @codeCoverageIgnore
22		*/
23		private function __clone()
24		{
25		}
26
27	3	public static function getInstance(): self
28		{
29	3	if (self::$instance === null) {
30	3	self::$instance = new self();
31		}
32
33	3	return self::$instance;
		0 ignored issues – show Bug Best Practice introduced 2022-03-26 14:55 UTC by Report Bug Copy Issue Report The expression `return self::instance` could return the type `null` which is incompatible with the type-hinted return `Gacela\Framework\Container\Locator`. Consider adding an additional type-check to rule them out. Loading history...
34		}
35
36	2	public static function resetInstance(): void
37		{
38	2	self::$instance = null;
39		}
40
41		/**
42		* @template T
43		*
44		* @param class-string<T> $className
		0 ignored issues – show Documentation Bug introduced 2021-10-31 19:37 UTC by Report Bug Copy Issue Report The doc comment `class-string<T>` at position `0` could not be parsed: Unknown type name 'class-string' at position 0 in class-string<T>. Loading history...
45		*
46		* @return T\|null
47		*/
48	3	public function get(string $className)
49		{
50	3	if (isset($this->instanceCache[$className])) {
51		/** @var T $instance */
52	1	$instance = $this->instanceCache[$className];
53
54	1	return $instance;
55		}
56
57	3	$locatedInstance = AnonymousGlobal::getByClassName($className)
58	3	?? $this->newInstance($className);
59
60		/** @psalm-suppress MixedAssignment */
61	3	$this->instanceCache[$className] = $locatedInstance;
62
63	3	return $locatedInstance;
64		}
65
66		/**
67		* @template T
68		*
69		* @param class-string<T> $className
		0 ignored issues – show Documentation Bug introduced 2021-10-31 19:37 UTC by Report Bug Copy Issue Report The doc comment `class-string<T>` at position `0` could not be parsed: Unknown type name 'class-string' at position 0 in class-string<T>. Loading history...
70		*
71		* @return T\|null
72		*/
73	3	private function newInstance(string $className)
74		{
75	3	if (class_exists($className)) {
76		/** @psalm-suppress MixedMethodCall */
77	2	return new $className();
78		}
79
80	1	return null;
81		}
82		}
83

gacela-project / gacela

Pull Request — master (#243)

Locator::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like