GacelaProfiler::isEnabled() - Code Metrics - Inspection of "Refactor GacelaProfiler class" - gacela-project/gacela - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/gacela-file-cache ( a1109a...a7fc9c )

by Jesús

created 2022-10-16 17:11 UTC

GacelaProfiler::isEnabled() A

↳ Parent: GacelaProfiler

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	5
c	1
b	0
f	0
dl	0
loc	9
rs	10
ccs	6
cts	6
cp	1
cc	3
nc	3
nop	0
crap	3

<?php

declare(strict_types=1);

namespace Gacela\Framework\ClassResolver\Profiler;

use Gacela\Framework\Config\ConfigInterface;

final class GacelaProfiler
{
    public const KEY_ENABLED = 'gacela-profiler-enabled';
    public const DEFAULT_ENABLED_VALUE = false;
    public const DEFAULT_DIRECTORY_VALUE = '/.gacela/profiler';

    private static ?bool $isEnabled = null;

    private ConfigInterface $config;

    public function __construct(ConfigInterface $config)
    {
        $this->config = $config;
    }

    /**
     * @internal
     */
    public static function resetCache(): void
    {
        self::$isEnabled = null;
    }

    public function isEnabled(): bool
    {
        if (self::$isEnabled === null) {
            self::$isEnabled = $this->config->hasKey(self::KEY_ENABLED)
                ? (bool)$this->config->get(self::KEY_ENABLED)
                : $this->config->getSetupGacela()->isProfilerEnabled();
        }

        return self::$isEnabled;

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Framework\ClassResolver\Profiler;
6
7		use Gacela\Framework\Config\ConfigInterface;
8
9		final class GacelaProfiler
10		{
11		public const KEY_ENABLED = 'gacela-profiler-enabled';
12		public const DEFAULT_ENABLED_VALUE = false;
13		public const DEFAULT_DIRECTORY_VALUE = '/.gacela/profiler';
14
15		private static ?bool $isEnabled = null;
16
17		private ConfigInterface $config;
18
19	51	public function __construct(ConfigInterface $config)
20		{
21	51	$this->config = $config;
22		}
23
24		/**
25		* @internal
26		*/
27	14	public static function resetCache(): void
28		{
29	14	self::$isEnabled = null;
30		}
31
32	51	public function isEnabled(): bool
33		{
34	51	if (self::$isEnabled === null) {
35	14	self::$isEnabled = $this->config->hasKey(self::KEY_ENABLED)
36	2	? (bool)$this->config->get(self::KEY_ENABLED)
37	12	: $this->config->getSetupGacela()->isProfilerEnabled();
38		}
39
40	51	return self::$isEnabled;
		1 ignored issue – show Bug Best Practice introduced 2022-10-16 17:15 UTC by Report Bug Copy Issue Report The expression `return self::isEnabled` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
41		}
42		}
43

gacela-project / gacela

Push — feature/gacela-file-cache ( a1109a...a7fc9c )

GacelaProfiler::isEnabled() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like