AppModuleCreator::moduleName() - Code Metrics - Inspection of "Move creation of AppModule to a new class AppModul..." - gacela-project/gacela - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — improve-list-modules-output ( e63970 )

by Chema

created 2023-06-12 21:10 UTC

AppModuleCreator::moduleName() A

↳ Parent: AppModuleCreator

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
ccs	4
cts	4
cp	1
crap	1
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\Console\Domain\AllAppModules;

use Gacela\Framework\ClassResolver\Config\ConfigNotFoundException;
use Gacela\Framework\ClassResolver\Config\ConfigResolver;
use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderNotFoundException;
use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderResolver;
use Gacela\Framework\ClassResolver\Factory\FactoryNotFoundException;
use Gacela\Framework\ClassResolver\Factory\FactoryResolver;
use ReflectionClass;

final class AppModuleCreator
{
    /**
     * @param class-string $facadeClass
     */
    public function fromClass(string $facadeClass): AppModule
    {
        return new AppModule(
            $this->moduleName($facadeClass),
            $facadeClass,
            $this->findFactory($facadeClass),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->findConfig($facadeClass),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->findDependencyProvider($facadeClass),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        );
    }

    /**
     * @param class-string $facadeClass
     */
    private function moduleName(string $facadeClass): string
    {
        $parts = explode('\\', $facadeClass);
        array_pop($parts);

        return (string)end($parts);
    }

    /**
     * @param class-string $facadeClass
     */
    private function findFactory(string $facadeClass): ?string
    {
        try {
            $resolver = (new FactoryResolver())->resolve($facadeClass);

            if ((new ReflectionClass($resolver))->isAnonymous()) {
                throw new FactoryNotFoundException($facadeClass);
            }

            return $resolver::class;
        } catch (FactoryNotFoundException $e) {
            return null;
        }
    }

    /**
     * @param class-string $facadeClass
     */
    private function findConfig(string $facadeClass): ?string
    {
        try {
            $resolver = (new ConfigResolver())->resolve($facadeClass);

            if ((new ReflectionClass($resolver))->isAnonymous()) {
                throw new ConfigNotFoundException($facadeClass);
            }

            return $resolver::class;
        } catch (ConfigNotFoundException $e) {
            return null;
        }
    }

    /**
     * @param class-string $facadeClass
     */
    private function findDependencyProvider(string $facadeClass): ?string
    {
        try {
            $resolver = (new DependencyProviderResolver())->resolve($facadeClass);

            if ((new ReflectionClass($resolver))->isAnonymous()) {
                throw new DependencyProviderNotFoundException($resolver);
            }
            return $resolver::class;
        } catch (DependencyProviderNotFoundException $e) {
            return null;
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Console\Domain\AllAppModules;
6
7		use Gacela\Framework\ClassResolver\Config\ConfigNotFoundException;
8		use Gacela\Framework\ClassResolver\Config\ConfigResolver;
9		use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderNotFoundException;
10		use Gacela\Framework\ClassResolver\DependencyProvider\DependencyProviderResolver;
11		use Gacela\Framework\ClassResolver\Factory\FactoryNotFoundException;
12		use Gacela\Framework\ClassResolver\Factory\FactoryResolver;
13		use ReflectionClass;
14
15		final class AppModuleCreator
16		{
17		/**
18		* @param class-string $facadeClass
19		*/
20	7	public function fromClass(string $facadeClass): AppModule
21		{
22	7	return new AppModule(
23	7	$this->moduleName($facadeClass),
24	7	$facadeClass,
25	7	$this->findFactory($facadeClass),
		0 ignored issues – show Bug introduced 2023-06-12 21:14 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->findFactory($facadeClass)` targeting `Gacela\Console\Domain\Al...eCreator::findFactory()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
26	7	$this->findConfig($facadeClass),
		0 ignored issues – show Bug introduced 2023-06-12 21:14 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->findConfig($facadeClass)` targeting `Gacela\Console\Domain\Al...leCreator::findConfig()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27	7	$this->findDependencyProvider($facadeClass),
		0 ignored issues – show Bug introduced 2023-06-12 21:14 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->findDependencyProvider($facadeClass)` targeting `Gacela\Console\Domain\Al...indDependencyProvider()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
28	7	);
29		}
30
31		/**
32		* @param class-string $facadeClass
33		*/
34	7	private function moduleName(string $facadeClass): string
35		{
36	7	$parts = explode('\\', $facadeClass);
37	7	array_pop($parts);
38
39	7	return (string)end($parts);
40		}
41
42		/**
43		* @param class-string $facadeClass
44		*/
45	7	private function findFactory(string $facadeClass): ?string
46		{
47		try {
48	7	$resolver = (new FactoryResolver())->resolve($facadeClass);
49
50	7	if ((new ReflectionClass($resolver))->isAnonymous()) {
51	3	throw new FactoryNotFoundException($facadeClass);
52		}
53
54	6	return $resolver::class;
55	3	} catch (FactoryNotFoundException $e) {
56	3	return null;
57		}
58		}
59
60		/**
61		* @param class-string $facadeClass
62		*/
63	7	private function findConfig(string $facadeClass): ?string
64		{
65		try {
66	7	$resolver = (new ConfigResolver())->resolve($facadeClass);
67
68	7	if ((new ReflectionClass($resolver))->isAnonymous()) {
69	5	throw new ConfigNotFoundException($facadeClass);
70		}
71
72	4	return $resolver::class;
73	5	} catch (ConfigNotFoundException $e) {
74	5	return null;
75		}
76		}
77
78		/**
79		* @param class-string $facadeClass
80		*/
81	7	private function findDependencyProvider(string $facadeClass): ?string
82		{
83		try {
84	7	$resolver = (new DependencyProviderResolver())->resolve($facadeClass);
85
86	6	if ((new ReflectionClass($resolver))->isAnonymous()) {
87		throw new DependencyProviderNotFoundException($resolver);
88		}
89	6	return $resolver::class;
90	3	} catch (DependencyProviderNotFoundException $e) {
91	3	return null;
92		}
93		}
94		}
95

gacela-project / gacela

Push — improve-list-modules-output ( e63970 )

AppModuleCreator::moduleName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like