InstanceCreator::createByClassName() - Code Metrics - Inspection of "Add static instance create" - gacela-project/container - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#2)

by Chema

created 2023-04-20 19:29 UTC

InstanceCreator::createByClassName() A

↳ Parent: InstanceCreator

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	14
ccs	7
cts	8
cp	0.875
crap	3.0175
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\Resolver;

final class InstanceCreator
{
    private ?DependencyResolver $dependencyResolver = null;

    /** @var array<class-string,list<mixed>> */
    private array $cachedDependencies = [];

    /**
     * @param array<class-string,class-string|callable|object> $mappingInterfaces
     */
    public function __construct(
        private array $mappingInterfaces = [],
    ) {
    }

    /**
     * @param class-string $className
     */
    public static function create(string $className): ?object
    {
        return (new self())->createByClassName($className);
    }

    /**
     * @param class-string $className
     */
    public function createByClassName(string $className): ?object
    {
        if (class_exists($className)) {
            if (!isset($this->cachedDependencies[$className])) {
                $this->cachedDependencies[$className] = $this
                    ->getDependencyResolver()
                    ->resolveDependencies($className);
            }

            /** @psalm-suppress MixedMethodCall */
            return new $className(...$this->cachedDependencies[$className]);
        }

        return null;
    }

    private function getDependencyResolver(): DependencyResolver
    {
        if ($this->dependencyResolver === null) {
            $this->dependencyResolver = new DependencyResolver(
                $this->mappingInterfaces,
            );
        }

        return $this->dependencyResolver;

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\Resolver;
6
7		final class InstanceCreator
8		{
9		private ?DependencyResolver $dependencyResolver = null;
10
11		/** @var array<class-string,list<mixed>> */
12		private array $cachedDependencies = [];
13
14		/**
15		* @param array<class-string,class-string\|callable\|object> $mappingInterfaces
16		*/
17	6	public function __construct(
18		private array $mappingInterfaces = [],
19		) {
20	6	}
21
22		/**
23		* @param class-string $className
24		*/
25	2	public static function create(string $className): ?object
26		{
27	2	return (new self())->createByClassName($className);
28		}
29
30		/**
31		* @param class-string $className
32		*/
33	6	public function createByClassName(string $className): ?object
34		{
35	6	if (class_exists($className)) {
36	6	if (!isset($this->cachedDependencies[$className])) {
37	6	$this->cachedDependencies[$className] = $this
38	6	->getDependencyResolver()
39	6	->resolveDependencies($className);
40		}
41
42		/** @psalm-suppress MixedMethodCall */
43	6	return new $className(...$this->cachedDependencies[$className]);
44		}
45
46		return null;
47		}
48
49	6	private function getDependencyResolver(): DependencyResolver
50		{
51	6	if ($this->dependencyResolver === null) {
52	6	$this->dependencyResolver = new DependencyResolver(
53	6	$this->mappingInterfaces,
54	6	);
55		}
56
57	6	return $this->dependencyResolver;
		0 ignored issues – show Bug Best Practice introduced 2023-04-11 10:36 UTC by Report Bug Copy Issue Report The expression `return $this->dependencyResolver` could return the type `null` which is incompatible with the type-hinted return `Gacela\Resolver\DependencyResolver`. Consider adding an additional type-check to rule them out. Loading history...
58		}
59		}
60

gacela-project / container

Pull Request — main (#2)

InstanceCreator::createByClassName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like