InstanceCreator::createByClassName() - Code Metrics - Inspection of "Move InstanceCreator inside DependencyResolver dir" - gacela-project/container - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 25a875...ad40d6 )

by Chema

created 2023-04-10 16:31 UTC

InstanceCreator::createByClassName() A

↳ Parent: InstanceCreator

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	14
ccs	7
cts	8
cp	0.875
crap	3.0175
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Gacela\DependencyResolver;

final class InstanceCreator
{
    private ?DependencyResolver $dependencyResolver = null;

    /** @var array<class-string,list<mixed>> */
    private array $cachedDependencies = [];

    /**
     * @param array<class-string,class-string|callable|object> $mappingInterfaces
     */
    public function __construct(
        private array $mappingInterfaces = [],
    ) {
    }

    /**
     * @param class-string $className
     */
    public function createByClassName(string $className): ?object
    {
        if (class_exists($className)) {
            if (!isset($this->cachedDependencies[$className])) {
                $this->cachedDependencies[$className] = $this
                    ->getDependencyResolver()
                    ->resolveDependencies($className);
            }

            /** @psalm-suppress MixedMethodCall */
            return new $className(...$this->cachedDependencies[$className]);
        }

        return null;
    }

    private function getDependencyResolver(): DependencyResolver
    {
        if ($this->dependencyResolver === null) {
            $this->dependencyResolver = new DependencyResolver(
                $this->mappingInterfaces,
            );
        }

        return $this->dependencyResolver;

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Gacela\DependencyResolver;
6
7		final class InstanceCreator
8		{
9		private ?DependencyResolver $dependencyResolver = null;
10
11		/** @var array<class-string,list<mixed>> */
12		private array $cachedDependencies = [];
13
14		/**
15		* @param array<class-string,class-string\|callable\|object> $mappingInterfaces
16		*/
17	4	public function __construct(
18		private array $mappingInterfaces = [],
19		) {
20	4	}
21
22		/**
23		* @param class-string $className
24		*/
25	4	public function createByClassName(string $className): ?object
26		{
27	4	if (class_exists($className)) {
28	4	if (!isset($this->cachedDependencies[$className])) {
29	4	$this->cachedDependencies[$className] = $this
30	4	->getDependencyResolver()
31	4	->resolveDependencies($className);
32		}
33
34		/** @psalm-suppress MixedMethodCall */
35	4	return new $className(...$this->cachedDependencies[$className]);
36		}
37
38		return null;
39		}
40
41	4	private function getDependencyResolver(): DependencyResolver
42		{
43	4	if ($this->dependencyResolver === null) {
44	4	$this->dependencyResolver = new DependencyResolver(
45	4	$this->mappingInterfaces,
46	4	);
47		}
48
49	4	return $this->dependencyResolver;
		0 ignored issues – show Bug Best Practice introduced 2023-04-10 16:13 UTC by Report Bug Copy Issue Report The expression `return $this->dependencyResolver` could return the type `null` which is incompatible with the type-hinted return `Gacela\DependencyResolver\DependencyResolver`. Consider adding an additional type-check to rule them out. Loading history...
50		}
51		}
52

gacela-project / container

Push — main ( 25a875...ad40d6 )

InstanceCreator::createByClassName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like