Gacela\InstanceCreator\InstanceCreator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

93.75%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getDependencyResolver()	0	9	2
A	createByClassName()	0	14	3

<?php

declare(strict_types=1);

namespace Gacela\InstanceCreator;

use Gacela\DependencyResolver\DependencyResolver;

final class InstanceCreator
{
    private ?DependencyResolver $dependencyResolver = null;

    /** @var array<class-string,list<mixed>> */
    private array $cachedDependencies = [];

    /**
     * @param array<class-string,class-string|callable|object> $mappingInterfaces
     */
    public function __construct(
        private array $mappingInterfaces = [],
    ) {
    }

    /**
     * @param class-string $className
     */
    public function createByClassName(string $className): ?object
    {
        if (class_exists($className)) {
            if (!isset($this->cachedDependencies[$className])) {
                $this->cachedDependencies[$className] = $this
                    ->getDependencyResolver()
                    ->resolveDependencies($className);
            }

            /** @psalm-suppress MixedMethodCall */
            return new $className(...$this->cachedDependencies[$className]);
        }

        return null;
    }

    private function getDependencyResolver(): DependencyResolver
    {
        if ($this->dependencyResolver === null) {
            $this->dependencyResolver = new DependencyResolver(
                $this->mappingInterfaces,
            );
        }

        return $this->dependencyResolver;

The expression return $this->dependencyResolver could return the type null which is incompatible with the type-hinted return Gacela\DependencyResolver\DependencyResolver. Consider adding an additional type-check to rule them out.

    }
}