Issues in Item.php (master) - Issues in master - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Models/Inventory/Item.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Waredesk\Models\Inventory;

use DateTime;
use JsonSerializable;
use Waredesk\Collections\Inventory\Items\Activities;
use Waredesk\Collections\Inventory\Items\Attributes;
use Waredesk\Collections\Inventory\Items\Codes;
use Waredesk\Entity;
use Waredesk\ReplaceableEntity;

class Item implements Entity, ReplaceableEntity, JsonSerializable
{
    private $id;
    private $warehouse;
    private $product;
    private $variant;
    private $activities;
    private $attributes;
    private $in_stock = true;
    private $note;
    private $creation;
    private $modification;

    public function __construct(array $data = null)
    {
        $this->activities = new Activities();
        $this->attributes = new Attributes();
        $this->reset($data);
    }

    public function __clone()
    {
        $this->activities = clone $this->activities;
        $this->attributes = clone $this->attributes;
    }

    public function getId(): ? string
    {
        return $this->id;
    }

    public function getWarehouse(): ? string
    {
        return $this->warehouse;
    }

    public function getProduct(): ? string
    {
        return $this->product;
    }

    public function getVariant(): ? string
    {
        return $this->variant;
    }

    public function getActivities(): Activities
    {
        return $this->activities;
    }

    public function getAttributes(): Attributes
    {
        return $this->attributes;
    }

    public function isInStock(): ? bool
    {
        return $this->in_stock;
    }

    public function getNote(): ? string
    {
        return $this->note;
    }

    public function getCreation(): ? DateTime
    {
        return $this->creation;
    }

    public function getModification(): ? DateTime
    {
        return $this->modification;
    }

    public function reset(array $data = null)
    {
        if ($data) {
            foreach ($data as $key => $value) {
                switch ($key) {
                    case 'id':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                        $this->id = $value;
                        break;
                    case 'warehouse':
                        $this->warehouse = $value;
                        break;
                    case 'product':
                        $this->product = $value;
                        break;
                    case 'variant':
                        $this->variant = $value;
                        break;
                    case 'activities':
                        $this->activities = $value;
                        break;
                    case 'attributes':
                        $this->attributes = $value;
                        break;
                    case 'in_stock':
                        $this->in_stock = $value;
                        break;
                    case 'note':
                        $this->note = $value;
                        break;
                    case 'creation':
                        $this->creation = $value;
                        break;
                    case 'modification':
                        $this->modification = $value;
                        break;
                }
            }
        }
    }

    public function setWarehouse(string $warehouse = null)
    {
        $this->warehouse = $warehouse;
    }

    public function setVariant(string $variant)
    {
        $this->variant = $variant;
    }

    public function setIsInStock(string $in_stock)
    {
        $this->in_stock = $in_stock;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    public function setNote(string $note = null)
    {
        $this->note = $note;
    }

    public function jsonSerialize(): array
    {
        $returnValue = [
            'warehouse' => $this->getWarehouse(),
            'variant' => $this->getVariant(),
            'activities' => $this->getActivities()->jsonSerialize(),
            'attributes' => $this->getAttributes()->jsonSerialize(),
            'in_stock' => $this->isInStock(),
            'note' => $this->getNote(),
        ];
        if ($this->getId()) {
            $returnValue = array_merge(['id' => $this->getId()], $returnValue);
        }
        return $returnValue;
    }
}


1		<?php
2
3		namespace Waredesk\Models\Inventory;
4
5		use DateTime;
6		use JsonSerializable;
7		use Waredesk\Collections\Inventory\Items\Activities;
8		use Waredesk\Collections\Inventory\Items\Attributes;
9		use Waredesk\Collections\Inventory\Items\Codes;
10		use Waredesk\Entity;
11		use Waredesk\ReplaceableEntity;
12
13		class Item implements Entity, ReplaceableEntity, JsonSerializable
14		{
15		private $id;
16		private $warehouse;
17		private $product;
18		private $variant;
19		private $activities;
20		private $attributes;
21		private $in_stock = true;
22		private $note;
23		private $creation;
24		private $modification;
25
26	3	public function __construct(array $data = null)
27		{
28	3	$this->activities = new Activities();
29	3	$this->attributes = new Attributes();
30	3	$this->reset($data);
31	3	}
32
33		public function __clone()
34		{
35		$this->activities = clone $this->activities;
36		$this->attributes = clone $this->attributes;
37		}
38
39	2	public function getId(): ? string
40		{
41	2	return $this->id;
42		}
43
44	2	public function getWarehouse(): ? string
45		{
46	2	return $this->warehouse;
47		}
48
49		public function getProduct(): ? string
50		{
51		return $this->product;
52		}
53
54	2	public function getVariant(): ? string
55		{
56	2	return $this->variant;
57		}
58
59	2	public function getActivities(): Activities
60		{
61	2	return $this->activities;
62		}
63
64	2	public function getAttributes(): Attributes
65		{
66	2	return $this->attributes;
67		}
68
69	2	public function isInStock(): ? bool
70		{
71	2	return $this->in_stock;
72		}
73
74	2	public function getNote(): ? string
75		{
76	2	return $this->note;
77		}
78
79		public function getCreation(): ? DateTime
80		{
81		return $this->creation;
82		}
83
84		public function getModification(): ? DateTime
85		{
86		return $this->modification;
87		}
88
89	3	public function reset(array $data = null)
90		{
91	3	if ($data) {
92	3	foreach ($data as $key => $value) {
93		switch ($key) {
94	3	case 'id':
		0 ignored issues – show Coding Style introduced 2017-05-11 19:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
95	3	$this->id = $value;
96	3	break;
97	3	case 'warehouse':
98	3	$this->warehouse = $value;
99	3	break;
100	3	case 'product':
101	3	$this->product = $value;
102	3	break;
103	3	case 'variant':
104	3	$this->variant = $value;
105	3	break;
106	3	case 'activities':
107	3	$this->activities = $value;
108	3	break;
109	3	case 'attributes':
110	3	$this->attributes = $value;
111	3	break;
112	3	case 'in_stock':
113		$this->in_stock = $value;
114		break;
115	3	case 'note':
116	3	$this->note = $value;
117	3	break;
118	3	case 'creation':
119	3	$this->creation = $value;
120	3	break;
121	3	case 'modification':
122	3	$this->modification = $value;
123	3	break;
124		}
125		}
126		}
127	3	}
128
129		public function setWarehouse(string $warehouse = null)
130		{
131		$this->warehouse = $warehouse;
132		}
133
134	2	public function setVariant(string $variant)
135		{
136	2	$this->variant = $variant;
137	2	}
138
139		public function setIsInStock(string $in_stock)
140		{
141		$this->in_stock = $in_stock;
		0 ignored issues – show Documentation Bug introduced 2017-06-08 15:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$in_stock` was declared of type `boolean`, but `$in_stock` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
142		}
143
144		public function setNote(string $note = null)
145		{
146		$this->note = $note;
147		}
148
149	2	public function jsonSerialize(): array
150		{
151		$returnValue = [
152	2	'warehouse' => $this->getWarehouse(),
153	2	'variant' => $this->getVariant(),
154	2	'activities' => $this->getActivities()->jsonSerialize(),
155	2	'attributes' => $this->getAttributes()->jsonSerialize(),
156	2	'in_stock' => $this->isInStock(),
157	2	'note' => $this->getNote(),
158		];
159	2	if ($this->getId()) {
160		$returnValue = array_merge(['id' => $this->getId()], $returnValue);
161		}
162	2	return $returnValue;
163		}
164		}
165

gabrielbull / php-waredesk-api

Issues (24)

Security Analysis no request data

src/Models/Inventory/Item.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like