Product::getDescription() - Code Metrics - Inspection of "Added image object" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ab94e9...fa2f9e )

by Gabriel

created 2017-05-06 00:26 UTC

Product::getDescription() A

↳ Parent: Product

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace Waredesk\Models;

use DateTime;
use Waredesk\Collections\Products\Variants;
use JsonSerializable;

class Product implements JsonSerializable
{
    private $id;
    private $images;
    private $variants;
    private $name;
    private $description;
    private $notes;
    private $creation_datetime;
    private $modification_datetime;

    public function __construct()
    {
        $this->variants = new Variants();
    }

    public function getId(): ?int
    {
        return $this->id;
    }

    public function setId(int $id = null)
    {
        $this->id = $id;
    }

    public function getImages(): ?array
    {
        return $this->images;
    }

    public function setImages(array $images = null)
    {
        $this->images = $images;
    }

    public function getVariants(): ?Variants
    {
        return $this->variants;
    }

    public function setVariants(Variants $variants)
    {
        $this->variants = $variants;
    }

    public function getName(): ?string
    {
        return $this->name;
    }

    public function setName(string $name = null)
    {
        $this->name = $name;
    }

    public function getDescription(): ?string
    {
        return $this->description;
    }

    public function setDescription(string $description = null)
    {
        $this->description = $description;
    }

    public function getNotes(): ?string
    {
        return $this->notes;
    }

    public function setNotes(string $notes = null)
    {
        $this->notes = $notes;
    }

    public function getCreationDatetime(): ?DateTime
    {
        return $this->creation_datetime;
    }

    public function setCreationDatetime(DateTime $creation_datetime = null)
    {
        $this->creation_datetime = $creation_datetime;
    }

    public function getModificationDatetime(): ?DateTime
    {
        return $this->modification_datetime;
    }

    public function setModificationDatetime(DateTime $modification_datetime = null)
    {
        $this->modification_datetime = $modification_datetime;
    }

    public function jsonSerialize()
    {
        $returnValue = [
            'variants' => $this->getVariants()->jsonSerialize(),
            'name' => $this->getName(),

            'description' => $this->getDescription(),
            'notes' => $this->getNotes(),
        ];
        //if ($this->getImages() instanceof NewImage) {

        // $returnValue['image'] = base64($this->getNewImage());

        // }
        return $returnValue;
    }
}


1		<?php
2
3		namespace Waredesk\Models;
4
5		use DateTime;
6		use Waredesk\Collections\Products\Variants;
7		use JsonSerializable;
8
9		class Product implements JsonSerializable
10		{
11		private $id;
12		private $images;
13		private $variants;
14		private $name;
15		private $description;
16		private $notes;
17		private $creation_datetime;
18		private $modification_datetime;
19
20	1	public function __construct()
21		{
22	1	$this->variants = new Variants();
23	1	}
24
25	1	public function getId(): ?int
26		{
27	1	return $this->id;
28		}
29
30	1	public function setId(int $id = null)
31		{
32	1	$this->id = $id;
33	1	}
34
35		public function getImages(): ?array
36		{
37		return $this->images;
38		}
39
40	1	public function setImages(array $images = null)
41		{
42	1	$this->images = $images;
43	1	}
44
45	1	public function getVariants(): ?Variants
46		{
47	1	return $this->variants;
48		}
49
50	1	public function setVariants(Variants $variants)
51		{
52	1	$this->variants = $variants;
53	1	}
54
55	1	public function getName(): ?string
56		{
57	1	return $this->name;
58		}
59
60	1	public function setName(string $name = null)
61		{
62	1	$this->name = $name;
63	1	}
64
65	1	public function getDescription(): ?string
66		{
67	1	return $this->description;
68		}
69
70	1	public function setDescription(string $description = null)
71		{
72	1	$this->description = $description;
73	1	}
74
75	1	public function getNotes(): ?string
76		{
77	1	return $this->notes;
78		}
79
80	1	public function setNotes(string $notes = null)
81		{
82	1	$this->notes = $notes;
83	1	}
84
85		public function getCreationDatetime(): ?DateTime
86		{
87		return $this->creation_datetime;
88		}
89
90	1	public function setCreationDatetime(DateTime $creation_datetime = null)
91		{
92	1	$this->creation_datetime = $creation_datetime;
93	1	}
94
95		public function getModificationDatetime(): ?DateTime
96		{
97		return $this->modification_datetime;
98		}
99
100	1	public function setModificationDatetime(DateTime $modification_datetime = null)
101		{
102	1	$this->modification_datetime = $modification_datetime;
103	1	}
104
105	1	public function jsonSerialize()
106		{
107		$returnValue = [
108	1	'variants' => $this->getVariants()->jsonSerialize(),
109	1	'name' => $this->getName(),
		0 ignored issues – show Bug introduced 2017-05-05 23:04 UTC by Report Bug Copy Issue Report Consider using `$this->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
110	1	'description' => $this->getDescription(),
111	1	'notes' => $this->getNotes(),
112		];
113		//if ($this->getImages() instanceof NewImage) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-05 23:04 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
114		// $returnValue['image'] = base64($this->getNewImage());
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-05 23:04 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
115		// }
116	1	return $returnValue;
117		}
118		}
119

gabrielbull / php-waredesk-api

Push — master ( ab94e9...fa2f9e )

Product::getDescription() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like