Category::setParent() - Code Metrics - Inspection of "Added categories" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 134b2d...f2c57a )

by Gabriel

created 2017-06-02 21:07 UTC

Category::setParent() A

↳ Parent: Category

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace Waredesk\Models;

use DateTime;
use JsonSerializable;
use Waredesk\Entity;
use Waredesk\ReplaceableEntity;

class Category implements Entity, ReplaceableEntity, JsonSerializable
{
    private $id;
    private $parent;
    private $name;
    private $creation;
    private $modification;

    public function __construct(array $data = null)
    {
        $this->reset($data);
    }

    public function __clone()
    {
    }

    public function getId(): ? string
    {
        return $this->id;
    }

    public function getParent(): ? string
    {
        return $this->parent;
    }

    public function getName(): ? string
    {
        return $this->name;
    }

    public function getCreation(): ?DateTime
    {
        return $this->creation;
    }

    public function getModification(): ? DateTime
    {
        return $this->modification;
    }

    public function reset(array $data = null)
    {
        if ($data) {
            foreach ($data as $key => $value) {
                switch ($key) {
                    case 'id':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                        $this->id = $value;
                        break;
                    case 'parent':
                        $this->parent = $value;
                        break;
                    case 'name':
                        $this->name = $value;
                        break;
                    case 'creation':
                        $this->creation = $value;
                        break;
                    case 'modification':
                        $this->modification = $value;
                        break;
                }
            }
        }
    }

    public function setParent(string $parent = null)
    {
        $this->parent = $parent;
    }

    public function setName(string $name = null)
    {
        $this->name = $name;
    }

    public function jsonSerialize(): array
    {
        $returnValue = [
            'parent' => $this->getParent(),
            'name' => $this->getName(),
        ];
        if ($this->getId()) {
            $returnValue = array_merge(['id' => $this->getId()], $returnValue);
        }
        return $returnValue;
    }
}


1		<?php
2
3		namespace Waredesk\Models;
4
5		use DateTime;
6		use JsonSerializable;
7		use Waredesk\Entity;
8		use Waredesk\ReplaceableEntity;
9
10		class Category implements Entity, ReplaceableEntity, JsonSerializable
11		{
12		private $id;
13		private $parent;
14		private $name;
15		private $creation;
16		private $modification;
17
18	2	public function __construct(array $data = null)
19		{
20	2	$this->reset($data);
21	2	}
22
23		public function __clone()
24		{
25		}
26
27	1	public function getId(): ? string
28		{
29	1	return $this->id;
30		}
31
32	1	public function getParent(): ? string
33		{
34	1	return $this->parent;
35		}
36
37	1	public function getName(): ? string
38		{
39	1	return $this->name;
40		}
41
42		public function getCreation(): ?DateTime
43		{
44		return $this->creation;
45		}
46
47		public function getModification(): ? DateTime
48		{
49		return $this->modification;
50		}
51
52	2	public function reset(array $data = null)
53		{
54	2	if ($data) {
55	2	foreach ($data as $key => $value) {
56		switch ($key) {
57	2	case 'id':
		0 ignored issues – show Coding Style introduced 2017-05-11 19:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
58	2	$this->id = $value;
59	2	break;
60	2	case 'parent':
61	2	$this->parent = $value;
62	2	break;
63	2	case 'name':
64	2	$this->name = $value;
65	2	break;
66	2	case 'creation':
67	2	$this->creation = $value;
68	2	break;
69	2	case 'modification':
70	2	$this->modification = $value;
71	2	break;
72		}
73		}
74		}
75	2	}
76
77		public function setParent(string $parent = null)
78		{
79		$this->parent = $parent;
80		}
81
82	1	public function setName(string $name = null)
83		{
84	1	$this->name = $name;
85	1	}
86
87	1	public function jsonSerialize(): array
88		{
89		$returnValue = [
90	1	'parent' => $this->getParent(),
91	1	'name' => $this->getName(),
92		];
93	1	if ($this->getId()) {
94		$returnValue = array_merge(['id' => $this->getId()], $returnValue);
95		}
96	1	return $returnValue;
97		}
98		}
99

gabrielbull / php-waredesk-api

Push — master ( 134b2d...f2c57a )

Category::setParent() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like