Item::reset() - Code Metrics - Inspection of "Added inventory" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bd41e0...b80a23 )

by Gabriel

created 2017-06-08 02:44 UTC

Item::reset() C

↳ Parent: Item

Complexity

Conditions	13
Paths	13

Size

Total Lines	39
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

Metric	Value
dl	0
loc	39
rs	5.1234
c	0
b	0
f	0
ccs	0
cts	34
cp	0
cc	13
eloc	34
nc	13
nop	1
crap	182

How to fix Complexity

<?php

namespace Waredesk\Models\Inventory;

use DateTime;
use JsonSerializable;
use Waredesk\Collections\Inventory\Items\Activities;
use Waredesk\Collections\Inventory\Items\Codes;
use Waredesk\Entity;
use Waredesk\ReplaceableEntity;

class Item implements Entity, ReplaceableEntity, JsonSerializable
{
    private $id;
    private $warehouse;
    private $product;
    private $variant;
    private $activities;
    private $codes;
    private $in_stock;
    private $note;
    private $creation;
    private $modification;

    public function __construct(array $data = null)
    {
        $this->activities = new Activities();
        $this->codes = new Codes();
        $this->reset($data);
    }

    public function __clone()
    {
        $this->activities = clone $this->activities;
        $this->codes = clone $this->codes;
    }

    public function getId(): ? string
    {
        return $this->id;
    }

    public function getWarehouse(): ? string
    {
        return $this->warehouse;
    }

    public function getProduct(): ? string
    {
        return $this->product;
    }

    public function getVariant(): ? string
    {
        return $this->variant;
    }

    public function getActivities(): Activities
    {
        return $this->activities;
    }

    public function getCodes(): Codes
    {
        return $this->codes;
    }

    public function isInStock(): ? bool
    {
        return $this->in_stock;
    }

    public function getNote(): ? string
    {
        return $this->note;
    }

    public function getCreation(): ? DateTime
    {
        return $this->creation;
    }

    public function getModification(): ? DateTime
    {
        return $this->modification;
    }

    public function reset(array $data = null)
    {
        if ($data) {
            foreach ($data as $key => $value) {
                switch ($key) {
                    case 'id':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                        $this->id = $value;
                        break;
                    case 'warehouse':
                        $this->warehouse = $value;
                        break;
                    case 'product':
                        $this->product = $value;
                        break;
                    case 'variant':
                        $this->variant = $value;
                        break;
                    case 'activities':
                        $this->activities = $value;
                        break;
                    case 'codes':
                        $this->codes = $value;
                        break;
                    case 'in_stock':
                        $this->in_stock = $value;
                        break;
                    case 'note':
                        $this->note = $value;
                        break;
                    case 'creation':
                        $this->creation = $value;
                        break;
                    case 'modification':
                        $this->modification = $value;
                        break;
                }
            }
        }
    }

    public function setWarehouse(string $warehouse = null)
    {
        $this->warehouse = $warehouse;
    }

    public function setVariant(string $variant)
    {
        $this->variant = $variant;
    }

    public function setIsInStock(string $in_stock)
    {
        $this->in_stock = $in_stock;
    }

    public function setNote(string $note = null)
    {
        $this->note = $note;
    }

    public function jsonSerialize(): array
    {
        $returnValue = [
            'warehouse' => $this->getWarehouse(),
            'variant' => $this->getVariant(),
            'activities' => $this->getActivities()->jsonSerialize(),
            'codes' => $this->getCodes()->jsonSerialize(),
            'in_stock' => $this->isInStock(),
            'note' => $this->getNote(),
        ];
        if ($this->getId()) {
            $returnValue = array_merge(['id' => $this->getId()], $returnValue);
        }
        return $returnValue;
    }
}


1			<?php
2
3			namespace Waredesk\Models\Inventory;
4
5			use DateTime;
6			use JsonSerializable;
7			use Waredesk\Collections\Inventory\Items\Activities;
8			use Waredesk\Collections\Inventory\Items\Codes;
9			use Waredesk\Entity;
10			use Waredesk\ReplaceableEntity;
11
12			class Item implements Entity, ReplaceableEntity, JsonSerializable
13			{
14			private $id;
15			private $warehouse;
16			private $product;
17			private $variant;
18			private $activities;
19			private $codes;
20			private $in_stock;
21			private $note;
22			private $creation;
23			private $modification;
24
25			public function __construct(array $data = null)
26			{
27			$this->activities = new Activities();
28			$this->codes = new Codes();
29			$this->reset($data);
30			}
31
32			public function __clone()
33			{
34			$this->activities = clone $this->activities;
35			$this->codes = clone $this->codes;
36			}
37
38			public function getId(): ? string
39			{
40			return $this->id;
41			}
42
43			public function getWarehouse(): ? string
44			{
45			return $this->warehouse;
46			}
47
48			public function getProduct(): ? string
49			{
50			return $this->product;
51			}
52
53			public function getVariant(): ? string
54			{
55			return $this->variant;
56			}
57
58			public function getActivities(): Activities
59			{
60			return $this->activities;
61			}
62
63			public function getCodes(): Codes
64			{
65			return $this->codes;
66			}
67
68			public function isInStock(): ? bool
69			{
70			return $this->in_stock;
71			}
72
73			public function getNote(): ? string
74			{
75			return $this->note;
76			}
77
78			public function getCreation(): ? DateTime
79			{
80			return $this->creation;
81			}
82
83			public function getModification(): ? DateTime
84			{
85			return $this->modification;
86			}
87
88			public function reset(array $data = null)
89			{
90			if ($data) {
91			foreach ($data as $key => $value) {
92			switch ($key) {
93			case 'id':
			0 ignored issues – show Coding Style introduced 2017-05-11 19:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
94			$this->id = $value;
95			break;
96			case 'warehouse':
97			$this->warehouse = $value;
98			break;
99			case 'product':
100			$this->product = $value;
101			break;
102			case 'variant':
103			$this->variant = $value;
104			break;
105			case 'activities':
106			$this->activities = $value;
107			break;
108			case 'codes':
109			$this->codes = $value;
110			break;
111			case 'in_stock':
112			$this->in_stock = $value;
113			break;
114			case 'note':
115			$this->note = $value;
116			break;
117			case 'creation':
118			$this->creation = $value;
119			break;
120			case 'modification':
121			$this->modification = $value;
122			break;
123			}
124			}
125			}
126			}
127
128			public function setWarehouse(string $warehouse = null)
129			{
130			$this->warehouse = $warehouse;
131			}
132
133			public function setVariant(string $variant)
134			{
135			$this->variant = $variant;
136			}
137
138			public function setIsInStock(string $in_stock)
139			{
140			$this->in_stock = $in_stock;
141			}
142
143			public function setNote(string $note = null)
144			{
145			$this->note = $note;
146			}
147
148			public function jsonSerialize(): array
149			{
150			$returnValue = [
151			'warehouse' => $this->getWarehouse(),
152			'variant' => $this->getVariant(),
153			'activities' => $this->getActivities()->jsonSerialize(),
154			'codes' => $this->getCodes()->jsonSerialize(),
155			'in_stock' => $this->isInStock(),
156			'note' => $this->getNote(),
157			];
158			if ($this->getId()) {
159			$returnValue = array_merge(['id' => $this->getId()], $returnValue);
160			}
161			return $returnValue;
162			}
163			}
164

gabrielbull / php-waredesk-api

Push — master ( bd41e0...b80a23 )

Item::reset() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like