Products::delete() - Code Metrics - Inspection of "Updated to new API version" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cb44f9...1fdaf4 )

by Gabriel

created 2017-05-31 19:43 UTC

Products::delete() A

↳ Parent: Products

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	4
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	2

<?php

namespace Waredesk;

use Waredesk\Mappers\ProductMapper;
use Waredesk\Mappers\ProductsMapper;
use Waredesk\Models\Product;

class Products
{
    private $requestHandler;

    public function __construct(RequestHandler $requestHandler)
    {
        $this->requestHandler = $requestHandler;
    }

    public function create(Product $product): Product

    {
        $response = $this->requestHandler->post(
            '/v1/products',
            $product
        );
        $product = (new ProductMapper())->map($product, $response);
        return $product;
    }

    public function update(Product $product): Product

    {
        $response = $this->requestHandler->update(
            "/v1/products/{$product->getId()}",
            $product
        );
        $product = (new ProductMapper())->map($product, $response);
        return $product;
    }

    public function delete(Product $product): bool
    {
        $this->requestHandler->delete(
            "/v1/products/{$product->getId()}"
        );
        return true;
    }

    /**
     * @return Collections\Products|Product[]
     */
    public function fetch(): Collections\Products
    {
        $response = $this->requestHandler->get('/v1/products');
        return (new ProductsMapper())->map(new Collections\Products(), $response);
    }
}


1			<?php
2
3			namespace Waredesk;
4
5			use Waredesk\Mappers\ProductMapper;
6			use Waredesk\Mappers\ProductsMapper;
7			use Waredesk\Models\Product;
8
9			class Products
10			{
11			private $requestHandler;
12
13	12		public function __construct(RequestHandler $requestHandler)
14			{
15	12		$this->requestHandler = $requestHandler;
16	12		}
17
18	2	View Code Duplication	public function create(Product $product): Product
			0 ignored issues – show Duplication introduced 2017-05-31 19:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20	2		$response = $this->requestHandler->post(
21	2		'/v1/products',
22			$product
23			);
24	2		$product = (new ProductMapper())->map($product, $response);
25	2		return $product;
26			}
27
28		View Code Duplication	public function update(Product $product): Product
			0 ignored issues – show Duplication introduced 2017-05-31 19:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29			{
30			$response = $this->requestHandler->update(
31			"/v1/products/{$product->getId()}",
32			$product
33			);
34			$product = (new ProductMapper())->map($product, $response);
35			return $product;
36			}
37
38			public function delete(Product $product): bool
39			{
40			$this->requestHandler->delete(
41			"/v1/products/{$product->getId()}"
42			);
43			return true;
44			}
45
46			/**
47			* @return Collections\Products\|Product[]
48			*/
49	1		public function fetch(): Collections\Products
50			{
51	1		$response = $this->requestHandler->get('/v1/products');
52	1		return (new ProductsMapper())->map(new Collections\Products(), $response);
53			}
54			}
55

gabrielbull / php-waredesk-api

Push — master ( cb44f9...1fdaf4 )

Products::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like