Code::getCode() - Code Metrics - Inspection of "Fixed some issues" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b50380...c789e7 )

by Gabriel

created 2017-05-21 14:19 UTC

Code::getCode() A

↳ Parent: Code

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Waredesk\Models\Product\Variant;

use DateTime;
use JsonSerializable;
use Waredesk\Collections\Products\Variants\Codes\Elements;

class Code implements JsonSerializable
{
    private $code;
    private $name;
    private $elements;
    private $creation;
    private $modification;

    public function __construct()
    {
        $this->elements = new Elements();
    }

    public function getCode(): ? string
    {
        return $this->code;
    }

    public function getName(): ? string
    {
        return $this->name;
    }

    public function getElements(): ? Elements
    {
        return $this->elements;
    }

    public function getCreation(): ? DateTime
    {
        return $this->creation;
    }

    public function getModification(): ? DateTime
    {
        return $this->modification;
    }

    public function reset(array $data = null)
    {
        if ($data) {
            foreach ($data as $key => $value) {
                switch ($key) {
                    case 'code':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                        $this->code = $value;
                        break;
                    case 'name':
                        $this->name = $value;
                        break;
                    case 'elements':
                        $this->elements = $value;
                        break;
                    case 'creation':
                        $this->creation = $value;
                        break;
                    case 'modification':
                        $this->modification = $value;
                        break;
                }
            }
        }
    }

    public function jsonSerialize()
    {
        return [
            'code' => $this->getCode(),
            'elements' => $this->getElements()->jsonSerialize(),
        ];
    }
}


1			<?php
2
3			namespace Waredesk\Models\Product\Variant;
4
5			use DateTime;
6			use JsonSerializable;
7			use Waredesk\Collections\Products\Variants\Codes\Elements;
8
9			class Code implements JsonSerializable
10			{
11			private $code;
12			private $name;
13			private $elements;
14			private $creation;
15			private $modification;
16
17			public function __construct()
18			{
19			$this->elements = new Elements();
20			}
21
22			public function getCode(): ? string
23			{
24			return $this->code;
25			}
26
27			public function getName(): ? string
28			{
29			return $this->name;
30			}
31
32			public function getElements(): ? Elements
33			{
34			return $this->elements;
35			}
36
37			public function getCreation(): ? DateTime
38			{
39			return $this->creation;
40			}
41
42			public function getModification(): ? DateTime
43			{
44			return $this->modification;
45			}
46
47			public function reset(array $data = null)
48			{
49			if ($data) {
50			foreach ($data as $key => $value) {
51			switch ($key) {
52			case 'code':
			0 ignored issues – show Coding Style introduced 2017-05-11 19:09 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
53			$this->code = $value;
54			break;
55			case 'name':
56			$this->name = $value;
57			break;
58			case 'elements':
59			$this->elements = $value;
60			break;
61			case 'creation':
62			$this->creation = $value;
63			break;
64			case 'modification':
65			$this->modification = $value;
66			break;
67			}
68			}
69			}
70			}
71
72			public function jsonSerialize()
73			{
74			return [
75			'code' => $this->getCode(),
76			'elements' => $this->getElements()->jsonSerialize(),
77			];
78			}
79			}
80

gabrielbull / php-waredesk-api

Push — master ( b50380...c789e7 )

Code::getCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like