RequestHandler::handleBadResponse() - Code Metrics - Inspection of "Initial commit" - gabrielbull/php-waredesk-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6b2c4c...9e30d1 )

by Gabriel

created 2017-05-05 14:06 UTC

RequestHandler::handleBadResponse() A

↳ Parent: RequestHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	2

<?php

namespace Waredesk;

use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request as GuzzleRequest;
use GuzzleHttp\Client;
use Psr\Http\Message\ResponseInterface;
use Waredesk\Exceptions\UnknownException;

class RequestHandler
{
    private $accessToken;
    private $apiUrl;
    private $client;

    public function __construct(string $accessToken = null, string $apiUrl = null)
    {
        $this->accessToken = $accessToken;
        $this->apiUrl = $apiUrl;
        $this->client = new Client(['base_uri' => $this->apiUrl . '/']);
    }

    public function getAccessToken(): string
    {
        return $this->accessToken;
    }

    public function setAccessToken(string $accessToken)
    {
        $this->accessToken = $accessToken;
    }

    public function getApiUrl(): string
    {
        return $this->apiUrl;
    }

    public function setApiUrl(string $apiUrl)
    {
        $this->apiUrl = $apiUrl;
        $this->client = new Client(['base_uri' => $apiUrl . '/']);
    }

    private function handleBadResponse(ResponseInterface $response)
    {
        $body = (string) $response->getBody();
        $json = \GuzzleHttp\json_decode($body, true);
        ErrorHandler::error($json);
    }

    private function handleException(ClientException $exception)
    {
        $this->handleBadResponse($exception->getResponse());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    public function get(string $endpoint, array $headers = [], array $params = null)

    {
    }

    public function post(string $endpoint, array $params = null, array $headers = []): array
    {
        $headers['Content-Type'] = 'application/json';
        $body = null;
        if ($params) $body = \GuzzleHttp\json_encode($params);
        $request = new GuzzleRequest('POST', $endpoint, $headers, $body);

        try {
            $response = $this->client->send($request);
            if ($response->getStatusCode() >= 200 && $response->getStatusCode() <= 399) {
                return \GuzzleHttp\json_decode((string)$response->getBody(), true);
            } else {
                $this->handleBadResponse($response);
            }
        } catch (ClientException $e) {
            $this->handleException($e);
        }
        throw new UnknownException();
    }
}


1			<?php
2
3			namespace Waredesk;
4
5			use GuzzleHttp\Exception\ClientException;
6			use GuzzleHttp\Psr7\Request as GuzzleRequest;
7			use GuzzleHttp\Client;
8			use Psr\Http\Message\ResponseInterface;
9			use Waredesk\Exceptions\UnknownException;
10
11			class RequestHandler
12			{
13			private $accessToken;
14			private $apiUrl;
15			private $client;
16
17			public function __construct(string $accessToken = null, string $apiUrl = null)
18			{
19			$this->accessToken = $accessToken;
20			$this->apiUrl = $apiUrl;
21			$this->client = new Client(['base_uri' => $this->apiUrl . '/']);
22			}
23
24			public function getAccessToken(): string
25			{
26			return $this->accessToken;
27			}
28
29			public function setAccessToken(string $accessToken)
30			{
31			$this->accessToken = $accessToken;
32			}
33
34			public function getApiUrl(): string
35			{
36			return $this->apiUrl;
37			}
38
39			public function setApiUrl(string $apiUrl)
40			{
41			$this->apiUrl = $apiUrl;
42			$this->client = new Client(['base_uri' => $apiUrl . '/']);
43			}
44
45			private function handleBadResponse(ResponseInterface $response)
46			{
47			$body = (string) $response->getBody();
48			$json = \GuzzleHttp\json_decode($body, true);
49			ErrorHandler::error($json);
50			}
51
52			private function handleException(ClientException $exception)
53			{
54			$this->handleBadResponse($exception->getResponse());
			0 ignored issues – show Bug introduced 2017-05-05 14:08 UTC by Report Bug Copy Issue Report It seems like `$exception->getResponse()` can be `null`; however, `handleBadResponse()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
55			}
56
57			public function get(string $endpoint, array $headers = [], array $params = null)
			0 ignored issues – show Unused Code introduced 2017-05-05 13:49 UTC by Report Bug Copy Issue Report The parameter `$endpoint` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-05 13:49 UTC by Report Bug Copy Issue Report The parameter `$headers` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-05 13:49 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58			{
59			}
60
61			public function post(string $endpoint, array $params = null, array $headers = []): array
62			{
63			$headers['Content-Type'] = 'application/json';
64			$body = null;
65			if ($params) $body = \GuzzleHttp\json_encode($params);
66			$request = new GuzzleRequest('POST', $endpoint, $headers, $body);
67
68			try {
69			$response = $this->client->send($request);
70			if ($response->getStatusCode() >= 200 && $response->getStatusCode() <= 399) {
71			return \GuzzleHttp\json_decode((string)$response->getBody(), true);
72			} else {
73			$this->handleBadResponse($response);
74			}
75			} catch (ClientException $e) {
76			$this->handleException($e);
77			}
78			throw new UnknownException();
79			}
80			}
81

gabrielbull / php-waredesk-api

Push — master ( 6b2c4c...9e30d1 )

RequestHandler::handleBadResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like