Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like InternationalForms often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use InternationalForms, and based on these observations, apply Extract Interface, too.
| 1 | <?php | ||
| 10 | class InternationalForms implements NodeInterface | ||
| 11 | { | ||
| 12 | /** | ||
| 13 | * @var string | ||
| 14 | */ | ||
| 15 | private $type = self::TYPE_INVOICE; | ||
| 16 | |||
| 17 | /** | ||
| 18 | * Form Types. | ||
| 19 | */ | ||
| 20 | const TYPE_INVOICE = '01'; | ||
| 21 | const TYPE_CO = '03'; | ||
| 22 | const TYPE_NAFTA_CO = '04'; | ||
| 23 | const TYPE_PARTIAL_INVOICE = '05'; | ||
| 24 | const TYPE_PACKINGLIST = '06'; | ||
| 25 | const TYPE_CUSTOMER_GENERATED_FORMS = '07'; | ||
| 26 | const TYPE_AIR_FREIGHT_PACKING_LIST = '08'; | ||
| 27 | const TYPE_CN22_FORMS = '09'; | ||
| 28 | const TYPE_UPS_PREMIUM_CARE = '10'; | ||
| 29 | const TYPE_EEI_SHIPMENT_WITH_RETURN_SERVICE = '11'; | ||
| 30 | |||
| 31 | private static $typeNames = [ | ||
| 32 | '01' => 'Invoice', | ||
| 33 | '03' => 'CO', | ||
| 34 | '04' => 'NAFTA CO', | ||
| 35 | '05' => 'Partial Invoice', | ||
| 36 | '06' => 'Packinglist', | ||
| 37 | '07' => 'Customer Generated Forms', | ||
| 38 | '08' => 'Air Freight Packing List', | ||
| 39 | '09' => 'CN22 Forms', | ||
| 40 | '10' => 'UPS Premium Care', | ||
| 41 | '11' => 'EEI. For shipment with return service', | ||
| 42 | ]; | ||
| 43 | |||
| 44 | /** | ||
| 45 | * @var string | ||
| 46 | */ | ||
| 47 | private $termsOfShipment; | ||
| 48 | |||
| 49 | /** | ||
| 50 | * Terms of Shipment. | ||
| 51 | */ | ||
| 52 | const TOS_COST_AND_FREIGHT = 'CFR'; | ||
| 53 | const TOS_COST_INSURANCE_AND_FREIGHT = 'CIF'; | ||
| 54 | const TOS_CARRIAGE_AND_INSURANCE_PAID = 'CIP'; | ||
| 55 | const TOS_CARRIAGE_PAID_TO = 'CPT'; | ||
| 56 | const TOS_DELIVERED_AT_FRONTIER = 'DAF'; | ||
| 57 | const TOS_DELIVERY_DUTY_PAID = 'DDP'; | ||
| 58 | const TOS_DELIVERY_DUTY_UNPAID = 'DDU'; | ||
| 59 | const TOS_DELIVERED_EX_QUAY = 'DEQ'; | ||
| 60 | const TOS_DELIVERED_EX_SHIP = 'DES'; | ||
| 61 | const TOS_EX_WORKS = 'EXW'; | ||
| 62 | const TOS_FREE_ALONGSIDE_SHIP = 'FAS'; | ||
| 63 | const TOS_FREE_CARRIER = 'FCA'; | ||
| 64 | const TOS_FREE_ON_BOARD = 'FOB'; | ||
| 65 | |||
| 66 | private static $termsOfShipmentNames = [ | ||
|  | |||
| 67 | 'CFR' => 'Cost and Freight', | ||
| 68 | 'CIF' => 'Cost, Insurance and Freight', | ||
| 69 | 'CIP' => 'Carriage and Insurance Paid', | ||
| 70 | 'CPT' => 'Carriage Paid To', | ||
| 71 | 'DAF' => 'Delivered at Frontier', | ||
| 72 | 'DDP' => 'Delivery Duty Paid', | ||
| 73 | 'DDU' => 'Delivery Duty Unpaid', | ||
| 74 | 'DEQ' => 'Delivered Ex Quay', | ||
| 75 | 'DES' => 'Delivered Ex Ship', | ||
| 76 | 'EXW' => 'Ex Works', | ||
| 77 | 'FAS' => 'Free Alongside Ship', | ||
| 78 | 'FCA' => 'Free Carrier', | ||
| 79 | 'FOB' => 'Free On Board', | ||
| 80 | ]; | ||
| 81 | |||
| 82 | /** | ||
| 83 | * @var string | ||
| 84 | */ | ||
| 85 | private $reasonForExport; | ||
| 86 | |||
| 87 | /** | ||
| 88 | * Reasons for export. | ||
| 89 | */ | ||
| 90 | const RFE_SALE = 'SALE'; | ||
| 91 | const RFE_GIFT = 'GIFT'; | ||
| 92 | const RFE_SAMPLE = 'SAMPLE'; | ||
| 93 | const RFE_RETURN = 'RETURN'; | ||
| 94 | const RFE_REPAIR = 'REPAIR'; | ||
| 95 | const RFE_INTERCOMPANYDATA = 'INTERCOMPANYDATA'; | ||
| 96 | |||
| 97 | /** | ||
| 98 | * @var string | ||
| 99 | */ | ||
| 100 | private $comments; | ||
| 101 | |||
| 102 | /** | ||
| 103 | * @var string | ||
| 104 | */ | ||
| 105 | private $currencyCode; | ||
| 106 | |||
| 107 | /** | ||
| 108 | * @var string | ||
| 109 | */ | ||
| 110 | private $invoiceNumber; | ||
| 111 | |||
| 112 | /** | ||
| 113 | * @var DateTime | ||
| 114 | */ | ||
| 115 | private $invoiceDate; | ||
| 116 | |||
| 117 | /** | ||
| 118 | * @var string | ||
| 119 | */ | ||
| 120 | private $purchaseOrderNumber; | ||
| 121 | |||
| 122 | /** | ||
| 123 | * @var array | ||
| 124 | */ | ||
| 125 | private $products = []; | ||
| 126 | |||
| 127 | /** | ||
| 128 | * @var Discount | ||
| 129 | */ | ||
| 130 | private $discount; | ||
| 131 | |||
| 132 | /** | ||
| 133 | * @var FreightCharges | ||
| 134 | */ | ||
| 135 | private $freightCharges; | ||
| 136 | |||
| 137 | /** | ||
| 138 | * @var string $declarationStatement | ||
| 139 | */ | ||
| 140 | private $declarationStatement; | ||
| 141 | |||
| 142 | /** | ||
| 143 | * @return array | ||
| 144 | */ | ||
| 145 | public static function getTypes() | ||
| 149 | |||
| 150 | /** | ||
| 151 | * @return string | ||
| 152 | */ | ||
| 153 | public function getTypeName() | ||
| 157 | |||
| 158 | /** | ||
| 159 | * @param null|object $attributes | ||
| 160 | */ | ||
| 161 | public function __construct($attributes = null) | ||
| 190 | |||
| 191 | /** | ||
| 192 | * @param $type string | ||
| 193 | * | ||
| 194 | * @return $this | ||
| 195 | */ | ||
| 196 | public function setType($type) | ||
| 202 | |||
| 203 | /** | ||
| 204 | * @return string | ||
| 205 | */ | ||
| 206 | public function getType() | ||
| 210 | |||
| 211 | /** | ||
| 212 | * @param $freightCharges FreightCharges | ||
| 213 | * | ||
| 214 | * @return $this | ||
| 215 | */ | ||
| 216 | public function setFreightCharges(FreightCharges $freightCharges) | ||
| 222 | |||
| 223 | /** | ||
| 224 | * @return FreightCharges | ||
| 225 | */ | ||
| 226 | public function getFreightCharges() | ||
| 230 | |||
| 231 | /** | ||
| 232 | * @param $discount Discount | ||
| 233 | * | ||
| 234 | * @return $this | ||
| 235 | */ | ||
| 236 | public function setDiscount(Discount $discount) | ||
| 242 | |||
| 243 | /** | ||
| 244 | * @return Discount | ||
| 245 | */ | ||
| 246 | public function getDiscount() | ||
| 250 | |||
| 251 | /** | ||
| 252 | * @param Product $product | ||
| 253 | * | ||
| 254 | * @return $this | ||
| 255 | */ | ||
| 256 | public function addProduct(Product $product) | ||
| 262 | |||
| 263 | /** | ||
| 264 | * @return array | ||
| 265 | */ | ||
| 266 | public function getProducts() | ||
| 270 | |||
| 271 | /** | ||
| 272 | * @param null|DOMDocument $document | ||
| 273 | * | ||
| 274 | * @return DOMElement | ||
| 275 | */ | ||
| 276 | public function toNode(DOMDocument $document = null) | ||
| 323 | |||
| 324 | /** | ||
| 325 | * @param $number string | ||
| 326 | * | ||
| 327 | * @return $this | ||
| 328 | */ | ||
| 329 | public function setInvoiceNumber($number) | ||
| 335 | |||
| 336 | /** | ||
| 337 | * @return string | ||
| 338 | */ | ||
| 339 | public function getInvoiceNumber() | ||
| 343 | |||
| 344 | /** | ||
| 345 | * @param DateTime $date | ||
| 346 | * | ||
| 347 | * @return $this | ||
| 348 | */ | ||
| 349 | public function setInvoiceDate(DateTime $date) | ||
| 355 | |||
| 356 | /** | ||
| 357 | * @return DateTime | ||
| 358 | */ | ||
| 359 | public function getInvoiceDate() | ||
| 363 | |||
| 364 | /** | ||
| 365 | * @param $number | ||
| 366 | * | ||
| 367 | * @return $this | ||
| 368 | */ | ||
| 369 | public function setPurchaseOrderNumber($number) | ||
| 375 | |||
| 376 | /** | ||
| 377 | * @return string | ||
| 378 | */ | ||
| 379 | public function getPurchaseOrderNumber() | ||
| 383 | |||
| 384 | /** | ||
| 385 | * @param $terms | ||
| 386 | * | ||
| 387 | * @return $this | ||
| 388 | */ | ||
| 389 | public function setTermsOfShipment($terms) | ||
| 395 | |||
| 396 | /** | ||
| 397 | * @return string | ||
| 398 | */ | ||
| 399 | public function getTermsOfShipment() | ||
| 403 | |||
| 404 | /** | ||
| 405 | * @param $reason | ||
| 406 | * | ||
| 407 | * @return $this | ||
| 408 | */ | ||
| 409 | public function setReasonForExport($reason) | ||
| 419 | |||
| 420 | /** | ||
| 421 | * @return string | ||
| 422 | */ | ||
| 423 | public function getReasonForExport() | ||
| 427 | |||
| 428 | /** | ||
| 429 | * @param $comments | ||
| 430 | * | ||
| 431 | * @return $this | ||
| 432 | */ | ||
| 433 | View Code Duplication | public function setComments($comments) | |
| 443 | |||
| 444 | /** | ||
| 445 | * @return string | ||
| 446 | */ | ||
| 447 | public function getComments() | ||
| 451 | |||
| 452 | /** | ||
| 453 | * @param $code | ||
| 454 | * | ||
| 455 | * @return $this | ||
| 456 | */ | ||
| 457 | public function setCurrencyCode($code) | ||
| 463 | |||
| 464 | /** | ||
| 465 | * @return string | ||
| 466 | */ | ||
| 467 | public function getCurrencyCode() | ||
| 471 | |||
| 472 | /** | ||
| 473 | * @return string | ||
| 474 | */ | ||
| 475 | public function getDeclarationStatement() | ||
| 479 | |||
| 480 | public function setDeclarationStatement($statement) | ||
| 486 | } | ||
| 487 | 
This check marks private properties in classes that are never used. Those properties can be removed.