Completed
Pull Request — master (#202)
by
unknown
03:30
created
src/Shipping.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
         } elseif ($shipment->getItemizedPaymentInformation()) {
309 309
             $paymentNode = $shipmentNode->appendChild($xml->createElement('ItemizedPaymentInformation'));
310 310
 
311
-            for ($shipmentChargeRec = 1; $shipmentChargeRec <= 2; $shipmentChargeRec++)  {
311
+            for ($shipmentChargeRec = 1; $shipmentChargeRec <= 2; $shipmentChargeRec++) {
312 312
                
313 313
                if ($shipmentChargeRec == 1) { 
314 314
                   $rec = $shipment->getItemizedPaymentInformation()->getTransportationShipmentCharge(); 
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -312,12 +312,16 @@
 block discarded – undo
312 312
                
313 313
                if ($shipmentChargeRec == 1) { 
314 314
                   $rec = $shipment->getItemizedPaymentInformation()->getTransportationShipmentCharge(); 
315
-                  if ($rec == null) continue; 
315
+                  if ($rec == null) {
316
+                      continue;
317
+                  }
316 318
                   $node = $paymentNode->appendChild($xml->createElement('ShipmentCharge'));
317 319
                   $node->appendChild($xml->createElement('Type', \Ups\Entity\ShipmentCharge::SHIPMENT_CHARGE_TYPE_TRANSPORTATION));
318 320
                } else {
319 321
                   $rec = $shipment->getItemizedPaymentInformation()->getDutiesAndTaxesShipmentCharge(); 
320
-                  if ($rec == null) continue; 
322
+                  if ($rec == null) {
323
+                      continue;
324
+                  }
321 325
                   $node = $paymentNode->appendChild($xml->createElement('ShipmentCharge'));
322 326
                   $node->appendChild($xml->createElement('Type', \Ups\Entity\ShipmentCharge::SHIPMENT_CHARGE_TYPE_DUTIES));
323 327
                }
Please login to merge, or discard this patch.
src/Entity/ShipmentCharge.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      * @param BillShipper $billShipper
86 86
      * @return ShipmentCharge
87 87
      */
88
-    public function setBillShipper(BillShipper $billShipper= null)
88
+    public function setBillShipper(BillShipper $billShipper = null)
89 89
     {
90 90
         $this->billShipper = $billShipper;
91 91
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      * @param BillReceiver $billReceiver
105 105
      * @return ShipmentCharge
106 106
      */
107
-    public function setBillReceiver(BillReceiver $billReceiver= null)
107
+    public function setBillReceiver(BillReceiver $billReceiver = null)
108 108
     {
109 109
         $this->billReceiver = $billReceiver;
110 110
 
Please login to merge, or discard this patch.